-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support BanyanDB as storage #3790
Comments
@codefromthecrypt Excuse me, I'd like to know if the community could accept this component. |
Thanks for asking and offering. Storage options are the largest amount of code, and sometimes, their dependencies end up conflicting with others. This is especially the case for the zipkin-dependencies job. The tricky part about starting in zipkin main repo is also about who will use it. So typically, we collect interest first for the reason I mentioned on the issue (end users I mean). The contrib approach gives a chance to prove it without blocking albeit needing a separate docker image to use it. After end users start demanding it integrated in the main repo we can look at the dependencies of the contrib repo in question, viability in the dependencies job and if another author will maintain it. If things align we can consider integrating it later i mean. There are cases where that doesn't make sense or lacks the contributor time end users to move forward. Also in contrib there is a Kafka option by @jeqo which was very clever and well done even obviating the need for a dependencies (service topology) job. From a solution viewpoint, it is somewhat standalone even if likely the library dependencies would be no different from what's already in zipkin. Finally, we always have to be careful what we put into the box (particularly storage) due to match of user demand. Postgres has been requested for years as a replacement for mysql, and not doing that while adding things so far with little demand can make some jealous. Anyway I hope I covered all the points on this topic ;) If you add willing to start in a contrib repo, look at what @making has done there on zipkin-otel. If agreeable, @reta or I can make you a repo there noting I will be out next two weeks. Meanwhile anyone interested in this here (upstream) or in contrb please 👍 this issue and if you have an interesting reason why you want this or when please comment about it. Cheers! |
Thanks @CodePrometheus for this feature, I double @codefromthecrypt 's suggestion to go with contrib first, happy to help here |
Feature
BanyanDB an observability time series database, become the default storage option after skywalking v10.2+ and it has obvious improvements in memory and disk compared to ElasticSearch.
I'd like to implement this as an option for zipkin storage.
Rationale
In the case of large-scale data in Zipkin, there may be some optimizations that can be made in terms of storage.
The text was updated successfully, but these errors were encountered: