Skip to content

Commit 174472e

Browse files
committed
fix: improper TestConfiguration implementation
1 parent 19d70f2 commit 174472e

File tree

1 file changed

+6
-22
lines changed

1 file changed

+6
-22
lines changed

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/internal/CustomResourceEventSourceTest.java

+6-22
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,9 @@
66
import static org.mockito.Mockito.verify;
77
import static org.mockito.Mockito.when;
88

9-
import io.javaoperatorsdk.operator.api.config.ControllerConfiguration;
109
import java.time.LocalDateTime;
11-
import java.util.Arrays;
12-
1310
import java.util.List;
11+
1412
import org.junit.jupiter.api.BeforeEach;
1513
import org.junit.jupiter.api.Test;
1614

@@ -19,6 +17,7 @@
1917
import io.fabric8.kubernetes.client.dsl.MixedOperation;
2018
import io.fabric8.kubernetes.client.dsl.Resource;
2119
import io.javaoperatorsdk.operator.TestUtils;
20+
import io.javaoperatorsdk.operator.api.config.AbstractControllerConfiguration;
2221
import io.javaoperatorsdk.operator.api.config.ConfigurationService;
2322
import io.javaoperatorsdk.operator.processing.ConfiguredController;
2423
import io.javaoperatorsdk.operator.processing.event.EventHandler;
@@ -113,30 +112,15 @@ public MixedOperation<TestCustomResource, KubernetesResourceList<TestCustomResou
113112
return client;
114113
}
115114
}
116-
private static class TestConfiguration implements
117-
ControllerConfiguration<TestCustomResource> {
115+
private static class TestConfiguration extends
116+
AbstractControllerConfiguration<TestCustomResource> {
118117

119118
final ConfigurationService service = mock(ConfigurationService.class);
120-
final boolean generationAware;
121119

122120
public TestConfiguration(boolean generationAware) {
121+
super(null, null, null, FINALIZER, generationAware, null, null, null);
123122
when(service.getObjectMapper()).thenReturn(ConfigurationService.OBJECT_MAPPER);
124-
this.generationAware = generationAware;
125-
}
126-
127-
@Override
128-
public String getAssociatedControllerClassName() {
129-
return null;
130-
}
131-
132-
@Override
133-
public ConfigurationService getConfigurationService() {
134-
return service;
135-
}
136-
137-
@Override
138-
public boolean isGenerationAware() {
139-
return generationAware;
123+
setConfigurationService(service);
140124
}
141125
}
142126
}

0 commit comments

Comments
 (0)