Skip to content

Commit 6b21e58

Browse files
authored
improve: logging for informer health check (#1737)
1 parent 9d27453 commit 6b21e58

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/health/InformerHealthIndicator.java

+1-3
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@ public interface InformerHealthIndicator extends EventSourceHealthIndicator {
99
boolean isRunning();
1010

1111
@Override
12-
default Status getStatus() {
13-
return isRunning() && hasSynced() && isWatching() ? Status.HEALTHY : Status.UNHEALTHY;
14-
}
12+
Status getStatus();
1513

1614
String getTargetNamespace();
1715
}

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerWrapper.java

+11
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import io.javaoperatorsdk.operator.ReconcilerUtils;
2323
import io.javaoperatorsdk.operator.api.config.ConfigurationServiceProvider;
2424
import io.javaoperatorsdk.operator.health.InformerHealthIndicator;
25+
import io.javaoperatorsdk.operator.health.Status;
2526
import io.javaoperatorsdk.operator.processing.LifecycleAware;
2627
import io.javaoperatorsdk.operator.processing.event.ResourceID;
2728
import io.javaoperatorsdk.operator.processing.event.source.IndexerResourceCache;
@@ -175,6 +176,16 @@ public boolean isRunning() {
175176
return informer.isRunning();
176177
}
177178

179+
@Override
180+
public Status getStatus() {
181+
var status = isRunning() && hasSynced() && isWatching() ? Status.HEALTHY : Status.UNHEALTHY;
182+
log.debug(
183+
"Informer status: {} for for type: {}, namespace: {}, details[ is running: {}, has synced: {}, is watching: {} ]",
184+
status, informer.getApiTypeClass().getSimpleName(), namespaceIdentifier, isRunning(),
185+
hasSynced(), isWatching());
186+
return status;
187+
}
188+
178189
@Override
179190
public String getTargetNamespace() {
180191
return namespaceIdentifier;

0 commit comments

Comments
 (0)