improve: cleaner throws Exception (#2527)

csviri · csviri · commit 8457720dcdd2 · 2024-09-20T09:01:08.000+02:00
Signed-off-by: Attila Mészáros &lt;a_meszaros@apple.com&gt;
diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/Cleaner.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/Cleaner.java
@@ -27,6 +27,6 @@ public interface Cleaner<P extends HasMetadata> {
    *         that it can be safely deleted.
    * @see DeleteControl#noFinalizerRemoval()
    */
-  DeleteControl cleanup(P resource, Context<P> context);
+  DeleteControl cleanup(P resource, Context<P> context) throws Exception;
 
 }
diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/Controller.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/Controller.java
@@ -189,7 +189,7 @@ public Map<String, Object> metadata() {
             }
 
             @Override
-            public DeleteControl execute() {
+            public DeleteControl execute() throws Exception {
               initContextIfNeeded(resource, context);
               WorkflowCleanupResult workflowCleanupResult = null;
 

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,6 @@ public interface Cleaner<P extends HasMetadata> {`
`27`	`27`	`* that it can be safely deleted.`
`28`	`28`	`* @see DeleteControl#noFinalizerRemoval()`
`29`	`29`	`*/`
`30`		`- DeleteControl cleanup(P resource, Context<P> context);`
	`30`	`+ DeleteControl cleanup(P resource, Context<P> context) throws Exception;`
`31`	`31`
`32`	`32`	`}`
Original file line number	Diff line number	Diff line change
`@@ -189,7 +189,7 @@ public Map<String, Object> metadata() {`
`189`	`189`	`}`
`190`	`190`
`191`	`191`	`@Override`
`192`		`- public DeleteControl execute() {`
	`192`	`+ public DeleteControl execute() throws Exception {`
`193`	`193`	`initContextIfNeeded(resource, context);`
`194`	`194`	`WorkflowCleanupResult workflowCleanupResult = null;`
`195`	`195`