feat: non static reference of services (#1865)

Author: csviri

Diff for: micrometer-support/src/test/java/io/javaoperatorsdk/operator/monitoring/micrometer/AbstractMicrometerMetricsTestFixture.java

@@ -3,15 +3,12 @@
 import java.util.HashSet;
 import java.util.Set;
 
-import org.junit.jupiter.api.AfterAll;
-import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.TestInstance;
 import org.junit.jupiter.api.extension.RegisterExtension;
 
 import io.fabric8.kubernetes.api.model.ConfigMap;
 import io.fabric8.kubernetes.api.model.ConfigMapBuilder;
-import io.javaoperatorsdk.operator.api.config.ConfigurationServiceProvider;
 import io.javaoperatorsdk.operator.api.reconciler.*;
 import io.javaoperatorsdk.operator.junit.LocallyRunOperatorExtension;
 import io.javaoperatorsdk.operator.processing.event.ResourceID;
@@ -23,26 +20,21 @@
 
 @TestInstance(TestInstance.Lifecycle.PER_CLASS)
 public abstract class AbstractMicrometerMetricsTestFixture {
-  @RegisterExtension
-  LocallyRunOperatorExtension operator =
-      LocallyRunOperatorExtension.builder().withReconciler(new MetricsCleaningTestReconciler())
-          .build();
 
   protected final TestSimpleMeterRegistry registry = new TestSimpleMeterRegistry();
   protected final MicrometerMetrics metrics = getMetrics();
   protected static final String testResourceName = "micrometer-metrics-cr";
 
-  protected abstract MicrometerMetrics getMetrics();
 
-  @BeforeAll
-  void setup() {
-    ConfigurationServiceProvider.overrideCurrent(overrider -> overrider.withMetrics(metrics));
-  }
+  @RegisterExtension
+  LocallyRunOperatorExtension operator =
+      LocallyRunOperatorExtension.builder()
+          .withConfigurationService(overrider -> overrider.withMetrics(metrics))
+          .withReconciler(new MetricsCleaningTestReconciler())
+          .build();
 
-  @AfterAll
-  void reset() {
-    ConfigurationServiceProvider.reset();
-  }
+
+  protected abstract MicrometerMetrics getMetrics();
 
   @Test
   void properlyHandlesResourceDeletion() throws Exception {

Diff for: operator-framework-core/src/main/java/io/javaoperatorsdk/operator/ControllerManager.java

@@ -22,6 +22,12 @@ class ControllerManager {
   @SuppressWarnings("rawtypes")
   private final Map<String, Controller> controllers = new HashMap<>();
   private boolean started = false;
+  private final ExecutorServiceManager executorServiceManager;
+
+  public ControllerManager(ExecutorServiceManager executorServiceManager) {
+    this.executorServiceManager = executorServiceManager;
+  }
+
 
   public synchronized void shouldStart() {
     if (started) {
@@ -33,15 +39,15 @@ public synchronized void shouldStart() {
   }
 
   public synchronized void start(boolean startEventProcessor) {
-    ExecutorServiceManager.boundedExecuteAndWaitForAllToComplete(controllers().stream(), c -> {
+    executorServiceManager.boundedExecuteAndWaitForAllToComplete(controllers().stream(), c -> {
       c.start(startEventProcessor);
       return null;
     }, c -> "Controller Starter for: " + c.getConfiguration().getName());
     started = true;
   }
 
   public synchronized void stop() {
-    ExecutorServiceManager.boundedExecuteAndWaitForAllToComplete(controllers().stream(), c -> {
+    executorServiceManager.boundedExecuteAndWaitForAllToComplete(controllers().stream(), c -> {
       log.debug("closing {}", c);
       c.stop();
       return null;
@@ -50,7 +56,7 @@ public synchronized void stop() {
   }
 
   public synchronized void startEventProcessing() {
-    ExecutorServiceManager.boundedExecuteAndWaitForAllToComplete(controllers().stream(), c -> {
+    executorServiceManager.boundedExecuteAndWaitForAllToComplete(controllers().stream(), c -> {
       c.startEventProcessing();
       return null;
     }, c -> "Event processor starter for: " + c.getConfiguration().getName());

Diff for: operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java

@@ -1,9 +1,13 @@
 package io.javaoperatorsdk.operator;
 
+import java.util.Arrays;
 import java.util.Arrays;
 import java.util.UUID;
 import java.util.concurrent.CompletableFuture;
 
+import io.fabric8.kubernetes.api.model.authorization.v1.SelfSubjectRulesReview;
+import io.fabric8.kubernetes.api.model.authorization.v1.SelfSubjectRulesReviewSpecBuilder;
+import io.javaoperatorsdk.operator.api.config.ConfigurationService;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -14,8 +18,7 @@
 import io.fabric8.kubernetes.client.extended.leaderelection.LeaderElector;
 import io.fabric8.kubernetes.client.extended.leaderelection.LeaderElectorBuilder;
 import io.fabric8.kubernetes.client.extended.leaderelection.resourcelock.LeaseLock;
-import io.javaoperatorsdk.operator.api.config.ConfigurationServiceProvider;
-import io.javaoperatorsdk.operator.api.config.ExecutorServiceManager;
+import io.javaoperatorsdk.operator.api.config.ConfigurationService;
 import io.javaoperatorsdk.operator.api.config.LeaderElectionConfiguration;
 
 public class LeaderElectionManager {
@@ -30,45 +33,49 @@ public class LeaderElectionManager {
   private String identity;
   private CompletableFuture<?> leaderElectionFuture;
   private KubernetesClient client;
-  private String leaseName;
+  private final ConfigurationService configurationService;
   private String leaseNamespace;
 
-  public LeaderElectionManager(ControllerManager controllerManager) {
+  public LeaderElectionManager(KubernetesClient kubernetesClient,
+      ControllerManager controllerManager,
+      ConfigurationService configurationService) {
+    this.kubernetesClient = kubernetesClient;
     this.controllerManager = controllerManager;
+    this.configurationService = configurationService;
+  }
+
+  public boolean isLeaderElectionEnabled() {
+    return configurationService.getLeaderElectionConfiguration().isPresent();
   }
 
-  public void init(LeaderElectionConfiguration config, KubernetesClient client) {
-    this.client = client;
+  public void init(LeaderElectionConfiguration config) {
     this.identity = identity(config);
-    this.leaseName = config.getLeaseName();
     leaseNamespace =
-        config.getLeaseNamespace().orElseGet(
-            () -> ConfigurationServiceProvider.instance().getClientConfiguration().getNamespace());
+            config.getLeaseNamespace().orElseGet(
+                    () -> configurationService.getClientConfiguration().getNamespace());
     if (leaseNamespace == null) {
       final var message =
-          "Lease namespace is not set and cannot be inferred. Leader election cannot continue.";
+              "Lease namespace is not set and cannot be inferred. Leader election cannot continue.";
       log.error(message);
       throw new IllegalArgumentException(message);
     }
-    final var lock = new LeaseLock(leaseNamespace, leaseName, identity);
+    final var lock = new LeaseLock(leaseNamespace, config.getLeaseName(), identity);
     // releaseOnCancel is not used in the underlying implementation
-    leaderElector =
-        new LeaderElectorBuilder(
-            client, ExecutorServiceManager.instance().executorService())
-            .withConfig(new LeaderElectionConfig(
-                lock,
-                config.getLeaseDuration(),
-                config.getRenewDeadline(),
-                config.getRetryPeriod(),
-                leaderCallbacks(),
-                true,
-                config.getLeaseName()))
+    leaderElector = new LeaderElectorBuilder(
+            kubernetesClient, configurationService.getExecutorServiceManager().cachingExecutorService())
+            .withConfig(
+                    new LeaderElectionConfig(
+                            lock,
+                            config.getLeaseDuration(),
+                            config.getRenewDeadline(),
+                            config.getRetryPeriod(),
+                            leaderCallbacks(),
+                            true,
+                            config.getLeaseName()))
             .build();
   }
 
-  public boolean isLeaderElectionEnabled() {
-    return leaderElector != null;
-  }
+
 
   private LeaderCallbacks leaderCallbacks() {
     return new LeaderCallbacks(
@@ -99,6 +106,7 @@ private String identity(LeaderElectionConfiguration config) {
 
   public void start() {
     if (isLeaderElectionEnabled()) {
+      init(configurationService.getLeaderElectionConfiguration().orElseThrow());
       checkLeaseAccess();
       leaderElectionFuture = leaderElector.start();
     }
@@ -117,13 +125,13 @@ private void checkLeaseAccess() {
     var reviewResult = client.resource(review).create();
     log.debug("SelfSubjectRulesReview result: {}", reviewResult);
     var foundRule = reviewResult.getStatus().getResourceRules().stream()
-        .filter(rule -> rule.getApiGroups().contains("coordination.k8s.io")
-            && rule.getResources().contains("leases")
-            && (rule.getVerbs().containsAll(verbs)) || rule.getVerbs().contains("*"))
-        .findAny();
+            .filter(rule -> rule.getApiGroups().contains("coordination.k8s.io")
+                    && rule.getResources().contains("leases")
+                    && (rule.getVerbs().containsAll(verbs)) || rule.getVerbs().contains("*"))
+            .findAny();
     if (foundRule.isEmpty()) {
       throw new OperatorException(NO_PERMISSION_TO_LEASE_RESOURCE_MESSAGE +
-          " in namespace: " + leaseNamespace);
+              " in namespace: " + leaseNamespace);
     }
   }
 }

Diff for: operator-framework-core/src/main/java/io/javaoperatorsdk/operator/Operator.java

@@ -14,12 +14,11 @@
 import io.fabric8.kubernetes.client.KubernetesClient;
 import io.fabric8.kubernetes.client.KubernetesClientBuilder;
 import io.fabric8.kubernetes.client.Version;
+import io.javaoperatorsdk.operator.api.config.BaseConfigurationService;
 import io.javaoperatorsdk.operator.api.config.ConfigurationService;
 import io.javaoperatorsdk.operator.api.config.ConfigurationServiceOverrider;
-import io.javaoperatorsdk.operator.api.config.ConfigurationServiceProvider;
 import io.javaoperatorsdk.operator.api.config.ControllerConfiguration;
 import io.javaoperatorsdk.operator.api.config.ControllerConfigurationOverrider;
-import io.javaoperatorsdk.operator.api.config.ExecutorServiceManager;
 import io.javaoperatorsdk.operator.api.reconciler.Reconciler;
 import io.javaoperatorsdk.operator.processing.Controller;
 import io.javaoperatorsdk.operator.processing.LifecycleAware;
@@ -29,17 +28,18 @@ public class Operator implements LifecycleAware {
   private static final Logger log = LoggerFactory.getLogger(Operator.class);
   private static final int DEFAULT_MAX_CONCURRENT_REQUEST = 512;
   private final KubernetesClient kubernetesClient;
-  private final ControllerManager controllerManager = new ControllerManager();
-  private final LeaderElectionManager leaderElectionManager =
-      new LeaderElectionManager(controllerManager);
+  private final ControllerManager controllerManager;
+  private final LeaderElectionManager leaderElectionManager;
+  private final ConfigurationService configurationService;
   private volatile boolean started = false;
 
+
   public Operator() {
     this((KubernetesClient) null);
   }
 
   public Operator(KubernetesClient kubernetesClient) {
-    this(kubernetesClient, ConfigurationServiceProvider.instance());
+    this(kubernetesClient, new BaseConfigurationService());
   }
 
   /**
@@ -56,7 +56,8 @@ public Operator(Consumer<ConfigurationServiceOverrider> overrider) {
   }
 
   public Operator(KubernetesClient client, Consumer<ConfigurationServiceOverrider> overrider) {
-    this(client, ConfigurationServiceProvider.overrideCurrent(overrider));
+    this(client, ConfigurationService
+        .newOverriddenConfigurationService(new BaseConfigurationService(), overrider));
   }
 
   /**
@@ -67,15 +68,19 @@ public Operator(KubernetesClient client, Consumer<ConfigurationServiceOverrider>
    * @param configurationService provides configuration
    */
   public Operator(KubernetesClient kubernetesClient, ConfigurationService configurationService) {
+    this.configurationService = configurationService;
+    final var executorServiceManager = configurationService.getExecutorServiceManager();
+    controllerManager = new ControllerManager(executorServiceManager);
     this.kubernetesClient =
         kubernetesClient != null ? kubernetesClient
             : new KubernetesClientBuilder()
                 .withConfig(new ConfigBuilder()
                     .withMaxConcurrentRequests(DEFAULT_MAX_CONCURRENT_REQUEST).build())
                 .build();
-    ConfigurationServiceProvider.set(configurationService);
-    configurationService.getLeaderElectionConfiguration()
-        .ifPresent(c -> leaderElectionManager.init(c, this.kubernetesClient));
+
+
+    leaderElectionManager =
+        new LeaderElectionManager(kubernetesClient, controllerManager, configurationService);
   }
 
   /**
@@ -86,8 +91,7 @@ public Operator(KubernetesClient kubernetesClient, ConfigurationService configur
    */
   @Deprecated(forRemoval = true)
   public void installShutdownHook() {
-    installShutdownHook(
-        Duration.ofSeconds(ConfigurationServiceProvider.instance().getTerminationTimeoutSeconds()));
+    installShutdownHook(Duration.ofSeconds(configurationService.getTerminationTimeoutSeconds()));
   }
 
   /**
@@ -123,9 +127,8 @@ public synchronized void start() {
       if (started) {
         return;
       }
-      ExecutorServiceManager.init();
       controllerManager.shouldStart();
-      final var version = ConfigurationServiceProvider.instance().getVersion();
+      final var version = configurationService.getVersion();
       log.info(
           "Operator SDK {} (commit: {}) built on {} starting...",
           version.getSdkVersion(),
@@ -149,12 +152,11 @@ public void stop(Duration gracefulShutdownTimeout) throws OperatorException {
     if (!started) {
       return;
     }
-    final var configurationService = ConfigurationServiceProvider.instance();
     log.info(
         "Operator SDK {} is shutting down...", configurationService.getVersion().getSdkVersion());
     controllerManager.stop();
 
-    ExecutorServiceManager.stop(gracefulShutdownTimeout);
+    configurationService.getExecutorServiceManager().stop(gracefulShutdownTimeout);
     leaderElectionManager.stop();
     if (configurationService.closeClientOnStop()) {
       kubernetesClient.close();
@@ -179,8 +181,7 @@ public void stop() throws OperatorException {
    */
   public <P extends HasMetadata> RegisteredController<P> register(Reconciler<P> reconciler)
       throws OperatorException {
-    final var controllerConfiguration =
-        ConfigurationServiceProvider.instance().getConfigurationFor(reconciler);
+    final var controllerConfiguration = configurationService.getConfigurationFor(reconciler);
     return register(reconciler, controllerConfiguration);
   }
 
@@ -210,7 +211,7 @@ public <P extends HasMetadata> RegisteredController<P> register(Reconciler<P> re
               " reconciler named " + ReconcilerUtils.getNameFor(reconciler)
               + " because its configuration cannot be found.\n" +
               " Known reconcilers are: "
-              + ConfigurationServiceProvider.instance().getKnownReconcilerNames());
+              + configurationService.getKnownReconcilerNames());
     }
 
     final var controller = new Controller<>(reconciler, configuration, kubernetesClient);
@@ -239,7 +240,7 @@ public <P extends HasMetadata> RegisteredController<P> register(Reconciler<P> re
   public <P extends HasMetadata> RegisteredController<P> register(Reconciler<P> reconciler,
       Consumer<ControllerConfigurationOverrider<P>> configOverrider) {
     final var controllerConfiguration =
-        ConfigurationServiceProvider.instance().getConfigurationFor(reconciler);
+        configurationService.getConfigurationFor(reconciler);
     var configToOverride = ControllerConfigurationOverrider.override(controllerConfiguration);
     configOverrider.accept(configToOverride);
     return register(reconciler, configToOverride.build());
@@ -264,4 +265,8 @@ public RuntimeInfo getRuntimeInfo() {
   boolean isStarted() {
     return started;
   }
+
+  public ConfigurationService getConfigurationService() {
+    return configurationService;
+  }
 }

Diff for: operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/BaseConfigurationService.java

@@ -107,8 +107,7 @@ protected <P extends HasMetadata> ControllerConfiguration<P> configFor(Reconcile
               " annotation for reconciler:  " + reconciler);
     }
     Class<Reconciler<P>> reconcilerClass = (Class<Reconciler<P>>) reconciler.getClass();
-    final var resourceClass = ConfigurationServiceProvider.instance().getResourceClassResolver()
-        .getResourceClass(reconcilerClass);
+    final var resourceClass = getResourceClassResolver().getResourceClass(reconcilerClass);
 
     final var name = ReconcilerUtils.getNameFor(reconciler);
     final var generationAware = valueOrDefault(
@@ -152,7 +151,7 @@ protected <P extends HasMetadata> ControllerConfiguration<P> configFor(Reconcile
             io.javaoperatorsdk.operator.api.reconciler.ControllerConfiguration::labelSelector,
             Constants.NO_VALUE_SET),
         null,
-        Utils.instantiate(annotation.itemStore(), ItemStore.class, context));
+        Utils.instantiate(annotation.itemStore(), ItemStore.class, context), this);
 
     ResourceEventFilter<P> answer = deprecatedEventFilter(annotation);
     config.setEventFilter(answer != null ? answer : ResourceEventFilters.passthrough());