Patch boxcutter steps to rewrite Progressing cond. to follow original contract

Signed-off-by: Per Goncalves da Silva <[email protected]>

Author: Per Goncalves da Silva

internal/operator-controller/controllers/boxcutter_reconcile_steps.go

@@ -153,6 +153,23 @@ func ApplyBundleWithBoxcutter(a Applier) ReconcileStepFunc {
 				ext.Status.ActiveRevisions = append(ext.Status.ActiveRevisions, rs)
 			}
 		}
+
+		// Rewrite Progressing condition to respect the existing contract
+		// Currently ClusterExtension treats the Progressing condition in the same way as the Deployment resource
+		// It signals there's nothing in the way of the resource progressing rather than the resource is undergoing
+		// active reconciliation at the moment. In order to not break the original contract, we rewrite the condition.
+		// This should be temporary until we understand whether we can change how the Progressing condition operates.
+		if cnd := apimeta.FindStatusCondition(ext.Status.Conditions, ocv1.ClusterExtensionRevisionTypeProgressing); cnd != nil {
+			if cnd.Status == metav1.ConditionFalse && cnd.Reason == ocv1.ClusterExtensionRevisionReasonRolledOut {
+				cnd.Status = metav1.ConditionTrue
+				cnd.Reason = ocv1.ReasonSucceeded
+				apimeta.SetStatusCondition(&ext.Status.Conditions, *cnd)
+			}
+			if cnd.Reason == ocv1.ClusterExtensionRevisionReasonRolloutError {
+				cnd.Reason = ocv1.ReasonRetrying
+			}
+		}
+		setInstalledStatusFromRevisionStates(ext, revisionStates)
 		return ctx, nil, nil
 	}
 }