Skip to content

Commit 6b26fd0

Browse files
committed
Rm commented code, fix logging
Signed-off-by: Brett Tofel <[email protected]>
1 parent 633e6ad commit 6b26fd0

File tree

2 files changed

+7
-15
lines changed

2 files changed

+7
-15
lines changed

cmd/manager/main.go

+1-10
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ func main() {
121121
}
122122
dependentSelector := k8slabels.NewSelector().Add(*dependentRequirement)
123123

124-
fmt.Println("set up manager")
124+
setupLog.Info("set up manager")
125125
mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
126126
Scheme: scheme.Scheme,
127127
Metrics: server.Options{BindAddress: metricsAddr},
@@ -202,15 +202,6 @@ func main() {
202202
os.Exit(1)
203203
}
204204

205-
// if err = (&controllers.ExtensionReconciler{
206-
// Client: cl,
207-
// BundleProvider: catalogClient,
208-
// }).SetupWithManager(mgr); err != nil {
209-
// setupLog.Error(err, "unable to create controller", "controller", "Extension")
210-
// os.Exit(1)
211-
// }
212-
//+kubebuilder:scaffold:builder
213-
214205
if err := mgr.AddHealthzCheck("healthz", healthz.Ping); err != nil {
215206
setupLog.Error(err, "unable to set up health check")
216207
os.Exit(1)

cmd/unpack/main.go

+6-5
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,13 @@ import (
1414

1515
"github.com/spf13/cobra"
1616
"k8s.io/apimachinery/pkg/util/sets"
17+
18+
"github.com/operator-framework/operator-controller/internal/version"
1719
)
1820

1921
func main() {
2022
var bundleDir string
21-
var opConVersion bool
23+
var operatorControllerVersion bool
2224

2325
skipRootPaths := sets.NewString(
2426
"/dev",
@@ -33,9 +35,8 @@ func main() {
3335
Use: "unpack",
3436
Args: cobra.ExactArgs(0),
3537
RunE: func(cmd *cobra.Command, _ []string) error {
36-
if opConVersion {
37-
// TODO
38-
//fmt.Println(version.String())
38+
if operatorControllerVersion {
39+
log.Println(version.String())
3940
os.Exit(0)
4041
}
4142
var err error
@@ -113,7 +114,7 @@ func main() {
113114
},
114115
}
115116
cmd.Flags().StringVar(&bundleDir, "bundle-dir", "", "directory in which the bundle can be found")
116-
cmd.Flags().BoolVar(&opConVersion, "version", false, "displays operator-controller version information")
117+
cmd.Flags().BoolVar(&operatorControllerVersion, "version", false, "displays operator-controller version information")
117118

118119
if err := cmd.Execute(); err != nil {
119120
log.Fatal(err)

0 commit comments

Comments
 (0)