Add newline to missingrules error

trgeiger · trgeiger · commit 9b6aca435a95 · 2025-04-21T12:02:31.000-05:00
This prevents the missing rules output from running straight into
any following authorization error. Linting exception added for ending
error in newline--the clarity created by the newline is useful with such
a long output..

Signed-off-by: Tayler Geiger &lt;tayler@redhat.com&gt;
diff --git a/internal/operator-controller/applier/helm.go b/internal/operator-controller/applier/helm.go
@@ -103,7 +103,7 @@ func (h *Helm) runPreAuthorizationChecks(ctx context.Context, ext *ocv1.ClusterE
 			}
 		}
 		slices.Sort(missingRuleDescriptions)
-		preAuthErrors = append(preAuthErrors, fmt.Errorf("service account requires the following permissions to manage cluster extension:\n  %s", strings.Join(missingRuleDescriptions, "\n  ")))
+		preAuthErrors = append(preAuthErrors, fmt.Errorf("service account requires the following permissions to manage cluster extension:\n  %s\n", strings.Join(missingRuleDescriptions, "\n  "))) //nolint:stylecheck
 	}
 	if authErr != nil {
 		preAuthErrors = append(preAuthErrors, fmt.Errorf("authorization evaluation error: %w", authErr))

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ func (h Helm) runPreAuthorizationChecks(ctx context.Context, ext ocv1.ClusterE`
`103`	`103`	`}`
`104`	`104`	`}`
`105`	`105`	`slices.Sort(missingRuleDescriptions)`
`106`		`- preAuthErrors = append(preAuthErrors, fmt.Errorf("service account requires the following permissions to manage cluster extension:\n %s", strings.Join(missingRuleDescriptions, "\n ")))`
	`106`	`+ preAuthErrors = append(preAuthErrors, fmt.Errorf("service account requires the following permissions to manage cluster extension:\n %s\n", strings.Join(missingRuleDescriptions, "\n "))) //nolint:stylecheck`
`107`	`107`	`}`
`108`	`108`	`if authErr != nil {`
`109`	`109`	`preAuthErrors = append(preAuthErrors, fmt.Errorf("authorization evaluation error: %w", authErr))`