Skip to content

Conversation

@trgeiger
Copy link
Contributor

@trgeiger trgeiger commented Nov 13, 2025

Changes the ClusterExtension API field spec.ServiceAccount to be optional. Operator-controller will use its own service account by default unless the spec.ServiceAccount field is set. RBAC PreAuthorization only happens if the optional SA field is set, as well.

Give operator-controller's SA cluster-admin by default.

Addresses OPRUN-4219

Wasn't sure if I should mark this major or minor change.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@trgeiger trgeiger requested a review from a team as a code owner November 13, 2025 21:21
@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 435dc41
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/69164f611f283a00081eff31
😎 Deploy Preview https://deploy-preview-2333--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci
Copy link

openshift-ci bot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign camilamacedo86, thetechnick for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@trgeiger trgeiger marked this pull request as draft November 13, 2025 21:21
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2025
Changes the ClusterExtension API field spec.ServiceAccount to be
optional. Operator-controller will use its own service account by
default unless the spec.ServiceAccount field is set. RBAC
PreAuthorization only happens if the optional SA field is set, as well.

Give operator-controller's SA cluster-admin by default.
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.28%. Comparing base (d204888) to head (435dc41).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
internal/operator-controller/action/restconfig.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2333      +/-   ##
==========================================
- Coverage   74.42%   74.28%   -0.14%     
==========================================
  Files          91       91              
  Lines        7057     7085      +28     
==========================================
+ Hits         5252     5263      +11     
- Misses       1393     1406      +13     
- Partials      412      416       +4     
Flag Coverage Δ
e2e 45.63% <0.00%> (-0.24%) ⬇️
experimental-e2e 48.38% <0.00%> (-0.08%) ⬇️
unit 58.58% <33.33%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trgeiger trgeiger changed the title ✨ Use operator-controller SA by default, make SA field optional ✨ OPRUN-4219: Use operator-controller SA by default, make SA field optional Nov 13, 2025
@trgeiger
Copy link
Contributor Author

Due to the changes to the clusterrole, I don't think this is ever going to pass upgrade-e2e since it can't change the clusterrole in place. What's the cleanest way of handling this, versioning our clusterrole moving forward? Just make a new one like the existing boxcutter experimental config does?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant