fix:issue-5041

Signed-off-by: cndoit18 <[email protected]>

Author: cndoit18

Diff for: changelog/fragments/helm-deepequals.yaml

@@ -0,0 +1,4 @@
+entries:
+  - description: >
+      For Helm-based operators, fixed a bug where getting a new helm release revision for every reconciliation, even there are no changes at all.
+    kind: bugfix

Diff for: internal/helm/release/manager.go

@@ -143,6 +143,20 @@ func (m manager) isUpgrade(deployedRelease *rpb.Release) bool {
 	// Judging whether to skip updates
 	skip := m.namespace == deployedRelease.Namespace
 	skip = skip && m.releaseName == deployedRelease.Name
+
+	_ = apiequality.Semantic.AddFunc(func(a, b *cpb.Chart) bool {
+		if a == nil || b == nil {
+			return a == b
+		}
+		aencode := &bytes.Buffer{}
+		bencode := &bytes.Buffer{}
+
+		_ = json.NewEncoder(aencode).Encode(a)
+		_ = json.NewEncoder(bencode).Encode(b)
+
+		return aencode.String() == bencode.String()
+	})
+
 	skip = skip && apiequality.Semantic.DeepEqual(m.chart, deployedRelease.Chart)
 	skip = skip && apiequality.Semantic.DeepEqual(m.values, deployedRelease.Config)
 

Diff for: internal/helm/release/manager_test.go

@@ -15,6 +15,8 @@
 package release
 
 import (
+	"bytes"
+	"encoding/json"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -277,9 +279,12 @@ func newTestRelease(chart *cpb.Chart, values map[string]interface{}, name, names
 	release := rpb.Mock(&rpb.MockReleaseOptions{
 		Name:      name,
 		Namespace: namespace,
-		Chart:     chart,
 		Version:   1,
 	})
+
+	buffer := &bytes.Buffer{}
+	_ = json.NewEncoder(buffer).Encode(chart)
+	_ = json.NewDecoder(buffer).Decode(release.Chart)
 	release.Config = values
 	return release
 }