-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable the submit button until an answer option is selected or an answer is typed #71
Comments
See also a similar issue for Web: #79. That issue talks about giving the learner clear guidance if they click the disabled button without entering an answer. We should do the same on Android. |
Hi Team here are the final mockup and figma file: |
FYI, noting that there's an accessibility concern with showing a message when a disabled button is clicked (see email thread). So these mocks may not be final yet. |
Error messages for the 12 question types:
Copy iterating figma file if interested: |
Thanks @jlevick! One thought: for "Click on image" input, let's add a message for that as well, as a fallback. In order to standardize things, we might end up treating it similar to multiple-choice in the future, i.e. the learner clicks a spot on that image and then clicks submit to confirm their selection. What should the message be in that case? (We probably won't change this yet, but we've had to go through a similar process before for multiple-choice -- it used to be that clicking automatically submitted the answer -- so I think it's worth planning for this case as well.) Thanks! |
@seanlip I've updated the above with the error message for 'Click on image'. Per the Android Design Team's discussion this evening, I've changed the drag and drop sort message as well. Thanks! |
We discussed this yesterday during our call and found the relevant screens for different types of questions to see how relevant the error messages are. (I.e selecting images ones have no submit button.) Himali said she will have one final version to share and I will approve that one. Thanks. |
Following up on that @sean. Do we need to have screens for each error message with the relevant type of question showing on the screen? |
@kaiyuxu. Do we have figma file for each type of questions? You had mentioned we have Adobe XD files right? Can you please share link to that? |
Hi @Himali07 -- no, that's not necessary. Thanks for checking! |
Sounds good. Thanks @seanlip. At @kaiyuxu, I think then we are good from design point of view. I am attaching the mock up and figma file for your design approval. Thank you. |
Hi Kenneth,
Can you help take a look at the Figma and let us know if a dark mode for a
similar design already exists in the Android app?
Thank you,
Kaiyu
…On Mon, Jun 12, 2023 at 5:14 PM Himali07 ***@***.***> wrote:
Sounds good. Thanks @seanlip <https://github.com/seanlip>.
At @kaiyuxu <https://github.com/kaiyuxu>, I think then we are good from
design point of view.
The click on image to answer type of question are not needed to be
addressed. Check in Jaime's Figma file
<https://www.figma.com/file/TCgSWSCMT0E2jIORyH7486/J.Levick---Oppia-Copy?type=design&node-id=0-1&t=BBel4vOLSecuCxjx-0>
for clarification .
I am attaching the mock up and figma file for your design approval.
Figma
<https://www.figma.com/file/dHUz2vH8M0Tms4t0xwz3sj/Oppia-Anroid-App_HL?type=design&node-id=1-17539&t=Y6WcnkfhuVIRBaCg-0>
Mock up
<https://www.figma.com/proto/dHUz2vH8M0Tms4t0xwz3sj/Oppia-Anroid-App_HL?type=design&node-id=189-10117&scaling=min-zoom&page-id=1%3A17539&starting-point-node-id=189%3A10117&show-proto-sidebar=1>
Thank you.
—
Reply to this email directly, view it on GitHub
<#71 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH6PWHFME2Q7HTBTJYWC6WTXK6WEPANCNFSM6AAAAAAW6B2FQA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Kaiyu Xu
Tel: (+1) 510-990-5445
Email: kaiyu ***@***.***>.***@***.***
|
Hi Kaiyu,
I have replied to this in the earlier email. You should have received it
by now. I am not very sure what I was supposed to review but I think the
design looks good. However, is a bit lighter than the current
implementation. I attached screenshots in the other email. Be sure to check
them out.
Thanks,
Kenneth.
|
Since this seems to be approved by UXD/UXW I have filed it on Oppia Android here: oppia/oppia-android#5070 If further changes are needed, please feel free to update the mocks directly and comment on that issue. Also, @Himali07, one question. What should the colour of the text be in dark mode -- could you please specify this in the mocks? (Once you've done that, please comment here and we can close this issue.) Thanks! |
@seanlip Let me know if this answers your question. |
Yup it does. Thanks @Himali07! Closing this issue as completed. |
… button enabled when answer is empty. (#5224) Fix part of #5070: In FractionInteraction UI, leave submit button enabled when answer is empty. Show an error on submitting an empty answer. The error message already exists and is the same as in oppia/oppia#18379. Demo video: [leave_submit_button_enabled_on_empty_answer_v3.webm](https://github.com/oppia/oppia-android/assets/103062089/d072ae88-c462-455c-a324-57680d4a82c5) The new error messages for empty inputs on submit are listed here: [oppia/design-team#71(comment)](oppia/design-team#71 (comment)) I added an accessibility-label exemption for FractionInputInteractionViewTestActivity as this activity is only used in tests. Fix #4135: incidentaly, this change also fixes #4135, since I had to split the tests for FractionInputInteraction ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only <!-- Delete these section if this PR does not include UI-related changes. --> If your PR includes UI-related changes, then: - Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes - For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see [RTL guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines)) - Add a video showing the full UX flow with a screen reader enabled (see [accessibility guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide)) - For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included - Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing --------- Co-authored-by: Adhiambo Peres <[email protected]>
Platform
Oppia Android
Describe the request
We've received some learner feedback that:
Suggestions for addressing these include:
The aim of this design request is to look through all question types in the Android app and verify that they are intuitive in informing the learner about what they should do next.
Context for the request
This feedback comes from 2 learners and involves auditing the existing "play lessons" feature in the Android app.
Link to PRD
N/A
Information about deadlines/priorities
This can be tackled at the regular priority.
DESIGN APPROVAL CHECKLIST -- DO NOT EDIT.
For a design project to be completed, it needs approval from UXD, UXW and PM. Please tag the following reviewers when your project is ready (it's enough to have one signoff from each of UXD, UXW and PM):
The text was updated successfully, but these errors were encountered: