Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the submit button until an answer option is selected or an answer is typed #71

Closed
2 of 3 tasks
seanlip opened this issue Apr 14, 2023 · 17 comments
Closed
2 of 3 tasks
Assignees

Comments

@seanlip
Copy link
Member

seanlip commented Apr 14, 2023

Platform
Oppia Android

Describe the request

We've received some learner feedback that:

  • The student did not understand that she is expected to tap on an answer option before she can proceed.
  • The student did not understand that she is expected to input an answer in the input field. She was confused about not seeing the Continue button like in the previous cards.

Suggestions for addressing these include:

  • Disable the Submit button until an answer/response is selected.
  • Consider adding hints along the lines of "Click on the correct answer below" to the various question types, e.g. multiple-choice questions.

The aim of this design request is to look through all question types in the Android app and verify that they are intuitive in informing the learner about what they should do next.

Context for the request

This feedback comes from 2 learners and involves auditing the existing "play lessons" feature in the Android app.

Link to PRD
N/A

Information about deadlines/priorities
This can be tackled at the regular priority.

DESIGN APPROVAL CHECKLIST -- DO NOT EDIT.

  • UX Design approved (Android mocks should include dark mode)
  • UX Writing approved
  • Product approved

For a design project to be completed, it needs approval from UXD, UXW and PM. Please tag the following reviewers when your project is ready (it's enough to have one signoff from each of UXD, UXW and PM):

@seanlip seanlip changed the title (Android app) Disable the submit button until an answer option is selected or an answer is typed Disable the submit button until an answer option is selected or an answer is typed Apr 14, 2023
@seanlip
Copy link
Member Author

seanlip commented Apr 18, 2023

See also a similar issue for Web: #79.

That issue talks about giving the learner clear guidance if they click the disabled button without entering an answer. We should do the same on Android.

@danapj danapj self-assigned this May 23, 2023
@Himali07
Copy link

Hi Team here are the final mockup and figma file:

  1. Design Figma File

  2. Mock up

@seanlip
Copy link
Member Author

seanlip commented May 31, 2023

FYI, noting that there's an accessibility concern with showing a message when a disabled button is clicked (see email thread). So these mocks may not be final yet.

@seanlip seanlip assigned jlevick and unassigned danapj Jun 1, 2023
@jlevick jlevick moved this from Not Started to In Progress in UX Design + UX Writing Projects Board Jun 1, 2023
@jlevick
Copy link

jlevick commented Jun 7, 2023

Error messages for the 12 question types:

  • Drag-and-drop sort

    • Arrange the boxes to continue
  • Fraction input

    • Enter a fraction to continue
  • Checkbox input

    • Choose an answer to continue
  • Multiple choice input

    • Choose an answer to continue
  • Math equation (e.g. 2x + 3y = 5)

    • Enter a number to continue
  • Algebraic expression (e.g. 2x + 3y)

    • Enter a number to continue
  • Number input

    • Enter a number to continue
  • Numeric expression (e.g. 5 + 2)

    • Enter a number to continue
  • Ratio input

    • Enter a ratio to continue
  • Text input

    • Enter an answer to continue
  • Number with units (e.g. 4 km)

    • Enter an answer to continue
  • Click on image

    • (Android) Tap on image to continue
    • (Web) Click on image to continue

Copy iterating figma file if interested:
https://www.figma.com/file/TCgSWSCMT0E2jIORyH7486/J.Levick---Oppia-Copy?type=design&node-id=0%3A1&t=2ofXr60TdxSL7Ulu-1

@seanlip
Copy link
Member Author

seanlip commented Jun 8, 2023

Thanks @jlevick!

One thought: for "Click on image" input, let's add a message for that as well, as a fallback. In order to standardize things, we might end up treating it similar to multiple-choice in the future, i.e. the learner clicks a spot on that image and then clicks submit to confirm their selection. What should the message be in that case?

(We probably won't change this yet, but we've had to go through a similar process before for multiple-choice -- it used to be that clicking automatically submitted the answer -- so I think it's worth planning for this case as well.)

Thanks!

@jlevick
Copy link

jlevick commented Jun 8, 2023

@seanlip I've updated the above with the error message for 'Click on image'. Per the Android Design Team's discussion this evening, I've changed the drag and drop sort message as well. Thanks!

@seanlip
Copy link
Member Author

seanlip commented Jun 9, 2023

Great, thanks @jlevick!

@kaiyuxu can you approve this project for UXD (see checklist in first comment) and set its status to "Handed off to PM", or does it still need more work on the UXD side? Thanks!

@seanlip seanlip moved this from In Progress to Waiting on UX Lead Approval in UX Design + UX Writing Projects Board Jun 9, 2023
@kaiyuxu
Copy link

kaiyuxu commented Jun 9, 2023

We discussed this yesterday during our call and found the relevant screens for different types of questions to see how relevant the error messages are. (I.e selecting images ones have no submit button.) Himali said she will have one final version to share and I will approve that one. Thanks.

@Himali07
Copy link

Following up on that @sean. Do we need to have screens for each error message with the relevant type of question showing on the screen?
For example Algebraic expressions: To have screens showing algebraic equations question + Error message for algebra questions just so that engineers can match the right question with error messages?

@Himali07
Copy link

@kaiyuxu. Do we have figma file for each type of questions? You had mentioned we have Adobe XD files right? Can you please share link to that?

@seanlip
Copy link
Member Author

seanlip commented Jun 13, 2023

Following up on that @sean. Do we need to have screens for each error message with the relevant type of question showing on the screen?
For example Algebraic expressions: To have screens showing algebraic equations question + Error message for algebra questions just so that engineers can match the right question with error messages?

Hi @Himali07 -- no, that's not necessary. Thanks for checking!

@Himali07
Copy link

Sounds good. Thanks @seanlip.

At @kaiyuxu, I think then we are good from design point of view.
The click on image to answer type of question are not needed to be addressed. Check in Jaime's Figma file for clarification .

I am attaching the mock up and figma file for your design approval.
Figma
Mock up

Thank you.

@kaiyuxu
Copy link

kaiyuxu commented Jun 18, 2023 via email

@kaiyuxu
Copy link

kaiyuxu commented Jun 19, 2023 via email

@seanlip
Copy link
Member Author

seanlip commented Jun 20, 2023

Since this seems to be approved by UXD/UXW I have filed it on Oppia Android here: oppia/oppia-android#5070

If further changes are needed, please feel free to update the mocks directly and comment on that issue.

Also, @Himali07, one question. What should the colour of the text be in dark mode -- could you please specify this in the mocks? (Once you've done that, please comment here and we can close this issue.) Thanks!

@Himali07
Copy link

Himali07 commented Jun 21, 2023

@seanlip
I have added the error message color code for dark mode to the same figma file.
Here is the screen shot.

Image

Let me know if this answers your question.
Thanks :)

@seanlip
Copy link
Member Author

seanlip commented Jun 21, 2023

Yup it does. Thanks @Himali07! Closing this issue as completed.

@seanlip seanlip closed this as completed Jun 21, 2023
@github-project-automation github-project-automation bot moved this from Handed off to PM to Completed in UX Design + UX Writing Projects Board Jun 21, 2023
BenHenning pushed a commit to oppia/oppia-android that referenced this issue Jan 9, 2024
… button enabled when answer is empty. (#5224)

Fix part of #5070: In
FractionInteraction UI, leave submit button enabled when answer is
empty. Show an error on submitting an empty answer. The error message
already exists and is the same as in
oppia/oppia#18379.

Demo video:
[leave_submit_button_enabled_on_empty_answer_v3.webm](https://github.com/oppia/oppia-android/assets/103062089/d072ae88-c462-455c-a324-57680d4a82c5)

The new error messages for empty inputs on submit are listed here:
[oppia/design-team#71(comment)](oppia/design-team#71 (comment))

I added an accessibility-label exemption for
FractionInputInteractionViewTestActivity as this activity is only used
in tests.

Fix #4135: incidentaly, this change also fixes #4135, since I had to
split the tests for FractionInputInteraction

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
- For PRs introducing new UI elements or color changes, both light and
dark mode screenshots must be included
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing

---------

Co-authored-by: Adhiambo Peres <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

5 participants