From 1eebfb53a60ff87670b6cce5429a9895fbe67aac Mon Sep 17 00:00:00 2001 From: "Kevin .M. Gitonga" Date: Fri, 16 Sep 2022 11:36:10 +0300 Subject: [PATCH] Fix #3822: Remove maxLines contsraint's to enable long text to linebreak (#4547) * Reduce MarginStart and MarginEnd. * Update maxLines to automatically to show extra text on new line. * Update maxLines for other portrait layouts. * Make changes as requested on review. * Make more changes as advised by reviewer. --- app/src/main/res/layout-sw600dp-port/onboarding_slide.xml | 1 - app/src/main/res/layout-sw600dp-port/onboarding_slide_final.xml | 1 - app/src/main/res/layout/onboarding_slide.xml | 1 - app/src/main/res/layout/onboarding_slide_final.xml | 1 - 4 files changed, 4 deletions(-) diff --git a/app/src/main/res/layout-sw600dp-port/onboarding_slide.xml b/app/src/main/res/layout-sw600dp-port/onboarding_slide.xml index ef07a22d85b..9caf4f150b9 100644 --- a/app/src/main/res/layout-sw600dp-port/onboarding_slide.xml +++ b/app/src/main/res/layout-sw600dp-port/onboarding_slide.xml @@ -41,7 +41,6 @@ android:layout_marginTop="48dp" android:layout_marginEnd="160dp" android:gravity="center_horizontal" - android:maxLines="1" android:text="@{viewModel.title}" android:textSize="32sp" app:layout_constraintEnd_toEndOf="parent" diff --git a/app/src/main/res/layout-sw600dp-port/onboarding_slide_final.xml b/app/src/main/res/layout-sw600dp-port/onboarding_slide_final.xml index b03db41c349..7e1ed7446d3 100644 --- a/app/src/main/res/layout-sw600dp-port/onboarding_slide_final.xml +++ b/app/src/main/res/layout-sw600dp-port/onboarding_slide_final.xml @@ -43,7 +43,6 @@ android:layout_marginEnd="160dp" android:fontFamily="sans-serif-medium" android:gravity="center_horizontal" - android:maxLines="1" android:text="@string/onboarding_slide_3_title" android:textSize="32sp" app:layout_constraintEnd_toEndOf="parent" diff --git a/app/src/main/res/layout/onboarding_slide.xml b/app/src/main/res/layout/onboarding_slide.xml index e95aeed0d3d..44f5aced520 100644 --- a/app/src/main/res/layout/onboarding_slide.xml +++ b/app/src/main/res/layout/onboarding_slide.xml @@ -43,7 +43,6 @@ android:layout_marginBottom="16dp" android:fontFamily="sans-serif-medium" android:gravity="center_horizontal" - android:maxLines="1" android:text="@{viewModel.title}" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" diff --git a/app/src/main/res/layout/onboarding_slide_final.xml b/app/src/main/res/layout/onboarding_slide_final.xml index a4dc71c819d..bda4a4055cf 100644 --- a/app/src/main/res/layout/onboarding_slide_final.xml +++ b/app/src/main/res/layout/onboarding_slide_final.xml @@ -45,7 +45,6 @@ android:layout_marginBottom="16dp" android:fontFamily="sans-serif-medium" android:gravity="center_horizontal" - android:maxLines="1" android:text="@string/onboarding_slide_3_title" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent"