Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input Keyboard Issues #2133

Open
mschanteltc opened this issue Nov 20, 2020 · 14 comments
Open

Input Keyboard Issues #2133

mschanteltc opened this issue Nov 20, 2020 · 14 comments
Assignees
@theayushyadav11
Labels
bug End user-perceivable behaviors which are not desirable. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
1.x GA Follow-up ...

Comments

@mschanteltc
Copy link

mschanteltc commented Nov 20, 2020 •
edited by rt4914
Loading

  • When the input is selected, scrolling up when the input bar is no longer visible deselects it. Tapping on the keyboard does not enter numbers anywhere but selected numbers on the keypad become bolder. (Image below)[Video]
  • When input is entered, and the screen is rotated, the entered input is deleted. [Video]
  • When creating a 3-Digit Input, tapping "Next" after entering the first PIN does not change the input to the second PIN input. Instead, it changes to an "Enter" button that does nothing. [Video]

Screenshot_20201120-005025_Oppia

Device: Might be Samsung device
@krishnakeshan
Copy link

Could you specify the steps to navigate to the screen you mentioned in the issue?

@rt4914
Copy link
Contributor

rt4914 commented Nov 30, 2020

Could you specify the steps to navigate to the screen you mentioned in the issue?

@krishnakeshan Welcome to oppia.
Actually this is something that you won't be able to check on current code. Therefore I am assigning this to myself.

Also, before we start please checkout our wiki first. This will help you in setting up the project and once you sign the CLA and fill the survey form we can assign you issues to work on.

@rt4914 rt4914 self-assigned this Nov 30, 2020
@krishnakeshan
Copy link

Hi @rt4914 thanks! Oh alright got it, no worries.

I've signed the CLA and filled out the survey, and have a build running on a device. I'm checking out the wiki right now!

@rt4914
Copy link
Contributor

rt4914 commented Nov 30, 2020

Hi @rt4914 thanks! Oh alright got it, no worries.

I've signed the CLA and filled out the survey, and have a build running on a device. I'm checking out the wiki right now!

@krishnakeshan Can you please check if the CLA and the survey was filled successfully because I am not able to find you details in our records.

@krishnakeshan
Copy link

Hi @rt4914 thanks! Oh alright got it, no worries.
I've signed the CLA and filled out the survey, and have a build running on a device. I'm checking out the wiki right now!

@krishnakeshan Can you please check if the CLA and the survey was filled successfully because I am not able to find you details in our records.

Hey @rt4914 sorry my bad on the survey, it turns out I didn't complete it last time. Done now. On the CLA though, I'm getting a "You've already responded" screen on visiting that form, so I'm pretty sure I've filled that out. Let me know!

@rt4914
Copy link
Contributor

rt4914 commented Nov 30, 2020

Hi @rt4914 thanks! Oh alright got it, no worries.
I've signed the CLA and filled out the survey, and have a build running on a device. I'm checking out the wiki right now!

@krishnakeshan Can you please check if the CLA and the survey was filled successfully because I am not able to find you details in our records.

Hey @rt4914 sorry my bad on the survey, it turns out I didn't complete it last time. Done now. On the CLA though, I'm getting a "You've already responded" screen on visiting that form, so I'm pretty sure I've filled that out. Let me know!

Great. @anandwana001 will be reaching out to you within next 24 hours. Thanks.

@anandwana001
Copy link
Contributor

Hi @rt4914 thanks! Oh alright got it, no worries.
I've signed the CLA and filled out the survey, and have a build running on a device. I'm checking out the wiki right now!

@krishnakeshan Can you please check if the CLA and the survey was filled successfully because I am not able to find you details in our records.

Hey @rt4914 sorry my bad on the survey, it turns out I didn't complete it last time. Done now. On the CLA though, I'm getting a "You've already responded" screen on visiting that form, so I'm pretty sure I've filled that out. Let me know!

Great. @anandwana001 will be reaching out to you within next 24 hours. Thanks.

He has filled the CLA earlier, but we were waiting for the contributor survey, which is done now. @krishnakeshan You are good to send Pull Request now.

@anandwana001
Copy link
Contributor

anandwana001 commented Nov 30, 2020 •
edited
Loading

Could you specify the steps to navigate to the screen you mentioned in the issue?

@krishnakeshan Try to run the app and start with any Topic on the Home screen, go to Lessons tab and start playing the story under it. Also, check the video link added in the issue description.

@BenHenning BenHenning mentioned this issue Apr 23, 2021
Merged
@rt4914 rt4914 removed their assignment Jul 5, 2021
@rt4914
Copy link
Contributor

rt4914 commented Jul 5, 2021

Unassigned self as this has been solved temporarily by making all keyboard use text type only. Keeping this open so that we can keep track of it in long-term.

@Broppia Broppia added issue_type_bug Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@BenHenning BenHenning added Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_learner labels Sep 15, 2022
@BenHenning
Copy link
Member

BenHenning commented Sep 20, 2022 •
edited
Loading

Note: whoever works on this should double check that these are still problems that need to be solved.

@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_user_learner labels Mar 29, 2023
@adhiamboperes adhiamboperes added the Work: Low Solution is clear and broken into good-first-issue-sized chunks. label May 17, 2024
@MohitGupta121
Copy link
Member

@adhiamboperes as I try to reproduce this issue and see this issue is already fixed:

1st.issue.mov
3rd.issue.mov

This issue is still exist:
When input is entered, and the screen is rotated, the entered input is deleted.

2nd.issue.mov

@BenHenning BenHenning added this to the 1.0 Global availability milestone Aug 29, 2024
@adhiamboperes
Copy link
Collaborator

@theayushyadav11, could you please test whether this issue can still be reproduced? I suspect it may have been fixed by #5458.

You can actually test both prod(released before this fix) and current develop branch.

@theayushyadav11
Copy link
Collaborator

Hi @adhiamboperes,

Thank you for considering me for this task. I’ve thoroughly tested the issues mentioned in the current develop branch, and here are my observations:

1. Issue: When the input is selected, scrolling up causes the input bar to become deselected, and tapping on the keyboard does not input numbers. However, selected numbers on the keypad appear bold.

  • This issue still persists. Additionally, the keyboard vanishes immediately when the screen is scrolled.
  • Here's the observed behavior:
    Video

2. Issue: Entered input gets deleted when the screen is rotated.

  • This issue does not appear to exist anymore when tested on chapters in the develop branch.
  • However, I noticed the same issue persists when entering the admin PIN.
  • Observations:

3. Issue: When creating a 3-digit input, tapping "Next" after entering the first PIN does not shift the focus to the second PIN input. Instead, it changes to an "Enter" button that does nothing.

  • This issue appears to have been resolved.
  • Observed behavior:
    Video

Please let me know if any additional testing or clarification is required. Looking forward to your feedback.

@adhiamboperes
Copy link
Collaborator

Thanks for this thorough investigation and documentation @theayushyadav11! Could you please submit a fix for part of or all of the issues that still persist? Please let us know if you need support at any point.

@theayushyadav11 theayushyadav11 mentioned this issue Dec 24, 2024
Open
6 tasks
@adhiamboperes adhiamboperes added the good first issue This item is good for new contributors to make their pull request. label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theayushyadav11 theayushyadav11

Labels
bug End user-perceivable behaviors which are not desirable. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Status: Todo
Milestone
1.x GA Follow-up Items
Development

No branches or pull requests
10 participants
@rt4914 @seanlip @BenHenning @mschanteltc @krishnakeshan @anandwana001 @adhiamboperes @MohitGupta121 @Broppia @theayushyadav11