Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade target SDK to 30 #3749

Open
BenHenning opened this issue Sep 1, 2021 · 6 comments
Open

Upgrade target SDK to 30 #3749

BenHenning opened this issue Sep 1, 2021 · 6 comments
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

We are currently targeting SDK 28 but ought to target at least 30 (or 31 depending on when this issue gets resolved).

It's unclear all of the work needed here since the Bazel build environment is very specifically configured for 28 currently.
@BenHenning
Copy link
Member Author

Possible blocker: #1542.

@rt4914 rt4914 mentioned this issue Mar 7, 2022
Closed
6 tasks
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 7, 2022
@BenHenning BenHenning added Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. labels Sep 16, 2022
@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_type_infrastructure labels Mar 28, 2023
@MohitGupta121 MohitGupta121 added the Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. label Jun 16, 2023
@BenHenning
Copy link
Member Author

We're targeting SDK 33 now, so this is technically completed:

oppia-android/build_flavors.bzl

Line 121 in 0ef7a46

"target_sdk_version": 33,

@github-actions github-actions bot reopened this Aug 29, 2024
@github-actions GitHub Actions
Copy link

The issue is reopened because of the following unresolved TODOs:

oppia-android/config/proguard/androidx-proguard-rules.pro

Line 2 in 0ef7a46

# TODO(#3749): Simplify this once the target SDK is updated.

oppia-android/config/proguard/glide-proguard-rules.pro

Line 3 in 0ef7a46

# TODO(#3749): Simplify this once the target SDK is updated.

oppia-android/config/proguard/material-proguard-rules.pro

Line 2 in 0ef7a46

# TODO(#3749): Simplify this once the target SDK is updated.

@BenHenning
Copy link
Member Author

Looks like there are some Proguard file cleanups needed before this issue can be closed.

@TanishMoral11
Copy link
Collaborator

Hey @BenHenning @adhiamboperes , Could you Please Clarify The changes That Need To Be Made?
Thank you!

@adhiamboperes
Copy link
Collaborator

@TanishMoral11, please refer to the TODOs listed in the above comments. Some refactor is needed in the respective files now that target SDK has been updated. Seems that some of the original code was written to support older sdk versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
6 participants
@seanlip @BenHenning @adhiamboperes @MohitGupta121 @Broppia @TanishMoral11