Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11YS] Increase color contrast ratio between foreground and background in thumbnail image #4614

Closed
vrajdesai78 opened this issue Sep 22, 2022 · 13 comments · Fixed by #5392
Closed

[A11YS] Increase color contrast ratio between foreground and background in thumbnail image #4614

vrajdesai78 opened this issue Sep 22, 2022 · 13 comments · Fixed by #5392
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.

Comments

@vrajdesai78
Copy link
Contributor

vrajdesai78 commented Sep 22, 2022 •
edited by rt4914
Loading

Describe the bug
In accessibility scanner, it is suggesting to improve color contrast ratio between foreground and background in thumbnail image

Expected behavior
Accessibility scanner should not show any improvements.

Demonstration

Environment

  • Device used: Realme GT Master Edition
  • Android or SDK version (e.g. Android 5 or SDK 21): Android 12
  • App version: 1.0.0
@pratyaksh1610 pratyaksh1610 mentioned this issue Sep 24, 2022
Closed
6 tasks
@BenHenning
Copy link
Member

Hmm. Why is this even being triggered? It seems to be inconsistent in which thumbnails are actually triggering the scanner. Is this a case where the scanner is reading a foreground or background color that's not actually being used?

@BenHenning
Copy link
Member

Also @pratyaksh1610 is working on this.

@vrajdesai78
Copy link
Contributor Author

vrajdesai78 commented Oct 4, 2022 •
edited
Loading

Hmm. Why is this even being triggered? It seems to be inconsistent in which thumbnails are actually triggering the scanner. Is this a case where the scanner is reading a foreground or background color that's not actually being used?

@BenHenning even I don't know why scanner is triggering this may be because we have created our own thumbnail with xml instead of getting it as a image from backend.

@BenHenning
Copy link
Member

Hmm. Why is this even being triggered? It seems to be inconsistent in which thumbnails are actually triggering the scanner. Is this a case where the scanner is reading a foreground or background color that's not actually being used?

@BenHenning even I don't know why scanner is triggering this may be because we have created our own thumbnail with xml instead of getting it as a image from backend.

@vrajdesai78 that describes the environment, but not why that environment causes the issue. I think whoever works on this will need to figure out why it's happening before we can introduce a sensible fix.

@adhiamboperes
Copy link
Collaborator

@aayushimathur6, could you please perform a check and confirm whether this issue is still present?

@adhiamboperes adhiamboperes added good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). bug End user-perceivable behaviors which are not desirable. Work: Low Solution is clear and broken into good-first-issue-sized chunks. labels Sep 25, 2023
@aayushimathur6
Copy link
Collaborator

@aayushimathur6, could you please perform a check and confirm whether this issue is still present?

@adhiamboperes sure, I'll let you know by tomorrow

@aayushimathur6
Copy link
Collaborator

@aayushimathur6, could you please perform a check and confirm whether this issue is still present?

It is still showing the suggestions, I performed you can have a look

a11y

@aayushimathur6
Copy link
Collaborator

A more detailed view of the suggestions

a111y

@aayushimathur6
Copy link
Collaborator

@adhiamboperes PTAL

@adhiamboperes
Copy link
Collaborator

Thanks for verifying this @aayushimathur6!

@adhiamboperes adhiamboperes removed the good first issue This item is good for new contributors to make their pull request. label Sep 30, 2023
@suyashshenoi
Copy link
Contributor

Hey, pls assign this issue to me. I have already changed to code to make the necessary fix. Will create the PR as soon as I'm assigned.

@adhiamboperes
Copy link
Collaborator

Hey, pls assign this issue to me. I have already changed to code to make the necessary fix. Will create the PR as soon as I'm assigned.

Please create the PR and link it to the issue. Thanks.

@suyashshenoi suyashshenoi mentioned this issue Apr 29, 2024
Merged
6 tasks
@suyashshenoi
Copy link
Contributor

@adhiamboperes created the PR and have linked it to this issue. Pls, go through it. Thanks.

BenHenning pushed a commit that referenced this issue May 7, 2024
@suyashshenoi
Fixes #4614: Changed the background color according to accessibility …
60ed74c 
…scanner. (#5392)

Fixed: Topic Images to match A11YS

<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

![WhatsApp Image 2024-04-29 at 01 53
15_47490bfd](https://github.com/oppia/oppia-android/assets/109421165/23c23922-2727-40dc-98c1-128244751c1b)

![WhatsApp Image 2024-05-01 at 00 30
21_96db2eb5](https://github.com/oppia/oppia-android/assets/109421165/80fed08a-8a6c-449c-969e-335f05cea496)

The topic and recently played images no longer have an issue with the
Accessibility Checker.

This is a fix. Resolves
#4614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
6 participants
@seanlip @BenHenning @vrajdesai78 @adhiamboperes @aayushimathur6 @suyashshenoi