-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Voiceovers are playing for the wrong card #5253
Comments
@Tegaphoenix, Is there something specific with the production source code? I've observed that the develop branch doesn't exhibit the issue, and I've also tested the latest beta release (Oppia-android V0.11), where audio playback works correctly. However, the production app downloaded from the Google Play Store does reproduce this issue. Would it be possible for me to explore the production code base to gain a better understanding of the matter? Thanks! |
@Rd4dev is right: the dev resources work fine. The problem is with the prod version of the "What is a Fraction?" lesson. Oppia-web is also failing with the same behavior with the same lesson. Portuguese is the only language that works fine in both android and web. |
Hi folks, sorry, this was an error on Web. The wrong English audio was uploaded for the card. I have just fixed this on the website. Could you please check that it works now? (I believe Android just grabs the voiceovers from Web on-the-fly so I think it should work, but worth double-checking.) Also @masclot you mentioned that only Portuguese works; did you check the other languages? I've only fixed English so far but I haven't modified any of the others. Thanks! |
It still fails on oppia-android, were only Portuguese works; Portuguese
becomes the only selectable language. On web, it works for English,
Portuguese and Hinglish, but fails for the rest. Also on Web, the next step
started to fail for English.
…On Fri, Mar 1, 2024, 18:24 Sean Lip ***@***.***> wrote:
Hi folks, sorry, this was an error on Web. The wrong English audio was
uploaded for the card.
I have just fixed this on the website. Could you please check that it
works now? (I believe Android just grabs the voiceovers from Web on-the-fly
so I think it should work, but worth double-checking.)
Also @masclot <https://github.com/masclot> you mentioned that only
Portuguese works; did you check the other languages? I've only fixed
English so far but I haven't modified any of the others.
Thanks!
—
Reply to this email directly, view it on GitHub
<#5253 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYSJUSN2542C2WNUFLXGE6LYWC2TBAVCNFSM6AAAAABAEBC6Q6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZTGU4DONRYG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks @masclot. It sounds like everything is correct here except that English fails on Android. I just realized that, although voiceovers are loaded on the fly, the references are probably hardcoded in the content for that version of the app, so that's why it's still playing the wrong thing. And yeah, the next step failing on Web is expected, because now that voiceover slot is empty unfortunately. Overall I think this issue can now be considered fixed, though, since it was a Web content issue and the Web behaviour has been verified (which means the Android behaviour should be fixed in the next release). Thanks a lot for helping debug this @masclot (and also @Rd4dev)! |
Describe the bug
When user wants to use the voiceover option screen seven of the fraction lessions on the Oppia Android App, it says Ënglish audio not available¨. When user proceeeds to screen 8, the voiceover plays the lessons meant for screen 7 instead.
URL of the page where the issue is observed.
No response
Steps To Reproduce
Expected Behavior
On screen 7, after clicking the audio icon, I expect to hear the recording for screen seven to play.
screen-20231028-095519.1.mp4
Screenshots/Videos
No response
What device are you using?
Mobile
Operating System
Android
What browsers are you seeing the problem on?
Other
Browser version
No response
Additional context
No response
Tips for developers
Before tackling the bug, please use
git bisect
(see https://git-scm.com/docs/git-bisect) to investigate which PR caused it (you only need to go back as far as commit https://github.com/oppia/oppia/commits/9a334e9). If you find the PR, leave a comment on this issue pointing to it, or just say that it happened before commit 9a334e9 if you could reproduce it there. This will help us fix the issue by reverting the faulty PR.Also, if this is your first issue, please make sure to follow https://github.com/oppia/oppia/wiki/Contributing-code-to-Oppia#choosing-a-good-first-issue and https://github.com/oppia/oppia/wiki/Contributing-code-to-Oppia#setting-things-up before claiming it. Thanks!
The text was updated successfully, but these errors were encountered: