Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Voiceovers are playing for the wrong card #5253

Closed
Tegaphoenix opened this issue Oct 28, 2023 · 5 comments
Closed

[BUG]: Voiceovers are playing for the wrong card #5253

Tegaphoenix opened this issue Oct 28, 2023 · 5 comments
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.

Comments

@Tegaphoenix
Copy link

Describe the bug

When user wants to use the voiceover option screen seven of the fraction lessions on the Oppia Android App, it says Ënglish audio not available¨. When user proceeeds to screen 8, the voiceover plays the lessons meant for screen 7 instead.
Screen 7
Screen 8

URL of the page where the issue is observed.

No response

Steps To Reproduce

  1. Open Oppia app on Android.
  2. Go to Fraction Lessons
  3. Click on chapter 1
  4. Proceed to screen 7 of chapter one.
  5. Click voiceover icon
  6. Proceed to screen 8 of chapter one.
  7. Click voiceover icon.
  8. Pay attention to voice lesson on screen 8.

Expected Behavior

On screen 7, after clicking the audio icon, I expect to hear the recording for screen seven to play.

screen-20231028-095519.1.mp4

Screenshots/Videos

No response

What device are you using?

Mobile

Operating System

Android

What browsers are you seeing the problem on?

Other

Browser version

No response

Additional context

No response

Tips for developers

Before tackling the bug, please use git bisect (see https://git-scm.com/docs/git-bisect) to investigate which PR caused it (you only need to go back as far as commit https://github.com/oppia/oppia/commits/9a334e9). If you find the PR, leave a comment on this issue pointing to it, or just say that it happened before commit 9a334e9 if you could reproduce it there. This will help us fix the issue by reverting the faulty PR.

Also, if this is your first issue, please make sure to follow https://github.com/oppia/oppia/wiki/Contributing-code-to-Oppia#choosing-a-good-first-issue and https://github.com/oppia/oppia/wiki/Contributing-code-to-Oppia#setting-things-up before claiming it. Thanks!

@Tegaphoenix Tegaphoenix added bug End user-perceivable behaviors which are not desirable. triage needed labels Oct 28, 2023
@seanlip seanlip changed the title [BUG]: [BUG]: Voiceovers are playing for the wrong lesson Oct 30, 2023
@seanlip seanlip changed the title [BUG]: Voiceovers are playing for the wrong lesson [BUG]: Voiceovers are playing for the wrong card Oct 30, 2023
@prafulbbandre prafulbbandre added Impact: High High perceived user impact (breaks a critical feature or blocks a release). Work: High It's not clear what the solution is. labels Nov 2, 2023
@seanlip seanlip transferred this issue from oppia/oppia Dec 2, 2023
@seanlip seanlip removed Impact: High High perceived user impact (breaks a critical feature or blocks a release). Work: High It's not clear what the solution is. labels Dec 2, 2023
@adhiamboperes adhiamboperes added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks. labels Dec 4, 2023
@adhiamboperes adhiamboperes self-assigned this Dec 4, 2023
@deonwaju deonwaju assigned deonwaju and unassigned deonwaju Jan 19, 2024
@adhiamboperes adhiamboperes removed their assignment Feb 12, 2024
@Rd4dev
Copy link
Collaborator

Rd4dev commented Feb 24, 2024

@Tegaphoenix, Is there something specific with the production source code? I've observed that the develop branch doesn't exhibit the issue, and I've also tested the latest beta release (Oppia-android V0.11), where audio playback works correctly.

However, the production app downloaded from the Google Play Store does reproduce this issue. Would it be possible for me to explore the production code base to gain a better understanding of the matter? Thanks!

@masclot
Copy link
Collaborator

masclot commented Feb 26, 2024

@Rd4dev is right: the dev resources work fine. The problem is with the prod version of the "What is a Fraction?" lesson. Oppia-web is also failing with the same behavior with the same lesson. Portuguese is the only language that works fine in both android and web.

@adhiamboperes adhiamboperes added Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. and removed Work: Low Solution is clear and broken into good-first-issue-sized chunks. labels Mar 1, 2024
@seanlip
Copy link
Member

seanlip commented Mar 1, 2024

Hi folks, sorry, this was an error on Web. The wrong English audio was uploaded for the card.

I have just fixed this on the website. Could you please check that it works now? (I believe Android just grabs the voiceovers from Web on-the-fly so I think it should work, but worth double-checking.)

Also @masclot you mentioned that only Portuguese works; did you check the other languages? I've only fixed English so far but I haven't modified any of the others.

Thanks!

@masclot
Copy link
Collaborator

masclot commented Mar 1, 2024 via email

@seanlip
Copy link
Member

seanlip commented Mar 1, 2024

Thanks @masclot. It sounds like everything is correct here except that English fails on Android. I just realized that, although voiceovers are loaded on the fly, the references are probably hardcoded in the content for that version of the app, so that's why it's still playing the wrong thing.

And yeah, the next step failing on Web is expected, because now that voiceover slot is empty unfortunately.

Overall I think this issue can now be considered fixed, though, since it was a Web content issue and the Web behaviour has been verified (which means the Android behaviour should be fixed in the next release). Thanks a lot for helping debug this @masclot (and also @Rd4dev)!

@seanlip seanlip closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.
Development

No branches or pull requests

7 participants