Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Remove Kotlin Android extensions #5428

Closed
BenHenning opened this issue Jun 18, 2024 · 1 comment · Fixed by #5429
Closed

[Feature Request]: Remove Kotlin Android extensions #5428

BenHenning opened this issue Jun 18, 2024 · 1 comment · Fixed by #5429
Assignees
Labels
enhancement End user-perceivable enhancements. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks.

Comments

@BenHenning
Copy link
Member

BenHenning commented Jun 18, 2024

Is your feature request related to a problem? Please describe.

We use some synthetics generated by the Kotlin Android extensions plugin. Per https://developer.android.com/topic/libraries/view-binding/migration it's deprecated.

Describe the solution you'd like

https://developer.android.com/topic/libraries/view-binding/migration has alternative migration pathways, where appropriate. In most cases, we just need to use the direct view based on ID or via the local binding rather than synthetics.

Describe alternatives you've considered

None since this is a deprecation.

Additional context

This might be causing some incremental build incompatibilities between the old version of Gradle we're using and Jetpack Compose (being introduced as part of #5344).

@BenHenning BenHenning added enhancement End user-perceivable enhancements. triage needed labels Jun 18, 2024
@BenHenning BenHenning self-assigned this Jun 18, 2024
@BenHenning
Copy link
Member Author

FWIW I think we removed all synthetic imports back when Bazel was initially introduced, so we may not actually have any code changes needed here beyond removing the plugin.

@adhiamboperes adhiamboperes added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks. and removed triage needed labels Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement End user-perceivable enhancements. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
Development

Successfully merging a pull request may close this issue.

2 participants