-
Notifications
You must be signed in to change notification settings - Fork 580
Open
Labels
Impact: MediumModerate perceived user impact (non-blocking bugs and general improvements).Moderate perceived user impact (non-blocking bugs and general improvements).Work: LowSolution is clear and broken into good-first-issue-sized chunks.Solution is clear and broken into good-first-issue-sized chunks.bugEnd user-perceivable behaviors which are not desirable.End user-perceivable behaviors which are not desirable.
Description
Describe the bug
The Prototype Exploration -> Fraction Lesson
Qn: "What fraction represents half of something?" accepts incorrect answers.
This is caused by the test asset: test_exp_id_2.json
"rule_specs": [
{
"rule_type": "IsExactlyEqualTo",
"inputs": {
"f": { "isNegative": false, "wholeNumber": 0, "numerator": 1, "denominator": 2 }
}
},
{
"rule_type": "HasIntegerPartEqualTo",
"inputs": { "x": 1 }
}
]- The first rule expects exactly 1/2.
- The second rule accepts any fraction with integer part = 1, including 1, 1 1/2, 1 3/4, 1 5/6, 1 99/100.
- This leads to incorrect answers being marked as correct, e.g., 1 and 1 5/6.
The second rule incorrectly allows fractions or integers that are not actually “half”, causing misalignment between the intended answer and the current rules.
Steps To Reproduce
- Run the
oppia_devbuild of the app. - Open Prototype Explorations.
- Open Fractions Lesson.
- Navigate to the Question: “What fraction represents half of something?”
- Enter the following inputs:
1→ accepted (incorrect)1 5/6→accepted (incorrect)1/2→ accepted (correct)0 1/2→ accepted (correct)
Expected Behavior
- To Only accept exactly
1/2 - Seek clarification from the team (if optionally equivalent fractions like
2/4,50/100should be considered).
Proposed Solution
Note from team: The developer version should mirror the production app as closely as possible.
And to revert the PR changes.
- Remove
HasIntegerPartEqualTofrom this answer group:- In the JSON.
- In the
textprotos
- Add proper verifications to validate the expected behavior and prevent regressions in future.
Screenshots/Videos
Ans: 1 |
Ans: 1 5/6 |
Ans: 1/2 |
Ans: 0 1/2 |
|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
What device/emulator are you using?
Nexus 5X
Which Android version is your device/emulator running?
API 27
Which version of the Oppia Android app are you using?
Additional Context
No response
Metadata
Metadata
Assignees
Labels
Impact: MediumModerate perceived user impact (non-blocking bugs and general improvements).Moderate perceived user impact (non-blocking bugs and general improvements).Work: LowSolution is clear and broken into good-first-issue-sized chunks.Solution is clear and broken into good-first-issue-sized chunks.bugEnd user-perceivable behaviors which are not desirable.End user-perceivable behaviors which are not desirable.
Type
Projects
Status
Todo



