Add a few tests and enfore np.float64 if no dtype is given

Author: timmens

src/optimagic/visualization/plotting_utilities.py

@@ -355,7 +355,7 @@ def _ensure_array_from_plotly_data(data: Any) -> np.ndarray:
         return _decode_base64_data(data["bdata"], dtype=data["dtype"])
     elif isinstance(data, collections.abc.Sequence):
         try:
-            return np.array(data)
+            return np.array(data, dtype=np.float64)
         except Exception:
             pass
     raise ValueError("Failed to convert input to numpy array.")

tests/optimagic/visualization/test_plotting_utilities.py

@@ -0,0 +1,50 @@
+import base64
+
+import numpy as np
+import pytest
+from numpy.testing import assert_array_equal
+
+from optimagic.visualization.plotting_utilities import (
+    _decode_base64_data,
+    _ensure_array_from_plotly_data,
+)
+
+
+def test_decode_base64_data():
+    expected = np.arange(10, dtype=float)
+    encoded = base64.b64encode(expected.tobytes()).decode("ascii")
+    got = _decode_base64_data(encoded, dtype="float")
+    assert_array_equal(expected, got)
+
+
+def test_ensure_array_from_plotly_data_case_array():
+    expected = np.arange(10, dtype=float)
+    got = _ensure_array_from_plotly_data(expected)
+    assert_array_equal(expected, got)
+
+
+def test_ensure_array_from_plotly_data_case_list():
+    expected = np.arange(10, dtype=float)
+    got = _ensure_array_from_plotly_data(expected.tolist())
+    assert_array_equal(expected, got)
+
+
+def test_ensure_array_from_plotly_data_case_base64():
+    expected = np.arange(10, dtype=float)
+    encoded = base64.b64encode(expected.tobytes()).decode("ascii")
+    got = _ensure_array_from_plotly_data({"bdata": encoded, "dtype": "float"})
+    assert_array_equal(expected, got)
+
+
+@pytest.mark.parametrize(
+    "invalid_input",
+    [
+        None,
+        "not a valid input",
+        1234,
+        [{"a": 1}, {"b": 2}],
+    ],
+)
+def test_ensure_array_from_plotly_data_case_invalid(invalid_input):
+    with pytest.raises(ValueError, match="Failed to convert input to numpy array."):
+        _ensure_array_from_plotly_data(invalid_input)