Rename argument to signal that None propagation only happens in fast path

Author: timmens

src/optimagic/differentiation/derivatives.py

@@ -249,7 +249,7 @@ def first_derivative(
     # We cannot propagate None-valued bounds until the derivative code is updated to
     # handle None bounds.
     internal_lb, internal_ub = get_internal_bounds(
-        params, bounds=bounds, propagate_none=False
+        params, bounds=bounds, propagate_none_in_fast_path=False
     )
 
     # handle kwargs
@@ -567,7 +567,7 @@ def second_derivative(
     # We cannot propagate None-valued bounds until the derivative code is updated to
     # handle None bounds.
     internal_lb, internal_ub = get_internal_bounds(
-        params, bounds=bounds, propagate_none=False
+        params, bounds=bounds, propagate_none_in_fast_path=False
     )
 
     # handle kwargs

src/optimagic/parameters/bounds.py

@@ -76,7 +76,7 @@ def get_internal_bounds(
     bounds: Bounds | None = None,
     registry: PyTreeRegistry | None = None,
     add_soft_bounds: bool = False,
-    propagate_none: bool = True,
+    propagate_none_in_fast_path: bool = True,
 ) -> tuple[NDArray[np.float64] | None, NDArray[np.float64] | None]:
     """Create consolidated and flattened bounds for params.
 
@@ -97,9 +97,9 @@ def get_internal_bounds(
         add_soft_bounds: If True, the element-wise maximum (minimum) of the lower and
             soft_lower (upper and soft_upper) bounds are taken. If False, the lower
             (upper) bounds are returned.
-        propagate_none: If True, None-valued lower and upper bounds are propagated to
-            the output. If False, None values are replaced with -np.inf for the lower
-            bound and np.inf for the upper bound.
+        propagate_none_in_fast_path: If True, None-valued lower and upper bounds are
+            propagated to the output in the fast path case. If False, None values are
+            replaced with -np.inf for the lower bound and np.inf for the upper bound.
 
     Returns:
         Consolidated and flattened lower_bounds.
@@ -117,7 +117,7 @@ def get_internal_bounds(
         return _get_fast_path_bounds(
             params=params,
             bounds=bounds,
-            propagate_none=propagate_none,
+            propagate_none=propagate_none_in_fast_path,
         )
 
     # In the slow path, None bounds are currently not propagated, but replaced with

src/optimagic/parameters/tree_conversion.py

@@ -54,7 +54,7 @@ def get_tree_converter(
         params=params,
         bounds=bounds,
         registry=_registry,
-        propagate_none=False,
+        propagate_none_in_fast_path=False,
     )
 
     if add_soft_bounds:
@@ -63,7 +63,7 @@ def get_tree_converter(
             bounds=bounds,
             registry=_registry,
             add_soft_bounds=add_soft_bounds,
-            propagate_none=True,
+            propagate_none_in_fast_path=False,
         )
     else:
         _soft_lower, _soft_upper = None, None

tests/optimagic/parameters/test_bounds.py

@@ -121,14 +121,18 @@ def test_get_bounds_with_upper_bounds(pytree_params):
 
 
 def test_get_bounds_numpy_propagate_none_true(array_params):
-    got_lower, got_upper = get_internal_bounds(array_params, propagate_none=True)
+    got_lower, got_upper = get_internal_bounds(
+        array_params, propagate_none_in_fast_path=True
+    )
 
     assert got_lower is None
     assert got_upper is None
 
 
 def test_get_bounds_numpy_propagate_none_false(array_params):
-    got_lower, got_upper = get_internal_bounds(array_params, propagate_none=False)
+    got_lower, got_upper = get_internal_bounds(
+        array_params, propagate_none_in_fast_path=False
+    )
 
     expected = np.array([np.inf, np.inf])