Skip to content

Commit 606e023

Browse files
fix(ci): semgrep cli breaking change (ethereum-optimism#11985)
Semgrep CLI tool recently removed the --time option which caused CI to suddenly break.
1 parent c18ec26 commit 606e023

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

.circleci/config.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -1397,11 +1397,10 @@ jobs:
13971397
echo 'export SEMGREP_REPO_NAME=$CIRCLE_PROJECT_USERNAME/$CIRCLE_PROJECT_REPONAME' >> $BASH_ENV
13981398
- run:
13991399
name: "Semgrep scan"
1400-
# --time shows which rules take the most time
14011400
# --timeout (in seconds) limits the time per rule and file.
14021401
# SEMGREP_TIMEOUT is the same, but docs have conflicting defaults (5s in CLI flag, 1800 in some places)
14031402
# https://semgrep.dev/docs/troubleshooting/semgrep-app#if-the-job-is-aborted-due-to-taking-too-long
1404-
command: semgrep ci --time --timeout=100
1403+
command: semgrep ci --timeout=100
14051404
# If semgrep hangs, stop the scan after 20m, to prevent a useless 5h job
14061405
no_output_timeout: 20m
14071406
- notify-failures-on-develop

0 commit comments

Comments
 (0)