-
Notifications
You must be signed in to change notification settings - Fork 36
/
Copy pathtest_decision_service.py
1741 lines (1581 loc) · 78.8 KB
/
test_decision_service.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
# Copyright 2017-2021, Optimizely
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import json
import mock
from optimizely import decision_service
from optimizely import entities
from optimizely import optimizely
from optimizely import optimizely_user_context
from optimizely import user_profile
from optimizely.helpers import enums
from . import base
class DecisionServiceTest(base.BaseTest):
def setUp(self):
base.BaseTest.setUp(self)
self.decision_service = self.optimizely.decision_service
# Set UserProfileService for the purposes of testing
self.decision_service.user_profile_service = user_profile.UserProfileService()
def test_get_bucketing_id__no_bucketing_id_attribute(self):
""" Test that _get_bucketing_id returns correct bucketing ID when there is no bucketing ID attribute. """
# No attributes
bucketing_id, _ = self.decision_service._get_bucketing_id("test_user", None)
self.assertEqual(
"test_user",
bucketing_id
)
# With attributes, but no bucketing ID
bucketing_id, _ = self.decision_service._get_bucketing_id(
"test_user", {"random_key": "random_value"}
)
self.assertEqual(
"test_user",
bucketing_id,
)
def test_get_bucketing_id__bucketing_id_attribute(self):
""" Test that _get_bucketing_id returns correct bucketing ID when there is bucketing ID attribute. """
with mock.patch.object(
self.decision_service, "logger"
) as mock_decision_service_logging:
bucketing_id, _ = self.decision_service._get_bucketing_id(
"test_user", {"$opt_bucketing_id": "user_bucket_value"}
)
self.assertEqual(
"user_bucket_value",
bucketing_id,
)
mock_decision_service_logging.debug.assert_not_called()
def test_get_bucketing_id__bucketing_id_attribute_not_a_string(self):
""" Test that _get_bucketing_id returns user ID as bucketing ID when bucketing ID attribute is not a string"""
with mock.patch.object(
self.decision_service, "logger"
) as mock_decision_service_logging:
bucketing_id, _ = self.decision_service._get_bucketing_id(
"test_user", {"$opt_bucketing_id": True}
)
self.assertEqual(
"test_user",
bucketing_id,
)
mock_decision_service_logging.warning.assert_called_once_with(
"Bucketing ID attribute is not a string. Defaulted to user_id."
)
mock_decision_service_logging.reset_mock()
bucketing_id, _ = self.decision_service._get_bucketing_id(
"test_user", {"$opt_bucketing_id": 5.9}
)
self.assertEqual(
"test_user",
bucketing_id,
)
mock_decision_service_logging.warning.assert_called_once_with(
"Bucketing ID attribute is not a string. Defaulted to user_id."
)
mock_decision_service_logging.reset_mock()
bucketing_id, _ = self.decision_service._get_bucketing_id(
"test_user", {"$opt_bucketing_id": 5}
)
self.assertEqual(
"test_user",
bucketing_id,
)
mock_decision_service_logging.warning.assert_called_once_with(
"Bucketing ID attribute is not a string. Defaulted to user_id."
)
def test_set_forced_variation__invalid_experiment_key(self):
""" Test invalid experiment keys set fail to set a forced variation """
self.assertFalse(
self.decision_service.set_forced_variation(
self.project_config,
"test_experiment_not_in_datafile",
"test_user",
"variation",
)
)
self.assertFalse(
self.decision_service.set_forced_variation(
self.project_config, "", "test_user", "variation"
)
)
self.assertFalse(
self.decision_service.set_forced_variation(
self.project_config, None, "test_user", "variation"
)
)
def test_set_forced_variation__invalid_variation_key(self):
""" Test invalid variation keys set fail to set a forced variation """
self.assertFalse(
self.decision_service.set_forced_variation(
self.project_config,
"test_experiment",
"test_user",
"variation_not_in_datafile",
)
)
self.assertTrue(
self.decision_service.set_forced_variation(
self.project_config, "test_experiment", "test_user", None
)
)
with mock.patch.object(
self.decision_service, "logger"
) as mock_decision_service_logging:
self.assertIs(
self.decision_service.set_forced_variation(
self.project_config, "test_experiment", "test_user", ""
),
False,
)
mock_decision_service_logging.debug.assert_called_once_with(
"Variation key is invalid."
)
def test_set_forced_variation__multiple_sets(self):
""" Test multiple sets of experiments for one and multiple users work """
self.assertTrue(
self.decision_service.set_forced_variation(
self.project_config, "test_experiment", "test_user_1", "variation"
)
)
variation, _ = self.decision_service.get_forced_variation(
self.project_config, "test_experiment", "test_user_1"
)
self.assertEqual(
variation.key,
"variation",
)
# same user, same experiment, different variation
self.assertTrue(
self.decision_service.set_forced_variation(
self.project_config, "test_experiment", "test_user_1", "control"
)
)
variation, _ = self.decision_service.get_forced_variation(
self.project_config, "test_experiment", "test_user_1"
)
self.assertEqual(
variation.key,
"control",
)
# same user, different experiment
self.assertTrue(
self.decision_service.set_forced_variation(
self.project_config, "group_exp_1", "test_user_1", "group_exp_1_control"
)
)
variation, _ = self.decision_service.get_forced_variation(
self.project_config, "group_exp_1", "test_user_1"
)
self.assertEqual(
variation.key,
"group_exp_1_control",
)
# different user
self.assertTrue(
self.decision_service.set_forced_variation(
self.project_config, "test_experiment", "test_user_2", "variation"
)
)
variation, _ = self.decision_service.get_forced_variation(
self.project_config, "test_experiment", "test_user_2"
)
self.assertEqual(
variation.key,
"variation",
)
# different user, different experiment
self.assertTrue(
self.decision_service.set_forced_variation(
self.project_config, "group_exp_1", "test_user_2", "group_exp_1_control"
)
)
variation, _ = self.decision_service.get_forced_variation(
self.project_config, "group_exp_1", "test_user_2"
)
self.assertEqual(
variation.key,
"group_exp_1_control",
)
# make sure the first user forced variations are still valid
variation, _ = self.decision_service.get_forced_variation(
self.project_config, "test_experiment", "test_user_1"
)
self.assertEqual(
variation.key,
"control",
)
variation, _ = self.decision_service.get_forced_variation(
self.project_config, "group_exp_1", "test_user_1"
)
self.assertEqual(
variation.key,
"group_exp_1_control",
)
def test_set_forced_variation_when_called_to_remove_forced_variation(self):
""" Test set_forced_variation when no variation is given. """
# Test case where both user and experiment are present in the forced variation map
self.project_config.forced_variation_map = {}
self.decision_service.set_forced_variation(
self.project_config, "test_experiment", "test_user", "variation"
)
with mock.patch.object(
self.decision_service, "logger"
) as mock_decision_service_logging:
self.assertTrue(
self.decision_service.set_forced_variation(
self.project_config, "test_experiment", "test_user", None
)
)
mock_decision_service_logging.debug.assert_called_once_with(
'Variation mapped to experiment "test_experiment" has been removed for user "test_user".'
)
# Test case where user is present in the forced variation map, but the given experiment isn't
self.project_config.forced_variation_map = {}
self.decision_service.set_forced_variation(
self.project_config, "test_experiment", "test_user", "variation"
)
with mock.patch.object(
self.decision_service, "logger"
) as mock_decision_service_logging:
self.assertTrue(
self.decision_service.set_forced_variation(
self.project_config, "group_exp_1", "test_user", None
)
)
mock_decision_service_logging.debug.assert_called_once_with(
'Nothing to remove. Variation mapped to experiment "group_exp_1" for user "test_user" does not exist.'
)
def test_get_forced_variation__invalid_user_id(self):
""" Test invalid user IDs return a null variation. """
self.decision_service.forced_variation_map["test_user"] = {}
self.decision_service.forced_variation_map["test_user"][
"test_experiment"
] = "test_variation"
variation, _ = self.decision_service.get_forced_variation(
self.project_config, "test_experiment", None
)
self.assertIsNone(
variation
)
variation, _ = self.decision_service.get_forced_variation(
self.project_config, "test_experiment", ""
)
self.assertIsNone(
variation
)
def test_get_forced_variation__invalid_experiment_key(self):
""" Test invalid experiment keys return a null variation. """
self.decision_service.forced_variation_map["test_user"] = {}
self.decision_service.forced_variation_map["test_user"][
"test_experiment"
] = "test_variation"
variation, _ = self.decision_service.get_forced_variation(
self.project_config, "test_experiment_not_in_datafile", "test_user"
)
self.assertIsNone(
variation
)
variation, _ = self.decision_service.get_forced_variation(
self.project_config, None, "test_user"
)
self.assertIsNone(
variation
)
variation, _ = self.decision_service.get_forced_variation(
self.project_config, "", "test_user"
)
self.assertIsNone(
variation
)
def test_get_forced_variation_with_none_set_for_user(self):
""" Test get_forced_variation when none set for user ID in forced variation map. """
self.decision_service.forced_variation_map = {}
self.decision_service.forced_variation_map["test_user"] = {}
with mock.patch.object(
self.decision_service, "logger"
) as mock_decision_service_logging:
variation, _ = self.decision_service.get_forced_variation(
self.project_config, "test_experiment", "test_user"
)
self.assertIsNone(
variation
)
mock_decision_service_logging.debug.assert_called_once_with(
'No experiment "test_experiment" mapped to user "test_user" in the forced variation map.'
)
def test_get_forced_variation_missing_variation_mapped_to_experiment(self):
""" Test get_forced_variation when no variation found against given experiment for the user. """
self.decision_service.forced_variation_map = {}
self.decision_service.forced_variation_map["test_user"] = {}
self.decision_service.forced_variation_map["test_user"][
"test_experiment"
] = None
with mock.patch.object(
self.decision_service, "logger"
) as mock_decision_service_logging:
variation, _ = self.decision_service.get_forced_variation(
self.project_config, "test_experiment", "test_user"
)
self.assertIsNone(
variation
)
mock_decision_service_logging.debug.assert_called_once_with(
'No variation mapped to experiment "test_experiment" in the forced variation map.'
)
def test_get_whitelisted_variation__user_in_forced_variation(self):
""" Test that expected variation is returned if user is forced in a variation. """
experiment = self.project_config.get_experiment_from_key("test_experiment")
with mock.patch.object(
self.decision_service, "logger"
) as mock_decision_service_logging:
variation, _ = self.decision_service.get_whitelisted_variation(
self.project_config, experiment, "user_1"
)
self.assertEqual(
entities.Variation("111128", "control"),
variation,
)
mock_decision_service_logging.info.assert_called_once_with(
'User "user_1" is forced in variation "control".'
)
def test_get_whitelisted_variation__user_in_invalid_variation(self):
""" Test that get_whitelisted_variation returns None when variation user is whitelisted for is invalid. """
experiment = self.project_config.get_experiment_from_key("test_experiment")
with mock.patch(
"optimizely.project_config.ProjectConfig.get_variation_from_key",
return_value=None,
) as mock_get_variation_id:
variation, _ = self.decision_service.get_whitelisted_variation(
self.project_config, experiment, "user_1"
)
self.assertIsNone(
variation
)
mock_get_variation_id.assert_called_once_with("test_experiment", "control")
def test_get_stored_variation__stored_decision_available(self):
""" Test that stored decision is retrieved as expected. """
experiment = self.project_config.get_experiment_from_key("test_experiment")
profile = user_profile.UserProfile(
"test_user", experiment_bucket_map={"111127": {"variation_id": "111128"}}
)
with mock.patch.object(
self.decision_service, "logger"
) as mock_decision_service_logging:
variation = self.decision_service.get_stored_variation(
self.project_config, experiment, profile
)
self.assertEqual(
entities.Variation("111128", "control"),
variation,
)
mock_decision_service_logging.info.assert_called_once_with(
'Found a stored decision. User "test_user" is in variation "control" of experiment "test_experiment".'
)
def test_get_stored_variation__no_stored_decision_available(self):
""" Test that get_stored_variation returns None when no decision is available. """
experiment = self.project_config.get_experiment_from_key("test_experiment")
profile = user_profile.UserProfile("test_user")
variation = self.decision_service.get_stored_variation(
self.project_config, experiment, profile
)
self.assertIsNone(
variation
)
def test_get_variation__experiment_not_running(self):
""" Test that get_variation returns None if experiment is not Running. """
user = optimizely_user_context.OptimizelyUserContext(optimizely_client=None, user_id="test_user",
user_attributes={})
experiment = self.project_config.get_experiment_from_key("test_experiment")
# Mark experiment paused
experiment.status = "Paused"
with mock.patch(
"optimizely.decision_service.DecisionService.get_forced_variation"
) as mock_get_forced_variation, mock.patch.object(
self.decision_service, "logger"
) as mock_decision_service_logging, mock.patch(
"optimizely.decision_service.DecisionService.get_stored_variation"
) as mock_get_stored_variation, mock.patch(
"optimizely.helpers.audience.does_user_meet_audience_conditions"
) as mock_audience_check, mock.patch(
"optimizely.bucketer.Bucketer.bucket"
) as mock_bucket, mock.patch(
"optimizely.user_profile.UserProfileService.lookup"
) as mock_lookup, mock.patch(
"optimizely.user_profile.UserProfileService.save"
) as mock_save:
variation, _ = self.decision_service.get_variation(
self.project_config, experiment, user, None
)
self.assertIsNone(
variation
)
mock_decision_service_logging.info.assert_called_once_with(
'Experiment "test_experiment" is not running.'
)
# Assert no calls are made to other services
self.assertEqual(0, mock_get_forced_variation.call_count)
self.assertEqual(0, mock_get_stored_variation.call_count)
self.assertEqual(0, mock_audience_check.call_count)
self.assertEqual(0, mock_bucket.call_count)
self.assertEqual(0, mock_lookup.call_count)
self.assertEqual(0, mock_save.call_count)
def test_get_variation__bucketing_id_provided(self):
""" Test that get_variation calls bucket with correct bucketing ID if provided. """
user = optimizely_user_context.OptimizelyUserContext(optimizely_client=None,
user_id="test_user",
user_attributes={
"random_key": "random_value",
"$opt_bucketing_id": "user_bucket_value",
})
experiment = self.project_config.get_experiment_from_key("test_experiment")
with mock.patch(
"optimizely.decision_service.DecisionService.get_forced_variation",
return_value=[None, []],
), mock.patch(
"optimizely.decision_service.DecisionService.get_stored_variation",
return_value=None,
), mock.patch(
"optimizely.helpers.audience.does_user_meet_audience_conditions", return_value=[True, []]
), mock.patch(
"optimizely.bucketer.Bucketer.bucket",
return_value=[self.project_config.get_variation_from_id("211127", "211129"), []],
) as mock_bucket:
variation, _ = self.decision_service.get_variation(
self.project_config,
experiment,
user
)
# Assert that bucket is called with appropriate bucketing ID
mock_bucket.assert_called_once_with(
self.project_config, experiment, "test_user", "user_bucket_value"
)
def test_get_variation__user_whitelisted_for_variation(self):
""" Test that get_variation returns whitelisted variation if user is whitelisted. """
user = optimizely_user_context.OptimizelyUserContext(optimizely_client=None, user_id="test_user",
user_attributes={})
experiment = self.project_config.get_experiment_from_key("test_experiment")
with mock.patch(
"optimizely.decision_service.DecisionService.get_whitelisted_variation",
return_value=[entities.Variation("111128", "control"), []],
) as mock_get_whitelisted_variation, mock.patch(
"optimizely.decision_service.DecisionService.get_stored_variation"
) as mock_get_stored_variation, mock.patch(
"optimizely.helpers.audience.does_user_meet_audience_conditions"
) as mock_audience_check, mock.patch(
"optimizely.bucketer.Bucketer.bucket"
) as mock_bucket, mock.patch(
"optimizely.user_profile.UserProfileService.lookup"
) as mock_lookup, mock.patch(
"optimizely.user_profile.UserProfileService.save"
) as mock_save:
variation, _ = self.decision_service.get_variation(
self.project_config, experiment, user
)
self.assertEqual(
entities.Variation("111128", "control"),
variation,
)
# Assert that forced variation is returned and stored decision or bucketing service are not involved
mock_get_whitelisted_variation.assert_called_once_with(
self.project_config, experiment, "test_user"
)
self.assertEqual(0, mock_get_stored_variation.call_count)
self.assertEqual(0, mock_audience_check.call_count)
self.assertEqual(0, mock_bucket.call_count)
self.assertEqual(0, mock_lookup.call_count)
self.assertEqual(0, mock_save.call_count)
def test_get_variation__user_has_stored_decision(self):
""" Test that get_variation returns stored decision if user has variation available for given experiment. """
user = optimizely_user_context.OptimizelyUserContext(optimizely_client=None, user_id="test_user",
user_attributes={})
experiment = self.project_config.get_experiment_from_key("test_experiment")
with mock.patch(
"optimizely.decision_service.DecisionService.get_whitelisted_variation",
return_value=[None, []],
) as mock_get_whitelisted_variation, mock.patch(
"optimizely.decision_service.DecisionService.get_stored_variation",
return_value=entities.Variation("111128", "control"),
) as mock_get_stored_variation, mock.patch(
"optimizely.helpers.audience.does_user_meet_audience_conditions"
) as mock_audience_check, mock.patch(
"optimizely.bucketer.Bucketer.bucket"
) as mock_bucket, mock.patch(
"optimizely.user_profile.UserProfileService.lookup",
return_value={
"user_id": "test_user",
"experiment_bucket_map": {"111127": {"variation_id": "111128"}},
},
) as mock_lookup, mock.patch(
"optimizely.user_profile.UserProfileService.save"
) as mock_save:
variation, _ = self.decision_service.get_variation(
self.project_config, experiment, user, None
)
self.assertEqual(
entities.Variation("111128", "control"),
variation,
)
# Assert that stored variation is returned and bucketing service is not involved
mock_get_whitelisted_variation.assert_called_once_with(
self.project_config, experiment, "test_user"
)
mock_lookup.assert_called_once_with("test_user")
mock_get_stored_variation.assert_called_once_with(
self.project_config,
experiment,
user_profile.UserProfile(
"test_user", {"111127": {"variation_id": "111128"}}
),
)
self.assertEqual(0, mock_audience_check.call_count)
self.assertEqual(0, mock_bucket.call_count)
self.assertEqual(0, mock_save.call_count)
def test_get_variation__user_bucketed_for_new_experiment__user_profile_service_available(
self,
):
""" Test that get_variation buckets and returns variation if no forced variation or decision available.
Also, stores decision if user profile service is available. """
user = optimizely_user_context.OptimizelyUserContext(optimizely_client=None, user_id="test_user",
user_attributes={})
experiment = self.project_config.get_experiment_from_key("test_experiment")
with mock.patch.object(
self.decision_service, "logger"
) as mock_decision_service_logging, mock.patch(
"optimizely.decision_service.DecisionService.get_whitelisted_variation",
return_value=[None, []],
) as mock_get_whitelisted_variation, mock.patch(
"optimizely.decision_service.DecisionService.get_stored_variation",
return_value=None,
) as mock_get_stored_variation, mock.patch(
"optimizely.helpers.audience.does_user_meet_audience_conditions", return_value=[True, []]
) as mock_audience_check, mock.patch(
"optimizely.bucketer.Bucketer.bucket",
return_value=[entities.Variation("111129", "variation"), []],
) as mock_bucket, mock.patch(
"optimizely.user_profile.UserProfileService.lookup",
return_value={"user_id": "test_user", "experiment_bucket_map": {}},
) as mock_lookup, mock.patch(
"optimizely.user_profile.UserProfileService.save"
) as mock_save:
variation, _ = self.decision_service.get_variation(
self.project_config, experiment, user, None
)
self.assertEqual(
entities.Variation("111129", "variation"),
variation,
)
# Assert that user is bucketed and new decision is stored
mock_get_whitelisted_variation.assert_called_once_with(
self.project_config, experiment, user.user_id
)
mock_lookup.assert_called_once_with("test_user")
self.assertEqual(1, mock_get_stored_variation.call_count)
mock_audience_check.assert_called_once_with(
self.project_config,
experiment.get_audience_conditions_or_ids(),
enums.ExperimentAudienceEvaluationLogs,
"test_experiment",
user.get_user_attributes(),
mock_decision_service_logging
)
mock_bucket.assert_called_once_with(
self.project_config, experiment, "test_user", "test_user"
)
mock_save.assert_called_once_with(
{
"user_id": "test_user",
"experiment_bucket_map": {"111127": {"variation_id": "111129"}},
}
)
def test_get_variation__user_bucketed_for_new_experiment__user_profile_service_not_available(
self,
):
""" Test that get_variation buckets and returns variation if
no forced variation and no user profile service available. """
# Unset user profile service
self.decision_service.user_profile_service = None
user = optimizely_user_context.OptimizelyUserContext(optimizely_client=None, user_id="test_user",
user_attributes={})
experiment = self.project_config.get_experiment_from_key("test_experiment")
with mock.patch.object(
self.decision_service, "logger"
) as mock_decision_service_logging, mock.patch(
"optimizely.decision_service.DecisionService.get_whitelisted_variation",
return_value=[None, []],
) as mock_get_whitelisted_variation, mock.patch(
"optimizely.decision_service.DecisionService.get_stored_variation"
) as mock_get_stored_variation, mock.patch(
"optimizely.helpers.audience.does_user_meet_audience_conditions", return_value=[True, []]
) as mock_audience_check, mock.patch(
"optimizely.bucketer.Bucketer.bucket",
return_value=[entities.Variation("111129", "variation"), []],
) as mock_bucket, mock.patch(
"optimizely.user_profile.UserProfileService.lookup"
) as mock_lookup, mock.patch(
"optimizely.user_profile.UserProfileService.save"
) as mock_save:
variation, _ = self.decision_service.get_variation(
self.project_config, experiment, user, None
)
self.assertEqual(
entities.Variation("111129", "variation"),
variation,
)
# Assert that user is bucketed and new decision is not stored as user profile service is not available
mock_get_whitelisted_variation.assert_called_once_with(
self.project_config, experiment, "test_user"
)
self.assertEqual(0, mock_lookup.call_count)
self.assertEqual(0, mock_get_stored_variation.call_count)
mock_audience_check.assert_called_once_with(
self.project_config,
experiment.get_audience_conditions_or_ids(),
enums.ExperimentAudienceEvaluationLogs,
"test_experiment",
user.get_user_attributes(),
mock_decision_service_logging
)
mock_bucket.assert_called_once_with(
self.project_config, experiment, "test_user", "test_user"
)
self.assertEqual(0, mock_save.call_count)
def test_get_variation__user_does_not_meet_audience_conditions(self):
""" Test that get_variation returns None if user is not in experiment. """
user = optimizely_user_context.OptimizelyUserContext(optimizely_client=None, user_id="test_user",
user_attributes={})
experiment = self.project_config.get_experiment_from_key("test_experiment")
with mock.patch.object(
self.decision_service, "logger"
) as mock_decision_service_logging, mock.patch(
"optimizely.decision_service.DecisionService.get_whitelisted_variation",
return_value=[None, []],
) as mock_get_whitelisted_variation, mock.patch(
"optimizely.decision_service.DecisionService.get_stored_variation",
return_value=None,
) as mock_get_stored_variation, mock.patch(
"optimizely.helpers.audience.does_user_meet_audience_conditions", return_value=[False, []]
) as mock_audience_check, mock.patch(
"optimizely.bucketer.Bucketer.bucket"
) as mock_bucket, mock.patch(
"optimizely.user_profile.UserProfileService.lookup",
return_value={"user_id": "test_user", "experiment_bucket_map": {}},
) as mock_lookup, mock.patch(
"optimizely.user_profile.UserProfileService.save"
) as mock_save:
variation, _ = self.decision_service.get_variation(
self.project_config, experiment, user, None
)
self.assertIsNone(
variation
)
# Assert that user is bucketed and new decision is stored
mock_get_whitelisted_variation.assert_called_once_with(
self.project_config, experiment, "test_user"
)
mock_lookup.assert_called_once_with("test_user")
mock_get_stored_variation.assert_called_once_with(
self.project_config, experiment, user_profile.UserProfile("test_user")
)
mock_audience_check.assert_called_once_with(
self.project_config,
experiment.get_audience_conditions_or_ids(),
enums.ExperimentAudienceEvaluationLogs,
"test_experiment",
user.get_user_attributes(),
mock_decision_service_logging
)
self.assertEqual(0, mock_bucket.call_count)
self.assertEqual(0, mock_save.call_count)
def test_get_variation__user_profile_in_invalid_format(self):
""" Test that get_variation handles invalid user profile gracefully. """
user = optimizely_user_context.OptimizelyUserContext(optimizely_client=None, user_id="test_user",
user_attributes={})
experiment = self.project_config.get_experiment_from_key("test_experiment")
with mock.patch.object(
self.decision_service, "logger"
) as mock_decision_service_logging, mock.patch(
"optimizely.decision_service.DecisionService.get_whitelisted_variation",
return_value=[None, []],
) as mock_get_whitelisted_variation, mock.patch(
"optimizely.decision_service.DecisionService.get_stored_variation"
) as mock_get_stored_variation, mock.patch(
"optimizely.helpers.audience.does_user_meet_audience_conditions", return_value=[True, []]
) as mock_audience_check, mock.patch(
"optimizely.bucketer.Bucketer.bucket",
return_value=[entities.Variation("111129", "variation"), []],
) as mock_bucket, mock.patch(
"optimizely.user_profile.UserProfileService.lookup",
return_value="invalid_profile",
) as mock_lookup, mock.patch(
"optimizely.user_profile.UserProfileService.save"
) as mock_save:
variation, _ = self.decision_service.get_variation(
self.project_config, experiment, user, None
)
self.assertEqual(
entities.Variation("111129", "variation"),
variation,
)
# Assert that user is bucketed and new decision is stored
mock_get_whitelisted_variation.assert_called_once_with(
self.project_config, experiment, "test_user"
)
mock_lookup.assert_called_once_with("test_user")
# Stored decision is not consulted as user profile is invalid
self.assertEqual(0, mock_get_stored_variation.call_count)
mock_audience_check.assert_called_once_with(
self.project_config,
experiment.get_audience_conditions_or_ids(),
enums.ExperimentAudienceEvaluationLogs,
"test_experiment",
user.get_user_attributes(),
mock_decision_service_logging
)
mock_decision_service_logging.warning.assert_called_once_with(
"User profile has invalid format."
)
mock_bucket.assert_called_once_with(
self.project_config, experiment, "test_user", "test_user"
)
mock_save.assert_called_once_with(
{
"user_id": "test_user",
"experiment_bucket_map": {"111127": {"variation_id": "111129"}},
}
)
def test_get_variation__user_profile_lookup_fails(self):
""" Test that get_variation acts gracefully when lookup fails. """
user = optimizely_user_context.OptimizelyUserContext(optimizely_client=None, user_id="test_user",
user_attributes={})
experiment = self.project_config.get_experiment_from_key("test_experiment")
with mock.patch.object(
self.decision_service, "logger"
) as mock_decision_service_logging, mock.patch(
"optimizely.decision_service.DecisionService.get_whitelisted_variation",
return_value=[None, []],
) as mock_get_whitelisted_variation, mock.patch(
"optimizely.decision_service.DecisionService.get_stored_variation"
) as mock_get_stored_variation, mock.patch(
"optimizely.helpers.audience.does_user_meet_audience_conditions", return_value=[True, []]
) as mock_audience_check, mock.patch(
"optimizely.bucketer.Bucketer.bucket",
return_value=[entities.Variation("111129", "variation"), []],
) as mock_bucket, mock.patch(
"optimizely.user_profile.UserProfileService.lookup",
side_effect=Exception("major problem"),
) as mock_lookup, mock.patch(
"optimizely.user_profile.UserProfileService.save"
) as mock_save:
variation, _ = self.decision_service.get_variation(
self.project_config, experiment, user, None
)
self.assertEqual(
entities.Variation("111129", "variation"),
variation,
)
# Assert that user is bucketed and new decision is stored
mock_get_whitelisted_variation.assert_called_once_with(
self.project_config, experiment, "test_user"
)
mock_lookup.assert_called_once_with("test_user")
# Stored decision is not consulted as lookup failed
self.assertEqual(0, mock_get_stored_variation.call_count)
mock_audience_check.assert_called_once_with(
self.project_config,
experiment.get_audience_conditions_or_ids(),
enums.ExperimentAudienceEvaluationLogs,
"test_experiment",
user.get_user_attributes(),
mock_decision_service_logging
)
mock_decision_service_logging.exception.assert_called_once_with(
'Unable to retrieve user profile for user "test_user" as lookup failed.'
)
mock_bucket.assert_called_once_with(
self.project_config, experiment, "test_user", "test_user"
)
mock_save.assert_called_once_with(
{
"user_id": "test_user",
"experiment_bucket_map": {"111127": {"variation_id": "111129"}},
}
)
def test_get_variation__user_profile_save_fails(self):
""" Test that get_variation acts gracefully when save fails. """
user = optimizely_user_context.OptimizelyUserContext(optimizely_client=None, user_id="test_user",
user_attributes={})
experiment = self.project_config.get_experiment_from_key("test_experiment")
with mock.patch.object(
self.decision_service, "logger"
) as mock_decision_service_logging, mock.patch(
"optimizely.decision_service.DecisionService.get_whitelisted_variation",
return_value=[None, []],
) as mock_get_whitelisted_variation, mock.patch(
"optimizely.decision_service.DecisionService.get_stored_variation"
) as mock_get_stored_variation, mock.patch(
"optimizely.helpers.audience.does_user_meet_audience_conditions", return_value=[True, []]
) as mock_audience_check, mock.patch(
"optimizely.bucketer.Bucketer.bucket",
return_value=[entities.Variation("111129", "variation"), []],
) as mock_bucket, mock.patch(
"optimizely.user_profile.UserProfileService.lookup", return_value=None
) as mock_lookup, mock.patch(
"optimizely.user_profile.UserProfileService.save",
side_effect=Exception("major problem"),
) as mock_save:
variation, _ = self.decision_service.get_variation(
self.project_config, experiment, user, None
)
self.assertEqual(
entities.Variation("111129", "variation"),
variation,
)
# Assert that user is bucketed and new decision is stored
mock_get_whitelisted_variation.assert_called_once_with(
self.project_config, experiment, "test_user"
)
mock_lookup.assert_called_once_with("test_user")
self.assertEqual(0, mock_get_stored_variation.call_count)
mock_audience_check.assert_called_once_with(
self.project_config,
experiment.get_audience_conditions_or_ids(),
enums.ExperimentAudienceEvaluationLogs,
"test_experiment",
user.get_user_attributes(),
mock_decision_service_logging
)
mock_decision_service_logging.exception.assert_called_once_with(
'Unable to save user profile for user "test_user".'
)
mock_bucket.assert_called_once_with(
self.project_config, experiment, "test_user", "test_user"
)
mock_save.assert_called_once_with(
{
"user_id": "test_user",
"experiment_bucket_map": {"111127": {"variation_id": "111129"}},
}
)
def test_get_variation__ignore_user_profile_when_specified(self):
""" Test that we ignore the user profile service if specified. """
user = optimizely_user_context.OptimizelyUserContext(optimizely_client=None, user_id="test_user",
user_attributes={})
experiment = self.project_config.get_experiment_from_key("test_experiment")
with mock.patch.object(
self.decision_service, "logger"
) as mock_decision_service_logging, mock.patch(
"optimizely.decision_service.DecisionService.get_whitelisted_variation",
return_value=[None, []],
) as mock_get_whitelisted_variation, mock.patch(
"optimizely.helpers.audience.does_user_meet_audience_conditions", return_value=[True, []]
) as mock_audience_check, mock.patch(
"optimizely.bucketer.Bucketer.bucket",
return_value=[entities.Variation("111129", "variation"), []],
) as mock_bucket, mock.patch(
"optimizely.user_profile.UserProfileService.lookup"
) as mock_lookup, mock.patch(
"optimizely.user_profile.UserProfileService.save"
) as mock_save:
variation, _ = self.decision_service.get_variation(
self.project_config,
experiment,
user,
options=['IGNORE_USER_PROFILE_SERVICE'],
)
self.assertEqual(
entities.Variation("111129", "variation"),
variation,
)
# Assert that user is bucketed and new decision is NOT stored
mock_get_whitelisted_variation.assert_called_once_with(
self.project_config, experiment, "test_user"
)
mock_audience_check.assert_called_once_with(
self.project_config,
experiment.get_audience_conditions_or_ids(),
enums.ExperimentAudienceEvaluationLogs,
"test_experiment",
user.get_user_attributes(),
mock_decision_service_logging
)
mock_bucket.assert_called_once_with(
self.project_config, experiment, "test_user", "test_user"
)
self.assertEqual(0, mock_lookup.call_count)
self.assertEqual(0, mock_save.call_count)
class FeatureFlagDecisionTests(base.BaseTest):
def setUp(self):
base.BaseTest.setUp(self)
opt_obj = optimizely.Optimizely(json.dumps(self.config_dict_with_features))
self.project_config = opt_obj.config_manager.get_config()
self.decision_service = opt_obj.decision_service
self.mock_decision_logger = mock.patch.object(self.decision_service, "logger")
self.mock_config_logger = mock.patch.object(self.project_config, "logger")