Skip to content

Commit 3417408

Browse files
fix: change datafile accessor feature to return a string representation of datafile (#283)
* fix: change datafile accessor methods to return a JSON representation of the datafile * fix: change datafile accessor methods to return string instead of byte array of the datafile * test: update optimizely config datafile var name in test * refactor: add string encoding * Setting as unicode Co-authored-by: aliabbasrizvi <[email protected]>
1 parent 5d35a59 commit 3417408

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

optimizely/optimizely_config.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,15 @@ def __init__(self, revision, experiments_map, features_map, datafile=None):
2121
self.revision = revision
2222
self.experiments_map = experiments_map
2323
self.features_map = features_map
24-
self.datafile = datafile
24+
self._datafile = datafile
2525

2626
def get_datafile(self):
2727
""" Get the datafile associated with OptimizelyConfig.
2828
2929
Returns:
3030
A JSON string representation of the environment's datafile.
3131
"""
32-
return self.datafile
32+
return self._datafile
3333

3434

3535
class OptimizelyExperiment(object):

optimizely/project_config.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ def __init__(self, datafile, logger, error_handler):
4040
"""
4141

4242
config = json.loads(datafile)
43-
self._datafile = datafile
43+
self._datafile = u'{}'.format(datafile)
4444
self.logger = logger
4545
self.error_handler = error_handler
4646
self.version = config.get('version')

tests/test_optimizely_config.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -456,7 +456,7 @@ def setUp(self):
456456
}
457457
},
458458
'revision': '1',
459-
'datafile': json.dumps(self.config_dict_with_features)
459+
'_datafile': json.dumps(self.config_dict_with_features)
460460
}
461461

462462
self.actual_config = self.opt_config_service.get_config()

0 commit comments

Comments
 (0)