Skip to content

Commit 45e73bb

Browse files
All threads have been named (#443)
1 parent 7fa6153 commit 45e73bb

5 files changed

+6
-5
lines changed

.gitignore

+2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ MANIFEST
33
.idea/*
44
.*virtualenv/*
55
.mypy_cache
6+
.vscode/*
67

78
# Output of building package
89
*.egg-info
@@ -26,3 +27,4 @@ datafile.json
2627

2728
# Sphinx documentation
2829
docs/build/
30+

optimizely/config_manager.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,7 @@ def start(self) -> None:
432432
self._polling_thread.start()
433433

434434
def _initialize_thread(self) -> None:
435-
self._polling_thread = threading.Thread(target=self._run, daemon=True)
435+
self._polling_thread = threading.Thread(target=self._run, name="PollThread", daemon=True)
436436

437437

438438
class AuthDatafilePollingConfigManager(PollingConfigManager):

optimizely/event/event_processor.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -186,8 +186,7 @@ def start(self) -> None:
186186
return
187187

188188
self.flushing_interval_deadline = self._get_time() + self._get_time(self.flush_interval.total_seconds())
189-
self.executor = threading.Thread(target=self._run)
190-
self.executor.daemon = True
189+
self.executor = threading.Thread(target=self._run, name="EventThread", daemon=True)
191190
self.executor.start()
192191

193192
def _run(self) -> None:

optimizely/odp/odp_event_manager.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ def __init__(
7575
self.retry_count = OdpEventManagerConfig.DEFAULT_RETRY_COUNT
7676
self._current_batch: list[OdpEvent] = []
7777
"""_current_batch should only be modified by the processing thread, as it is not thread safe"""
78-
self.thread = Thread(target=self._run, daemon=True)
78+
self.thread = Thread(target=self._run, name="OdpThread", daemon=True)
7979
self.thread_exception = False
8080
"""thread_exception will be True if the processing thread did not exit cleanly"""
8181

optimizely/optimizely_user_context.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ def _fetch_qualified_segments() -> bool:
336336
return success
337337

338338
if callback:
339-
fetch_thread = threading.Thread(target=_fetch_qualified_segments)
339+
fetch_thread = threading.Thread(target=_fetch_qualified_segments, name="FetchQualifiedSegmentsThread")
340340
fetch_thread.start()
341341
return fetch_thread
342342
else:

0 commit comments

Comments
 (0)