fix: block odp methods on datafile (#419)

* add blocking call to odp methods

* git ignore mypy cache

Author: andrewleap-optimizely

.gitignore

@@ -2,6 +2,7 @@
 MANIFEST
 .idea/*
 .*virtualenv/*
+.mypy_cache
 
 # Output of building package
 *.egg-info

optimizely/optimizely.py

@@ -1357,13 +1357,23 @@ def _identify_user(self, user_id: str) -> None:
             self.logger.error(enums.Errors.INVALID_OPTIMIZELY.format('identify_user'))
             return
 
+        config = self.config_manager.get_config()
+        if not config:
+            self.logger.error(enums.Errors.INVALID_PROJECT_CONFIG.format('identify_user'))
+            return
+
         self.odp_manager.identify_user(user_id)
 
     def _fetch_qualified_segments(self, user_id: str, options: Optional[list[str]] = None) -> Optional[list[str]]:
         if not self.is_valid:
             self.logger.error(enums.Errors.INVALID_OPTIMIZELY.format('fetch_qualified_segments'))
             return None
 
+        config = self.config_manager.get_config()
+        if not config:
+            self.logger.error(enums.Errors.INVALID_PROJECT_CONFIG.format('fetch_qualified_segments'))
+            return None
+
         return self.odp_manager.fetch_qualified_segments(user_id, options or [])
 
     def send_odp_event(
@@ -1391,6 +1401,11 @@ def send_odp_event(
             self.logger.error('ODP events must have at least one key-value pair in identifiers.')
             return
 
+        config = self.config_manager.get_config()
+        if not config:
+            self.logger.error(enums.Errors.INVALID_PROJECT_CONFIG.format('send_odp_event'))
+            return
+
         self.odp_manager.send_event(type, action, identifiers, data or {})
 
     def close(self) -> None:

tests/test_optimizely.py

@@ -5399,12 +5399,8 @@ def test_send_odp_event__send_event_with_polling_config_manager(self):
                 status_code=200,
                 content=json.dumps(self.config_dict_with_audience_segments)
             )
-        ):
+        ), mock.patch('requests.post', return_value=self.fake_server_response(status_code=200)):
             client = optimizely.Optimizely(sdk_key='test', logger=mock_logger)
-            # wait for config
-            client.config_manager.get_config()
-
-        with mock.patch('requests.post', return_value=self.fake_server_response(status_code=200)):
             client.send_odp_event(type='wow', action='great', identifiers={'amazing': 'fantastic'}, data={})
             client.close()
 
@@ -5426,9 +5422,12 @@ def test_send_odp_event__log_error_when_odp_disabled(self):
     def test_send_odp_event__log_debug_if_datafile_not_ready(self):
         mock_logger = mock.Mock()
         client = optimizely.Optimizely(sdk_key='test', logger=mock_logger)
+        client.config_manager.set_blocking_timeout(0)
         client.send_odp_event(type='wow', action='great', identifiers={'amazing': 'fantastic'}, data={})
 
-        mock_logger.debug.assert_called_with('ODP event queue: cannot send before config has been set.')
+        mock_logger.error.assert_called_with(
+            'Invalid config. Optimizely instance is not valid. Failing "send_odp_event".'
+        )
         client.close()
 
     def test_send_odp_event__log_error_if_odp_not_enabled_with_polling_config_manager(self):
@@ -5439,16 +5438,12 @@ def test_send_odp_event__log_error_if_odp_not_enabled_with_polling_config_manage
                 status_code=200,
                 content=json.dumps(self.config_dict_with_audience_segments)
             )
-        ):
+        ), mock.patch('requests.post', return_value=self.fake_server_response(status_code=200)):
             client = optimizely.Optimizely(
                 sdk_key='test',
                 logger=mock_logger,
                 settings=OptimizelySdkSettings(odp_disabled=True)
             )
-            # wait for config
-            client.config_manager.get_config()
-
-        with mock.patch('requests.post', return_value=self.fake_server_response(status_code=200)):
             client.send_odp_event(type='wow', action='great', identifiers={'amazing': 'fantastic'}, data={})
             client.close()