Skip to content

Commit 876d64b

Browse files
oakbanithomaszurkan-optimizely
authored andcommitted
fix: Forwarding Event Processor defaults to default event dispatcher (#235)
* tests: fail unit test * fix: default ForwardingEventProcessor to use default event dispatcher
1 parent 2ccae39 commit 876d64b

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

optimizely/event/event_processor.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright 2019 Optimizely
1+
# Copyright 2019-2020 Optimizely
22
# Licensed under the Apache License, Version 2.0 (the "License");
33
# you may not use this file except in compliance with the License.
44
# You may obtain a copy of the License at
@@ -335,7 +335,7 @@ def __init__(self, event_dispatcher, logger=None, notification_center=None):
335335
logger: Optional component which provides a log method to log messages. By default nothing would be logged.
336336
notification_center: Optional instance of notification_center.NotificationCenter.
337337
"""
338-
self.event_dispatcher = event_dispatcher
338+
self.event_dispatcher = event_dispatcher or default_event_dispatcher
339339
self.logger = _logging.adapt_logger(logger or _logging.NoOpLogger())
340340
self.notification_center = notification_center or _notification_center.NotificationCenter(self.logger)
341341

tests/test_event_processor.py

+9-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright 2019, Optimizely
1+
# Copyright 2019-2020, Optimizely
22
# Licensed under the Apache License, Version 2.0 (the "License");
33
# you may not use this file except in compliance with the License.
44
# You may obtain a copy of the License at
@@ -24,6 +24,7 @@
2424
from optimizely.event.event_factory import EventFactory
2525
from optimizely.event.log_event import LogEvent
2626
from optimizely.event.user_event_factory import UserEventFactory
27+
from optimizely.event_dispatcher import EventDispatcher as default_event_dispatcher
2728
from optimizely.helpers import enums
2829
from optimizely.logger import SimpleLogger
2930
from . import base
@@ -561,3 +562,10 @@ def on_log_event(log_event):
561562
self.assertEqual(
562563
1, len(self.optimizely.notification_center.notification_listeners[enums.NotificationTypes.LOG_EVENT]),
563564
)
565+
566+
def test_event_processor_defaults_to_default_event_dispatcher(self):
567+
event_processor = ForwardingEventProcessor(None)
568+
self.assertEqual(
569+
event_processor.event_dispatcher,
570+
default_event_dispatcher
571+
)

0 commit comments

Comments
 (0)