fixing unit tests

Author: aliabbasrizvi

optimizely/decision_service.py

@@ -263,8 +263,8 @@ def get_variation(self, project_config, experiment, user_id, attributes, ignore_
 
         # Bucket user and store the new decision
         audience_conditions = experiment.get_audience_conditions_or_ids()
-        if not audience_helper.does_user_meet_audience_conditions(
-          project_config, audience_conditions, 'experiment', experiment.key, attributes, self.logger):
+        if not audience_helper.does_user_meet_audience_conditions(project_config, audience_conditions, 'experiment',
+                                                                  experiment.key, attributes, self.logger):
             self.logger.info(
                 'User "{}" does not meet conditions to be in experiment "{}".'.format(user_id, experiment.key))
             return None
@@ -307,8 +307,12 @@ def get_variation_for_rollout(self, project_config, rollout, user_id, attributes
 
                 # Check if user meets audience conditions for targeting rule
                 audience_conditions = rollout_rule.get_audience_conditions_or_ids()
-                if not audience_helper.does_user_meet_audience_conditions(
-                  project_config, audience_conditions, 'rollout-rule', logging_key, attributes, self.logger):
+                if not audience_helper.does_user_meet_audience_conditions(project_config,
+                                                                          audience_conditions,
+                                                                          'rollout-rule',
+                                                                          logging_key,
+                                                                          attributes,
+                                                                          self.logger):
                     self.logger.debug(
                         'User "{}" does not meet conditions for targeting rule {}.'.format(user_id, logging_key))
                     continue
@@ -340,7 +344,8 @@ def get_variation_for_rollout(self, project_config, rollout, user_id, attributes
                 'rollout-rule',
                 'Everyone Else',
                 attributes,
-                self.logger):
+                self.logger
+            ):
                 # Determine bucketing ID to be used
                 bucketing_id = self._get_bucketing_id(user_id, attributes)
                 variation = self.bucketer.bucket(project_config, everyone_else_rule, user_id, bucketing_id)

optimizely/helpers/audience.py

@@ -19,8 +19,12 @@
 from .enums import RolloutRuleAudienceEvaluationLogs as rules_audience_logs
 
 
-def does_user_meet_audience_conditions(
-    config, audience_conditions, experiment_or_rollout_rule, logging_key, attributes, logger):
+def does_user_meet_audience_conditions(config,
+                                       audience_conditions,
+                                       experiment_or_rollout_rule,
+                                       logging_key,
+                                       attributes,
+                                       logger):
     """ Determine for given experiment if user satisfies the audiences for the experiment.
 
     Args:

tests/helpers_tests/test_audience.py

@@ -153,7 +153,8 @@ def test_does_user_meet_audience_conditions__no_attributes(self):
         self.assertEqual({}, custom_attr_eval.call_args[0][1])
 
     def test_does_user_meet_audience_conditions__returns_true__when_condition_tree_evaluator_returns_true(self):
-        """ Test that does_user_meet_audience_conditions returns True when call to condition_tree_evaluator returns True. """
+        """ Test that does_user_meet_audience_conditions returns True
+            when call to condition_tree_evaluator returns True. """
 
         user_attributes = {'test_attribute': 'test_value_1'}
         experiment = self.project_config.get_experiment_from_key('test_experiment')
@@ -170,7 +171,7 @@ def test_does_user_meet_audience_conditions__returns_true__when_condition_tree_e
                 )
             )
 
-    def test_does_user_meet_audience_conditions__returns_false__when_condition_tree_evaluator_returns_none_or_false(self):
+    def test_does_user_meet_audience_conditions_returns_false_when_condition_tree_evaluator_returns_none_or_false(self):
         """ Test that does_user_meet_audience_conditions returns False
         when call to condition_tree_evaluator returns None or False. """
 
@@ -248,7 +249,7 @@ def test_does_user_meet_audience_conditions__evaluates_audience_conditions(self)
 
         with mock.patch('optimizely.helpers.condition.CustomAttributeConditionEvaluator') as custom_attr_eval:
             audience.does_user_meet_audience_conditions(
-                self.project_config,
+                project_config,
                 experiment.get_audience_conditions_or_ids(),
                 'experiment',
                 'audience_combinations_experiment',
@@ -285,7 +286,7 @@ def test_does_user_meet_audience_conditions__evaluates_audience_conditions_leaf_
 
         with mock.patch('optimizely.helpers.condition.CustomAttributeConditionEvaluator') as custom_attr_eval:
             audience.does_user_meet_audience_conditions(
-                self.project_config,
+                project_config,
                 experiment.get_audience_conditions_or_ids(),
                 'experiment',
                 'audience_combinations_experiment',
@@ -386,7 +387,7 @@ def test_does_user_meet_audience_conditions__evaluates_audience_conditions(self)
             'optimizely.helpers.condition.CustomAttributeConditionEvaluator.evaluate', side_effect=[False, None, True],
         ):
             audience.does_user_meet_audience_conditions(
-                self.project_config,
+                project_config,
                 experiment.get_audience_conditions_or_ids(),
                 'experiment',
                 'audience_combinations_experiment',