From 7ad6909f1b444113401949f15065238064a825cc Mon Sep 17 00:00:00 2001 From: rashidsp Date: Thu, 5 Sep 2019 18:37:00 +0500 Subject: [PATCH 1/2] fix(config-manager): Updates polling interval condition --- optimizely/config_manager.py | 4 ++-- optimizely/helpers/enums.py | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/optimizely/config_manager.py b/optimizely/config_manager.py index 286551f5..aeaefdad 100644 --- a/optimizely/config_manager.py +++ b/optimizely/config_manager.py @@ -246,8 +246,8 @@ def set_update_interval(self, update_interval): 'Invalid update_interval "{}" provided.'.format(update_interval) ) - # If polling interval is less than minimum allowed interval then set it to default update interval. - if update_interval < enums.ConfigManager.MIN_UPDATE_INTERVAL: + # If polling interval is less than or equal to 0 then set it to default update interval. + if update_interval <= 0: self.logger.debug('update_interval value {} too small. Defaulting to {}'.format( update_interval, enums.ConfigManager.DEFAULT_UPDATE_INTERVAL) diff --git a/optimizely/helpers/enums.py b/optimizely/helpers/enums.py index 38c13316..893538ca 100644 --- a/optimizely/helpers/enums.py +++ b/optimizely/helpers/enums.py @@ -40,8 +40,6 @@ class ConfigManager(object): DATAFILE_URL_TEMPLATE = 'https://cdn.optimizely.com/datafiles/{sdk_key}.json' # Default config update interval of 5 minutes DEFAULT_UPDATE_INTERVAL = 5 * 60 - # Minimum config update interval of 1 second - MIN_UPDATE_INTERVAL = 1 # Time in seconds before which request for datafile times out REQUEST_TIMEOUT = 10 From bdcaf649c729f0a20674d7f22a57f8926d30beda Mon Sep 17 00:00:00 2001 From: MariamJamal32 Date: Fri, 6 Sep 2019 09:58:50 +0500 Subject: [PATCH 2/2] fix: config_manager testcase. --- tests/test_config_manager.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_config_manager.py b/tests/test_config_manager.py index 8950705f..a607009d 100644 --- a/tests/test_config_manager.py +++ b/tests/test_config_manager.py @@ -224,7 +224,7 @@ def test_set_update_interval(self, _): project_config_manager.set_update_interval('invalid interval') # Assert that update_interval cannot be set to less than allowed minimum and instead is set to default value. - project_config_manager.set_update_interval(0.42) + project_config_manager.set_update_interval(-4.2) self.assertEqual(enums.ConfigManager.DEFAULT_UPDATE_INTERVAL, project_config_manager.update_interval) # Assert that if no update_interval is provided, it is set to default value.