From 931f287cc664355f675c1d8d62fd98b6650f9f36 Mon Sep 17 00:00:00 2001 From: Jacob Brown Date: Thu, 15 Jul 2021 13:01:59 -0400 Subject: [PATCH 1/2] Fix in user_event_factory to use experiment_id to lookup variation for impression events. --- optimizely/event/user_event_factory.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/optimizely/event/user_event_factory.py b/optimizely/event/user_event_factory.py index 94ca8638..c232044b 100644 --- a/optimizely/event/user_event_factory.py +++ b/optimizely/event/user_event_factory.py @@ -45,12 +45,12 @@ def create_impression_event( if not activated_experiment and rule_type is not enums.DecisionSources.ROLLOUT: return None - variation, experiment_key = None, None + variation, experiment_id = None, None if activated_experiment: - experiment_key = activated_experiment.key + experiment_id = activated_experiment.id - if variation_id and experiment_key: - variation = project_config.get_variation_from_id(experiment_key, variation_id) + if variation_id and experiment_id: + variation = project_config.get_variation_from_id_by_experiment_id(experiment_id, variation_id) event_context = user_event.EventContext( project_config.account_id, project_config.project_id, project_config.revision, project_config.anonymize_ip, ) From 9610564d8371940a93e8bd8b15637c16dfe83744 Mon Sep 17 00:00:00 2001 From: Jacob Brown Date: Thu, 15 Jul 2021 13:07:59 -0400 Subject: [PATCH 2/2] Update License Header to 2021. --- optimizely/event/user_event_factory.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/optimizely/event/user_event_factory.py b/optimizely/event/user_event_factory.py index c232044b..1db9fc95 100644 --- a/optimizely/event/user_event_factory.py +++ b/optimizely/event/user_event_factory.py @@ -1,4 +1,4 @@ -# Copyright 2019 Optimizely +# Copyright 2019, 2021 Optimizely # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at