From 152fa8461ed45a0c0dc5015f6bb7b96b1b0e5580 Mon Sep 17 00:00:00 2001 From: Gordon So <4214928+GordonSo@users.noreply.github.com> Date: Thu, 9 Sep 2021 12:41:30 +0100 Subject: [PATCH 1/3] ISSUE-232---drop-mmh3-dependency --- requirements/core.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/requirements/core.txt b/requirements/core.txt index 4049419d..58d2e8e8 100644 --- a/requirements/core.txt +++ b/requirements/core.txt @@ -1,6 +1,5 @@ jsonschema==3.2.0 pyrsistent==0.16.0 -mmh3==2.5.1 requests>=2.21 pyOpenSSL>=19.1.0 cryptography>=2.8.0 From 02b911598b86df19fa11afacecbcf1d188bd78df Mon Sep 17 00:00:00 2001 From: Gordon So <4214928+GordonSo@users.noreply.github.com> Date: Thu, 9 Sep 2021 12:54:59 +0100 Subject: [PATCH 2/3] updated readme --- README.md | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index b2cae17b..e05ff08c 100644 --- a/README.md +++ b/README.md @@ -33,10 +33,16 @@ To install: pip install optimizely-sdk Note: -If you are running the SDK with PyPy or PyPy3 and you are experiencing issues, install this cryptography package **first** and then optimizely-sdk package: +- If you are running the SDK with PyPy or PyPy3 and you are experiencing issues, install this cryptography package **first** and then optimizely-sdk package: pip install "cryptography>=1.3.4,<=3.1.1" + +- After v3.0.0 mmh3 is no longer a mandatory dependency to removed to remove the c++ build requirement. +If you are experiencing (performance) problems, install this explicitly and it will continue to be honoured by code: + + pip install "mmh3==2.5.1" + ### Feature Management Access To access the Feature Management configuration in the Optimizely @@ -230,4 +236,4 @@ This software incorporates code from the following open source repos: requests (Apache-2.0 License: https://github.com/psf/requests/blob/master/LICENSE) pyOpenSSL (Apache-2.0 License https://github.com/pyca/pyopenssl/blob/main/LICENSE) cryptography (Apache-2.0 https://github.com/pyca/cryptography/blob/main/LICENSE.APACHE) -idna (BSD 3-Clause License https://github.com/kjd/idna/blob/master/LICENSE.md) +idna (BSD 3-Clause License https://github.com/kjd/idna/blob/master/LICENSE.md) From 67afc62a84e174633ec02140fb9b490b4356939b Mon Sep 17 00:00:00 2001 From: Gordon So <4214928+GordonSo@users.noreply.github.com> Date: Thu, 9 Sep 2021 13:02:06 +0100 Subject: [PATCH 3/3] Update README.md --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index e05ff08c..203976d3 100644 --- a/README.md +++ b/README.md @@ -35,13 +35,13 @@ To install: Note: - If you are running the SDK with PyPy or PyPy3 and you are experiencing issues, install this cryptography package **first** and then optimizely-sdk package: - pip install "cryptography>=1.3.4,<=3.1.1" + ```pip install "cryptography>=1.3.4,<=3.1.1"``` - After v3.0.0 mmh3 is no longer a mandatory dependency to removed to remove the c++ build requirement. If you are experiencing (performance) problems, install this explicitly and it will continue to be honoured by code: - pip install "mmh3==2.5.1" + ```pip install "mmh3==2.5.1"``` ### Feature Management Access