Skip to content

Commit 4e1001e

Browse files
committed
Treat missing checksum file as an error
1 parent fe9e0ba commit 4e1001e

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

src/Download.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -201,12 +201,13 @@ void verifyChecksums(String checksum) throws Exception {
201201
var remoteChecksum = findRemoteChecksum(checksum);
202202
if (remoteChecksum.isEmpty()) {
203203
GitHub.warn("Checksum not available for: " + uri);
204-
return;
204+
} else {
205+
var remote = remoteChecksum.get();
206+
GitHub.debug("Remote checksum: " + remote);
207+
if (cached.equals(remote)) {
208+
return;
209+
}
205210
}
206-
207-
var remote = remoteChecksum.get();
208-
GitHub.debug("Remote checksum: " + remote);
209-
if (cached.equals(remote)) return;
210211
var message = "Checksum verification failed, deleting cached archive";
211212
Files.delete(archive);
212213
GitHub.error(message);

test/Test.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ static void checkJDK(String website, Download.JDK jdk) {
7979
var head = BROWSER.head(uri);
8080
if (head.statusCode() < 200 || head.statusCode() >= 400) ERRORS.add(head.toString());
8181
System.out.println(head);
82+
System.out.println(" " + BROWSER.browse(uri + ".sha256"));
8283
} catch (Exception exception) {
8384
ERRORS.add(jdk + "\n" + exception);
8485
}

0 commit comments

Comments
 (0)