Resolve more Truffle DSL warnings

Author: DSouzaM

Diff for: graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/bytecode/GetSendValueNode.java

@@ -47,6 +47,7 @@
 import com.oracle.truffle.api.dsl.Fallback;
 import com.oracle.truffle.api.dsl.GenerateInline;
 import com.oracle.truffle.api.dsl.GenerateUncached;
+import com.oracle.truffle.api.dsl.NeverDefault;
 import com.oracle.truffle.api.dsl.Specialization;
 
 @GenerateUncached
@@ -69,6 +70,7 @@ Object doSend(Object obj) {
         return obj;
     }
 
+    @NeverDefault
     public static GetSendValueNode create() {
         return GetSendValueNodeGen.create();
     }

Diff for: graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/bytecode/GetTPFlagsNode.java

@@ -47,6 +47,7 @@
 import com.oracle.truffle.api.dsl.Cached;
 import com.oracle.truffle.api.dsl.GenerateInline;
 import com.oracle.truffle.api.dsl.GenerateUncached;
+import com.oracle.truffle.api.dsl.NeverDefault;
 import com.oracle.truffle.api.dsl.Specialization;
 import com.oracle.truffle.api.nodes.Node;
 
@@ -63,6 +64,7 @@ long get(Object object,
         return getTypeFlagsNode.execute(getClassNode.execute(inliningTarget, object));
     }
 
+    @NeverDefault
     public static GetTPFlagsNode create() {
         return GetTPFlagsNodeGen.create();
     }

Diff for: graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/bytecode_dsl/PBytecodeDSLRootNode.java

@@ -1863,6 +1863,7 @@ public static void doUnpackIterable(VirtualFrame virtualFrame, Object collection
 
     @Operation
     @ImportStatic({PGuards.class})
+    @SuppressWarnings("truffle-interpreted-performance")
     public static final class UnpackStarredToLocals {
         @Specialization(guards = {"cannotBeOverridden(sequence, inliningTarget, getClassNode)", "!isPString(sequence)"}, limit = "1")
         public static void doUnpackSequence(VirtualFrame localFrame, PSequence sequence, int starIndex,
@@ -2949,7 +2950,7 @@ public static void doEnter(VirtualFrame frame, Object contextManager,
     public static final class ContextManagerExit {
         @Specialization
         public static void doRegular(VirtualFrame frame, PNone none, Object exit, Object contextManager,
-                        @Cached CallQuaternaryMethodNode callExit) {
+                        @Shared @Cached CallQuaternaryMethodNode callExit) {
             callExit.execute(frame, exit, contextManager, PNone.NONE, PNone.NONE, PNone.NONE);
         }
 
@@ -2959,7 +2960,7 @@ public static void doExceptional(VirtualFrame frame,
                         Object exception, Object exit, Object contextManager,
                         @Bind("this") Node inliningTarget,
                         @Bind("$root") PBytecodeDSLRootNode rootNode,
-                        @Cached CallQuaternaryMethodNode callExit,
+                        @Shared @Cached CallQuaternaryMethodNode callExit,
                         @Cached GetClassNode getClass,
                         @Cached ExceptionNodes.GetTracebackNode getTraceback,
                         @Cached PyObjectIsTrueNode isTrue,
@@ -3023,7 +3024,7 @@ public static final class AsyncContextManagerCallExit {
         @Specialization
         public static Object doRegular(VirtualFrame frame,
                         PNone none, Object exit, Object contextManager,
-                        @Cached CallQuaternaryMethodNode callExit) {
+                        @Shared @Cached CallQuaternaryMethodNode callExit) {
             return callExit.execute(frame, exit, contextManager, PNone.NONE, PNone.NONE, PNone.NONE);
         }
 
@@ -3033,7 +3034,7 @@ public static Object doExceptional(VirtualFrame frame,
                         Object exception, Object exit, Object contextManager,
                         @Bind("this") Node inliningTarget,
                         @Bind("$root") PBytecodeDSLRootNode rootNode,
-                        @Cached CallQuaternaryMethodNode callExit,
+                        @Shared @Cached CallQuaternaryMethodNode callExit,
                         @Cached GetClassNode getClass,
                         @Cached ExceptionNodes.GetTracebackNode getTraceback,
                         @Cached PyObjectIsTrueNode isTrue,
@@ -3056,9 +3057,10 @@ public static Object doExceptional(VirtualFrame frame,
 
     @Operation
     public static final class AsyncContextManagerExit {
-        // NB: There is nothing to do after awaiting __exit__(None, None, None), so this
-        // operation is only used for the case where the context manager exits due to an
-        // exception.
+        /**
+         * NB: There is nothing to do after awaiting __exit__(None, None, None), so this operation
+         * is only emitted for the case where the context manager exits due to an exception.
+         */
         @Specialization
         @InliningCutoff
         public static void doExceptional(VirtualFrame frame,
@@ -3268,6 +3270,7 @@ public static Object doObject(VirtualFrame frame, Object sendValue,
     }
 
     @Operation
+    @SuppressWarnings("truffle-interpreted-performance")
     public static final class YieldFromSend {
         private static final TruffleString T_SEND = tsLiteral("send");
 
@@ -3336,6 +3339,7 @@ private static void handleException(VirtualFrame frame, PException e, Node inlin
     }
 
     @Operation
+    @SuppressWarnings("turffle-interpreted-performance")
     public static final class YieldFromThrow {
 
         private static final TruffleString T_CLOSE = tsLiteral("close");

Diff for: graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/expression/UnaryArithmetic.java

@@ -176,7 +176,7 @@ public static double pos(double arg) {
 
         @Specialization
         public static Object doGeneric(VirtualFrame frame, Object arg,
-                        @Cached(value = "createCallNode(T___POS__, NOT_IMPLEMENTED)", inline = false) LookupAndCallUnaryNode callNode) {
+                        @Cached(value = "createCallNode(T___POS__, NOT_IMPLEMENTED)") LookupAndCallUnaryNode callNode) {
             return callNode.executeObject(frame, arg);
         }
 
@@ -215,7 +215,7 @@ public static double neg(double arg) {
 
         @Specialization
         public static Object doGeneric(VirtualFrame frame, Object arg,
-                        @Cached(value = "createCallNode(T___NEG__, NOT_IMPLEMENTED)", inline = false) LookupAndCallUnaryNode callNode) {
+                        @Cached(value = "createCallNode(T___NEG__, NOT_IMPLEMENTED)") LookupAndCallUnaryNode callNode) {
             return callNode.executeObject(frame, arg);
         }
 
@@ -249,7 +249,7 @@ public static long invert(long arg) {
 
         @Specialization
         public static Object doGeneric(VirtualFrame frame, Object arg,
-                        @Cached(value = "createCallNode(T___INVERT__, NOT_IMPLEMENTED)", inline = false) LookupAndCallUnaryNode callNode) {
+                        @Cached(value = "createCallNode(T___INVERT__, NOT_IMPLEMENTED)") LookupAndCallUnaryNode callNode) {
             return callNode.executeObject(frame, arg);
         }