Skip to content

Commit 6f6baf5

Browse files
committed
Fix NCHAR/NVARCHAR/NCLOB metadata
1 parent df2b336 commit 6f6baf5

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

src/njs/src/njsConnection.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,9 @@ Local<Value> njsConnection::GetMetaData(njsVariable *vars, uint32_t numVars,
494494
Nan::New<v8::Boolean>(var->isNullable));
495495
switch (dbType) {
496496
case NJS_DB_TYPE_VARCHAR:
497+
case NJS_DB_TYPE_NVARCHAR:
497498
case NJS_DB_TYPE_CHAR:
499+
case NJS_DB_TYPE_NCHAR:
498500
case NJS_DB_TYPE_RAW:
499501
Nan::Set(column,
500502
Nan::New<v8::String>("byteSize").ToLocalChecked(),

test/extendedMetaData.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -543,7 +543,7 @@ describe('17. extendedMetaData.js', function() {
543543
(result.metaData).should.deepEqual(
544544
[ { name: 'NVCH',
545545
fetchType: oracledb.STRING,
546-
dbType: oracledb.DB_TYPE_VARCHAR,
546+
dbType: oracledb.DB_TYPE_NVARCHAR,
547547
byteSize: 4000,
548548
nullable: true } ]
549549
);
@@ -577,15 +577,15 @@ describe('17. extendedMetaData.js', function() {
577577
it('17.3.4 NCHAR', function(done) {
578578

579579
connection.execute(
580-
"SELECT ch FROM nodb_metadata",
580+
"SELECT nch FROM nodb_metadata",
581581
[],
582582
{ extendedMetaData: true },
583583
function(err, result) {
584584
should.not.exist(err);
585585
(result.metaData).should.deepEqual(
586-
[ { name: 'CH',
586+
[ { name: 'NCH',
587587
fetchType: oracledb.STRING,
588-
dbType: oracledb.DB_TYPE_CHAR,
588+
dbType: oracledb.DB_TYPE_NCHAR,
589589
byteSize: 2000,
590590
nullable: true } ]
591591
);
@@ -1254,7 +1254,7 @@ describe('17. extendedMetaData.js', function() {
12541254
(result.metaData).should.deepEqual(
12551255
[ { name: 'NCLB',
12561256
fetchType: oracledb.CLOB,
1257-
dbType: oracledb.DB_TYPE_CLOB,
1257+
dbType: oracledb.DB_TYPE_NCLOB,
12581258
nullable: true } ]
12591259
);
12601260
done();

0 commit comments

Comments
 (0)