Add tests

Author: Harvey Lowndes

pkg/flexvolume/flexvolume.go

@@ -154,15 +154,15 @@ func ExecDriver(drivers map[string]Driver, args []string) DriverStatus {
 	driver := drivers[DefaultSymlinkDirectory] //Block volume is default
 
 	dir := path.Base(args[0])
-	dir = strings.TrimPrefix(dir, "oracle~")
+	dir = string(strings.TrimPrefix(dir, "oracle~"))
 
 	if dir != "oci" && dir != DefaultSymlinkDirectory {
 		driver = drivers[dir]
 	}
 
 	// Moved outside the above if to catch errors in code.
 	if driver == nil {
-		Failf("No driver found for ", dir)
+		return Failf("No driver found for %s", dir)
 	}
 
 	log.Printf("Using %s driver", dir)
@@ -283,5 +283,4 @@ func ExecDriver(drivers map[string]Driver, args []string) DriverStatus {
 	default:
 		return Failf("invalid command; got ", args)
 	}
-	return Failf("Unexpected condition")
 }

pkg/flexvolume/flexvolume_test.go

@@ -72,3 +72,14 @@ func TestAttachUnsuported(t *testing.T) {
 	expected := DriverStatus{Status: "Not supported"}
 	assertFailure(t, expected, status)
 }
+
+func TestInvalidSymlink(t *testing.T) {
+	status := ExecDriver(map[string]Driver{"oci-bvs": mockFlexvolumeDriver{}},
+		[]string{"oci-abc", "init", defaultTestOps, "nodeName"})
+
+	expected := DriverStatus{
+		Status:  "Failure",
+		Message: "No driver found for oci-abc",
+	}
+	assertFailure(t, expected, status)
+}