Skip to content

Commit 079786e

Browse files
Knut Anders Hatlentrondn
authored andcommitted
Use Collection instead of List in HistoryGuru.createCacheReal()
(Allows simplification of createCache().)
1 parent a638f35 commit 079786e

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

src/org/opensolaris/opengrok/history/HistoryGuru.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
*/
1919

2020
/*
21-
* Copyright 2005 Sun Microsystems, Inc. All rights reserved.
21+
* Copyright 2010 Sun Microsystems, Inc. All rights reserved.
2222
* Use is subject to license terms.
2323
*/
2424
package org.opensolaris.opengrok.history;
@@ -27,6 +27,7 @@
2727
import java.io.IOException;
2828
import java.io.InputStream;
2929
import java.util.ArrayList;
30+
import java.util.Collection;
3031
import java.util.HashMap;
3132
import java.util.Iterator;
3233
import java.util.List;
@@ -430,7 +431,7 @@ private void createCache(Repository repository, String sinceRevision) {
430431
}
431432
}
432433

433-
private void createCacheReal(List<Repository> repositories) {
434+
private void createCacheReal(Collection<Repository> repositories) {
434435
ExecutorService executor = Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors() * 2);
435436

436437
for (final Repository repos : repositories) {
@@ -479,11 +480,7 @@ public void createCache() {
479480
return;
480481
}
481482

482-
ArrayList<Repository> repos = new ArrayList<Repository>();
483-
for (Map.Entry<String, Repository> entry : repositories.entrySet()) {
484-
repos.add(entry.getValue());
485-
}
486-
createCacheReal(repos);
483+
createCacheReal(repositories.values());
487484
}
488485

489486
public void createCache(List<String> repositories) {

0 commit comments

Comments
 (0)