[GR-47834] Always split String#<< and profile to avoid unnecessary compile() calls

PullRequest: truffleruby/4189

Author: eregon

src/main/java/org/truffleruby/core/regexp/TruffleRegexpNodes.java

@@ -24,6 +24,7 @@
 import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.TruffleSafepoint;
 import com.oracle.truffle.api.dsl.Bind;
+import com.oracle.truffle.api.dsl.Cached.Exclusive;
 import com.oracle.truffle.api.dsl.Fallback;
 import com.oracle.truffle.api.dsl.GenerateCached;
 import com.oracle.truffle.api.dsl.GenerateInline;
@@ -86,6 +87,7 @@
 import org.truffleruby.language.library.RubyStringLibrary;
 import org.truffleruby.language.objects.AllocationTracing;
 import org.truffleruby.parser.RubyDeferredWarnings;
+import org.truffleruby.utils.RunTwiceBranchProfile;
 
 import static com.oracle.truffle.api.strings.TruffleString.CodeRange.ASCII;
 import static com.oracle.truffle.api.strings.TruffleString.CodeRange.BROKEN;
@@ -372,41 +374,49 @@ public abstract static class TRegexCompileNode extends RubyBaseNode {
         @Child DispatchNode warnOnFallbackNode;
 
         @Specialization(guards = "encoding == US_ASCII")
-        Object usASCII(RubyRegexp regexp, boolean atStart, RubyEncoding encoding) {
+        Object usASCII(RubyRegexp regexp, boolean atStart, RubyEncoding encoding,
+                @Cached @Exclusive RunTwiceBranchProfile compileProfile) {
             final Object tregex = regexp.tregexCache.getUSASCIIRegex(atStart);
             if (tregex != null) {
                 return tregex;
             } else {
+                compileProfile.enter();
                 return regexp.tregexCache.compile(getContext(), regexp, atStart, encoding, this);
             }
         }
 
         @Specialization(guards = "encoding == ISO_8859_1")
-        Object latin1(RubyRegexp regexp, boolean atStart, RubyEncoding encoding) {
+        Object latin1(RubyRegexp regexp, boolean atStart, RubyEncoding encoding,
+                @Cached @Exclusive RunTwiceBranchProfile compileProfile) {
             final Object tregex = regexp.tregexCache.getLatin1Regex(atStart);
             if (tregex != null) {
                 return tregex;
             } else {
+                compileProfile.enter();
                 return regexp.tregexCache.compile(getContext(), regexp, atStart, encoding, this);
             }
         }
 
         @Specialization(guards = "encoding == UTF_8")
-        Object utf8(RubyRegexp regexp, boolean atStart, RubyEncoding encoding) {
+        Object utf8(RubyRegexp regexp, boolean atStart, RubyEncoding encoding,
+                @Cached @Exclusive RunTwiceBranchProfile compileProfile) {
             final Object tregex = regexp.tregexCache.getUTF8Regex(atStart);
             if (tregex != null) {
                 return tregex;
             } else {
+                compileProfile.enter();
                 return regexp.tregexCache.compile(getContext(), regexp, atStart, encoding, this);
             }
         }
 
         @Specialization(guards = "encoding == BINARY")
-        Object binary(RubyRegexp regexp, boolean atStart, RubyEncoding encoding) {
+        Object binary(RubyRegexp regexp, boolean atStart, RubyEncoding encoding,
+                @Cached @Exclusive RunTwiceBranchProfile compileProfile) {
             final Object tregex = regexp.tregexCache.getBinaryRegex(atStart);
             if (tregex != null) {
                 return tregex;
             } else {
+                compileProfile.enter();
                 return regexp.tregexCache.compile(getContext(), regexp, atStart, encoding, this);
             }
         }

src/main/java/org/truffleruby/core/string/StringNodes.java

@@ -101,6 +101,7 @@
 import org.jcodings.specific.ASCIIEncoding;
 import org.truffleruby.Layouts;
 import org.truffleruby.annotations.CoreMethod;
+import org.truffleruby.annotations.Split;
 import org.truffleruby.builtins.CoreMethodArrayArgumentsNode;
 import org.truffleruby.annotations.CoreModule;
 import org.truffleruby.annotations.Primitive;
@@ -417,7 +418,7 @@ RubyString dupAsStringInstance(Object string,
         }
     }
 
-    @CoreMethod(names = "<<", required = 1, raiseIfNotMutableSelf = true)
+    @CoreMethod(names = "<<", required = 1, raiseIfNotMutableSelf = true, split = Split.ALWAYS)
     @ImportStatic(StringGuards.class)
     public abstract static class StringConcatOneNode extends CoreMethodArrayArgumentsNode {
 

src/main/java/org/truffleruby/utils/RunTwiceBranchProfile.java

@@ -11,6 +11,7 @@
 
 import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.CompilerDirectives.CompilationFinal;
+import com.oracle.truffle.api.dsl.NeverDefault;
 import com.oracle.truffle.api.nodes.NodeCloneable;
 
 public final class RunTwiceBranchProfile extends NodeCloneable {
@@ -29,6 +30,11 @@ public ExecuteCounter next() {
         }
     }
 
+    @NeverDefault
+    public static RunTwiceBranchProfile create() {
+        return new RunTwiceBranchProfile();
+    }
+
     @CompilationFinal private ExecuteCounter executeCounter = ExecuteCounter.NEVER;
 
     public void enter() {