Publish an autoload constant only once

Author: eregon

src/main/java/org/truffleruby/language/AutoloadConstant.java

@@ -71,7 +71,11 @@ public boolean isAutoloadingThreadAndUnset() {
         return isAutoloadingThread() && !hasUnpublishedValue();
     }
 
-    public boolean hasUnpublishedValue() {
+    public boolean shouldPublish() {
+        return hasUnpublishedValue() && !isPublished();
+    }
+
+    private boolean hasUnpublishedValue() {
         assert isAutoloadingThread();
         return unpublishedValue != null;
     }

src/main/java/org/truffleruby/language/constants/GetConstantNode.java

@@ -129,7 +129,7 @@ protected Object autoloadConstant(
             try {
                 callRequireNode.call(coreLibrary().mainObject, "require", feature);
             } finally {
-                if (autoloadConstant.hasUnpublishedValue()) {
+                if (autoloadConstant.shouldPublish()) {
                     autoloadConstant.publish(getContext(), constant);
                 }
             }

src/main/java/org/truffleruby/language/loader/RequireNode.java

@@ -129,7 +129,7 @@ private boolean requireConsideringAutoload(String feature, String expandedPath,
             final List<RubyConstant> releasedConstants = featureLoader.getAutoloadConstants(expandedPath);
             for (RubyConstant constant : releasedConstants) {
                 if (constant.getAutoloadConstant().isAutoloadingThread() && !alreadyAutoloading.contains(constant)) {
-                    if (constant.getAutoloadConstant().hasUnpublishedValue()) {
+                    if (constant.getAutoloadConstant().shouldPublish()) {
                         constant.getAutoloadConstant().publish(getContext(), constant);
                     }