Skip to content

Commit 6c5463e

Browse files
authored
Merge pull request ekristen#541 from apgrucza/apigateway-domainnames-private
fix(apigateway-domainnames): support private apis
2 parents 37c6576 + 50e0b74 commit 6c5463e

File tree

3 files changed

+27
-15
lines changed

3 files changed

+27
-15
lines changed

go.mod

+1
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ require (
3737
github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.6.31 // indirect
3838
github.com/aws/aws-sdk-go-v2/internal/ini v1.8.1 // indirect
3939
github.com/aws/aws-sdk-go-v2/internal/v4a v1.3.27 // indirect
40+
github.com/aws/aws-sdk-go-v2/service/apigateway v1.28.10 // indirect
4041
github.com/aws/aws-sdk-go-v2/service/appsync v1.42.1 // indirect
4142
github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.12.2 // indirect
4243
github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.4.8 // indirect

go.sum

+2
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@ github.com/aws/aws-sdk-go-v2/internal/v4a v1.3.26 h1:GeNJsIFHB+WW5ap2Tec4K6dzcVT
5252
github.com/aws/aws-sdk-go-v2/internal/v4a v1.3.26/go.mod h1:zfgMpwHDXX2WGoG84xG2H+ZlPTkJUU4YUvx2svLQYWo=
5353
github.com/aws/aws-sdk-go-v2/internal/v4a v1.3.27 h1:AmB5QxnD+fBFrg9LcqzkgF/CaYvMyU/BTlejG4t1S7Q=
5454
github.com/aws/aws-sdk-go-v2/internal/v4a v1.3.27/go.mod h1:Sai7P3xTiyv9ZUYO3IFxMnmiIP759/67iQbU4kdmkyU=
55+
github.com/aws/aws-sdk-go-v2/service/apigateway v1.28.10 h1:P8boDrgHS1yivvkKbEzjD9ZvFnCXGVDFJM3vMbLsnWw=
56+
github.com/aws/aws-sdk-go-v2/service/apigateway v1.28.10/go.mod h1:ptFFl07Vr2Ckxf5CnpKwXUDUmcHZiVaVKBxsrI+WVYg=
5557
github.com/aws/aws-sdk-go-v2/service/appsync v1.42.1 h1:LHvnj7gkCWDa2j+USYtC5pLLIZfuBCfJRUjk0S1cA30=
5658
github.com/aws/aws-sdk-go-v2/service/appsync v1.42.1/go.mod h1:cILlhPBarV3U76C3W2jR2FOF4uh24kWCAQXEGT31r6s=
5759
github.com/aws/aws-sdk-go-v2/service/iam v1.38.3 h1:2sFIoFzU1IEL9epJWubJm9Dhrn45aTNEJuwsesaCGnk=

resources/apigateway-domainnames.go

+24-15
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@ package resources
33
import (
44
"context"
55

6-
"github.com/aws/aws-sdk-go/aws"
7-
"github.com/aws/aws-sdk-go/service/apigateway"
6+
"github.com/aws/aws-sdk-go-v2/aws"
7+
"github.com/aws/aws-sdk-go-v2/service/apigateway"
88

99
"github.com/ekristen/libnuke/pkg/registry"
1010
"github.com/ekristen/libnuke/pkg/resource"
11+
"github.com/ekristen/libnuke/pkg/types"
1112

1213
"github.com/ekristen/aws-nuke/v3/pkg/nuke"
1314
)
@@ -25,25 +26,27 @@ func init() {
2526

2627
type APIGatewayDomainNameLister struct{}
2728

28-
func (l *APIGatewayDomainNameLister) List(_ context.Context, o interface{}) ([]resource.Resource, error) {
29+
func (l *APIGatewayDomainNameLister) List(ctx context.Context, o interface{}) ([]resource.Resource, error) {
2930
opts := o.(*nuke.ListerOpts)
30-
svc := apigateway.New(opts.Session)
31+
svc := apigateway.NewFromConfig(*opts.Config)
3132
var resources []resource.Resource
3233

3334
params := &apigateway.GetDomainNamesInput{
34-
Limit: aws.Int64(100),
35+
Limit: aws.Int32(100),
3536
}
3637

3738
for {
38-
output, err := svc.GetDomainNames(params)
39+
output, err := svc.GetDomainNames(ctx, params)
3940
if err != nil {
4041
return nil, err
4142
}
4243

43-
for _, item := range output.Items {
44+
for i := range output.Items {
45+
item := &output.Items[i]
4446
resources = append(resources, &APIGatewayDomainName{
45-
svc: svc,
46-
domainName: item.DomainName,
47+
svc: svc,
48+
DomainName: item.DomainName,
49+
DomainNameID: item.DomainNameId,
4750
})
4851
}
4952

@@ -58,18 +61,24 @@ func (l *APIGatewayDomainNameLister) List(_ context.Context, o interface{}) ([]r
5861
}
5962

6063
type APIGatewayDomainName struct {
61-
svc *apigateway.APIGateway
62-
domainName *string
64+
svc *apigateway.Client
65+
DomainName *string
66+
DomainNameID *string
6367
}
6468

65-
func (f *APIGatewayDomainName) Remove(_ context.Context) error {
66-
_, err := f.svc.DeleteDomainName(&apigateway.DeleteDomainNameInput{
67-
DomainName: f.domainName,
69+
func (f *APIGatewayDomainName) Remove(ctx context.Context) error {
70+
_, err := f.svc.DeleteDomainName(ctx, &apigateway.DeleteDomainNameInput{
71+
DomainName: f.DomainName,
72+
DomainNameId: f.DomainNameID,
6873
})
6974

7075
return err
7176
}
7277

78+
func (f *APIGatewayDomainName) Properties() types.Properties {
79+
return types.NewPropertiesFromStruct(f)
80+
}
81+
7382
func (f *APIGatewayDomainName) String() string {
74-
return *f.domainName
83+
return *f.DomainName
7584
}

0 commit comments

Comments
 (0)