Replies: 6 comments 5 replies
-
Beta Was this translation helpful? Give feedback.
-
@auniverseaway I looked at the breadcrumbs which is in the global navigation, with the CLS angle, but I may need some more pointers on how a consumer block trying to place some elements above GNAV can resolve potential issues, please. |
Beta Was this translation helpful? Give feedback.
-
Hi @narcis-radu, @overmyheadandbody, @mokimo Thanks for the excellent session on GNAV deep dive. I am trying to still catch up with the recording from where I left the meeting. This is the app banner I am building for DC which I was talking about during the GNAV presentation/QA. I understand that you are still working on some strategy for consumers to mitigate such CLS issues when they want to push their block above GNAV etc. Please let me know if I can try out any ideas. cc: @Blainegunn |
Beta Was this translation helpful? Give feedback.
-
This is my first block in DC using Milo :), though I am still working on the unit tests and potential CLS issue, but may I request everyone to provide your valuable feedback esp. CSS styling and performance, please ? https://github.com/adobecom/dc/compare/stage...puruadobe:dc:puru/MWPW-123236?expand=1 https://puru-mwpw-123236--dc--puruadobe.hlx.page/drafts/doreswam/acrobat-banner --> banner visible only on mobile devices cc: @Blainegunn |
Beta Was this translation helpful? Give feedback.
-
With regards to CLS concerns, currently on my local I see a CLS score of 0.042, for this page https://puru-mwpw-123236--dc--puruadobe.hlx.page/drafts/doreswam/acrobat-banner, which seems to be not bad. |
Beta Was this translation helpful? Give feedback.
-
Hi @puruadobe! Ideally the app banner would have a predefined height regardless of its content. Is that the case? As @auniverseaway was mentioning, a breadcrumb-like strategy might come in handy here - https://github.com/adobecom/milo/blob/main/libs/styles/styles.css#L71-L72. Assuming the App Banner is a block on the page and has a predetermined height (or maybe 2 variants between mobile and desktop), we could potentially define a new height for a |
Beta Was this translation helpful? Give feedback.
-
At DC we have a requirement [0] to migrate the app banner feature to DC/Milo. Currently this feature is set up in AEM using branch.io third party integration. PoC for the integration with branch.io and DC/Milo for your reference [1]
Branch.io setup steps:
Pros:
Cons:
Another option is to use Milo personalization (MEP) [3]
Steps:
Pros:
Cons:
[0] https://jira.corp.adobe.com/browse/MWPW-123236
[1] https://mwpw-123236--dc--puruadobe.hlx.page/drafts/doreswam/word-to-pdf?_branch_view_id=1224075380893961221
[2] https://adobe.dashboard.branch.io/journeys/manager
[3] https://milo.adobe.com/docs/authoring/features/personalization
Suggestions/comments/guidance are welcome.
cc: @chrischrischris , @vivgoodrich , @Blainegunn , @auniverseaway
Beta Was this translation helpful? Give feedback.
All reactions