[2023-04-24] GUI Team Demo Day

[wdanilo]

Last week I implemented several things:

1. The List Editor was almost* (see point 2) finished - it allows now for adding elements and its internal API was finished to deliver information about all changes made in GUI and via API.

Screen.Recording.2023-04-24.at.13.36.51.mov

2. I discovered that our slider widget has bugs and does not use modern EnsoGL functionality. I updated it to test the List Editor interaction with widgets. The one thing missing from List Editor is proper passing events to sub-widgets, like sliders. I will finish fixing slider and finishing this events handling in List Editor the next day (I'm almost there).

3. I fixed several small bugs in the application and I also spent a lot of time with different people on solving issues / planning the work.

[farmaazon]

Added a method to WASM file which drops all structures. All resources are freed, the visuals disappears and connections are closed.

While implementing I fixed leaks in several places (not noticed before, because we actually never dropped Graph Editor). I fixed them, and left in the codebase helper structures for tracking leaks. For example, if I see my FRP network is leaking (with all stuff captured), I may add leak_detector::Trace field to it:

#[derive(Clone, CloneRef, Debug)]
pub struct Network {
    data: Rc<NetworkData>,
    pub trace: leak_detector::Trace,
}

Then we enable a concrete network we want to check:

    frp.network().trace.enable();

In drop function we have a code checking if any Trace structure persisted dropping the entire application. If yes, the backtraces of their creation (both by direct instantiation or by cloning-ref existing object) are printed.

#[wasm_bindgen]
pub fn drop() {
    IDE.with(RefCell::take);
    EXECUTOR.with(RefCell::take);
    leak_detector::TRACKED_OBJECTS.with(|objects| {
        let objects = objects.borrow();
        if !objects.is_empty() {
            error!("Tracked objects leaked after dropping entire application!");
            error!("Leaked objects: {objects:#?}");
        }
    })
}

[JaroslavTulach]

Engine performance:

• Async Language Server resources initialization  #6336
  • Speeds up session/InitProtocolConnection request by ~300ms (~10%) 3051ms vs 2740ms
• Removing need for asynchronous thread to execute ResourceManager finalizers #6335
• Looking into why the cascade of <| functions is slow - Improve inlining of <| on (GraalVM EE) #6384
  • Followup PoC: Speed functions like <| up without forcing it to be builtin #6394
• Resolving issue where warnings are massively duplicated - Report only unique warnings #6372
• Any.== should check for Meta.is_same_object as the first step #6065

[vitvakatu]

Last week:

1. Read-only mode for controllers #6259 got merged after a bug fix on the engine side.
2. Read-only mode implementation finished with Forbid edits in read-only mode #6342, merged today.
3. Fixed the issue Visualization displayed in the wrong place while interacting with Component Browser #6158 (and introduced Scrolling in the Documentation Panel is not working #6385, which is currently WIP)
4. Investigated a bug Last named argument gets doubled when the first argument is removed #6228, this is still ongoing.

Read-only mode forbids certain actions in the GUI:

2023-04-18.18-23-23.mp4

[kazcw]

Completed:

• Fixed build failures caused by Invalid WASM modules, apparently size-related #6315.
• Fixed Join throws many "GL errors" #6320, caused by logic bug from 2019.
• Fixed Exclude comparison operators from modifier logic #6370 bug. Debugged a side issue, found needed backend functionality (MethodCall info for infix operators #6374).

Current:

• Component Browser Icons are not on an external screen with different zoom level in Windows 11 Pro #6125: I think this is caused by improper use of framebuffer/texture APIs.
  • I've found a couple issues with our API usage, but not what causes this.
  • I'm going to fix it by switching to the "Immutable" API for the persistent framebuffer--Khronos recommends using it because the "Mutable" API is so hard to use correctly.

Next:

• Continue the bug hunt.

[mwu-tow]

1. Replaced the code signing certificate for Windows. It expired last week, so needed to be replaced with the new one. Runners and CI configuration has been updated accordingly.
2. Finishing URL handling PR: code review fixes, further cross-platform testing, fixing the window focus issue. URL handling #6243 (there are still rough edges caused by Hiding Windows console during Enso launch  #6360)
3. Fixing issue with project opening on macOS. .enso-project is not unpacking the project automatically to enso directory on MacOS #6362

[wdanilo]

4. PRs that are not up to date against develop but can be trivially merged, are mergable now, so you can merge them without waiting for CI again.

[Procrat]

1. I changed our project initialisation to show a spinner whenever we're in the process of opening a project (including creating a new one or switching). Show spinner when opening/creating a project #6321

spinner3.mp4

2. When the user is trying to rename the project to an invalid name, it now shows an error pop-up and stays in edit mode. Show error pop-up when failing to rename a project #6366

space3.mp4

[Frizi]

Continued work on widgets on nodes. The PR has been reviewed and I'm in process of fixing requested changes.

• Fixed remaining issues with edge drawing and updates
• Implemented support for multiple widgets being attached to the same span tree node, used that to deduplicate text rendering code between label and dropdown
• Finished edge drag handling and implemented different hover area sizes for widgets at different level
• Discovered and fixed a performance regression caused by reintroduced eager initialization of dropdowns