Implementing support for downloading transcoded files

[AlexS54]

Hello

I'm looking to implement https://features.jellyfin.org/posts/57/support-download-of-transcoded-files

I'm planning to maybe wrap VideosController.GetVideoStream() / AudioController.GetAudioStream, however I noticed the transcoding (specifically the ffmpeg args) are built differently in VideosController vs in DynamicHlsController, which is what the web client calls. I know this is largely because how HLS works vs just streaming the whole file, however there are inconsistencies in other places, for example in EncodingHelper.GetProgressiveVideoFullCommandLine() if the videoCodec is "copy", bitrate and audio mixing arguments are ignored, so how should I approach this (I don't have a lot of experience with ffmpeg)?

Another question I have is where to add this route? (in the <Videos/Audio>Controller, or in LibraryController, where the other download route is. I'm assuming LibraryController, but then to wrap the methods in the other controllers, where should I move them to reuse the logic? (I don't think a dependency between controllers is desired)

Thanks

[sjorge]

You probably want to open the discussion here https://github.com/jellyfin/jellyfin-meta/discussions

[AlexS54]

Thanks, moving it there

New location: jellyfin/jellyfin-meta#115