You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 17, 2025. It is now read-only.
/usr/bin/cp is an invalid variable name which means we can't have dictionaries under otk.define with keys that include those characters. It also means we can't have dictionaries with keys that start with numbers.
This might become a problem with content hashes used as object keys in defines, which we might need to use at some point.
It seems to me if we want to open this up we probably need to design this a bit more to ensure we are happy with the result.
As a quick strawman: IMHO we should still restrict vars like they are right now, I am worried about confusion from content like ${a-b} if we are too free with the variable names. However we could reconsider the dot notation and allow something like ${a["b-c"]} or ${selinux_labels["/usr/bin/foo"]} or ${packages.versions["my-kernel"]} or ${package.versions[${modifications.kernel}]} - it feels nice but it will be extra work implementing this carefully (and thinking/ensuring we design something that is not painting us into a corner down the line).
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
/usr/bin/cp
is an invalid variable name which means we can't have dictionaries underotk.define
with keys that include those characters. It also means we can't have dictionaries with keys that start with numbers.This might become a problem with content hashes used as object keys in defines, which we might need to use at some point.
Originally posted by @achilleas-k in #210 (comment)
The text was updated successfully, but these errors were encountered: