CMake/Github action: Modernize

Author: joto

.github/workflows/ci.yml

@@ -23,51 +23,33 @@ jobs:
         build_type: [Dev]
         cpp_compiler: [g++]
         include:
-          - image: "ubuntu:22.04"
-            CXXFLAGS: -Wno-stringop-overread -Wno-array-bounds
-          - image: "ubuntu:24.04"
-            CXXFLAGS: -Wno-stringop-overread -Wno-array-bounds
-          - image: "debian:bookworm"
-            CXXFLAGS: -Wno-stringop-overread -Wno-array-bounds
           - image: "debian:bookworm"
             c_compiler: clang
             cpp_compiler: clang++
-          - image: "debian:bookworm"
-            build_type: RelWithDebInfo
-          - image: "debian:trixie"
-            CXXFLAGS: -Wno-stringop-overread -Wno-array-bounds
           - image: "debian:trixie"
             c_compiler: clang
             cpp_compiler: clang++
           - image: "debian:trixie"
             build_type: RelWithDebInfo
-            CXXFLAGS: -Wno-stringop-overread -Wno-array-bounds
-          - image: "debian:testing"
-            CXXFLAGS: -Wno-stringop-overread -Wno-array-bounds -Wno-maybe-uninitialized
+          - image: "debian:trixie"
+            c_compiler: clang
+            cpp_compiler: clang++
+            CXXFLAGS: -fsanitize=address,undefined -fno-sanitize-recover=all -fno-omit-frame-pointer
+            LDFLAGS: -fsanitize=address,undefined
           - image: "debian:testing"
             c_compiler: clang
             cpp_compiler: clang++
-          - image: "debian:experimental"
-            CXXFLAGS: -Wno-stringop-overread -Wno-array-bounds -Wno-maybe-uninitialized
           - image: "debian:experimental"
             c_compiler: clang
             cpp_compiler: clang++
-          - image: "fedora:40"
-            CXXFLAGS: -Wno-stringop-overread -Wno-array-bounds
-          - image: "fedora:41"
-            CXXFLAGS: -Wno-stringop-overread -Wno-array-bounds
-          - image: "fedora:42"
-            CXXFLAGS: -Wno-stringop-overread -Wno-array-bounds -Wno-maybe-uninitialized
-          - image: "fedora:43"
-            CXXFLAGS: -Wno-stringop-overread -Wno-array-bounds -Wno-maybe-uninitialized
     container:
       image: ${{ matrix.image }}
       env:
         LANG: en_US.UTF-8
         BUILD_TYPE: ${{ matrix.build_type }}
         CC: ${{ matrix.c_compiler }}
         CXX: ${{ matrix.cpp_compiler }}
-        CXXFLAGS: ${{ matrix.CXXFLAGS }}
+        CXXFLAGS: -Werror ${{ matrix.CXXFLAGS }}
         LDFLAGS: ${{ matrix.LDFLAGS }}
         APT_LISTCHANGES_FRONTEND: none
         DEBIAN_FRONTEND: noninteractive
@@ -90,10 +72,6 @@ jobs:
             libsqlite3-dev \
             make \
             zlib1g-dev
-      - name: Install compiler
-        shell: bash
-        if: matrix.cpp_compiler == 'clang++-14'
-        run: apt-get install -yq clang-14
       - name: Prepare container (dnf)
         shell: bash
         if: startsWith(matrix.image, 'fedora:')
@@ -122,6 +100,7 @@ jobs:
     env:
       CC: clang-18
       CXX: clang++-18
+      CXXFLAGS: -Werror
       BUILD_TYPE: Dev
     steps:
       - uses: actions/checkout@v4
@@ -147,6 +126,7 @@ jobs:
     env:
       CC: clang
       CXX: clang++
+      CXXFLAGS: -Werror
       BUILD_TYPE: ${{ matrix.build_type }}
     steps:
       - uses: actions/checkout@v4

CMakeLists.txt

@@ -71,6 +71,10 @@ if(CMAKE_BUILD_TYPE STREQUAL "Dev")
     add_definitions(${OSMIUM_WARNING_OPTIONS})
 endif()
 
+if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
+    add_definitions(-Wno-stringop-overread)
+endif()
+
 # Force RelWithDebInfo build type if none was given
 if(CMAKE_BUILD_TYPE)
     set(build_type ${CMAKE_BUILD_TYPE})