clang-tidy: array-to-pointer decay happens only in one place

disable it there

Author: joto

.clang-tidy

@@ -12,14 +12,12 @@ Checks:
   - '-bugprone-easily-swappable-parameters'  # Can't do much about this in many places.
   - '-cppcoreguidelines-avoid-c-arrays'  # Makes sense for some arrays, but especially for char arrays using std::array isn't a good solution.
   - '-cppcoreguidelines-avoid-magic-numbers'  # Generally good advice, but there are too many places where this is useful, for instance in tests.
-  - '-cppcoreguidelines-pro-bounds-array-to-pointer-decay'  # Limited use and many false positives including for all asserts.
   - '-cppcoreguidelines-pro-bounds-constant-array-index'  # Don't want to add dependency on gsl library.
   - '-cppcoreguidelines-pro-bounds-pointer-arithmetic'  # Difficult to get by without it...
   - '-cppcoreguidelines-pro-type-static-cast-downcast'  # This is needed and totally okay if we are sure about the types.
   - '-cppcoreguidelines-pro-type-vararg'  # Sometimes calling vararg functions is necessary.
   - '-fuchsia-*'  # Much too strict.
   - '-hicpp-avoid-c-arrays'  # Makes sense for some arrays, but especially for char arrays using std::array isn't a good solution.
-  - '-hicpp-no-array-decay'  # Limited use and many false positives including for all asserts.
   - '-hicpp-vararg'  # Sometimes calling vararg functions is necessary.
   - '-llvm-prefer-static-over-anonymous-namespace'  # Matter of taste and we are not following this one.
   - '-llvmlibc-*'  # Not applicable.

src/command_show.cpp

@@ -154,7 +154,7 @@ namespace {
 
 int execute_pager(const std::string& pager, bool with_color) {
     int pipefd[2];
-    if (::pipe(pipefd) < 0) {
+    if (::pipe(pipefd) < 0) { // NOLINT(cppcoreguidelines-pro-bounds-array-to-pointer-decay,hicpp-no-array-decay)
         throw std::system_error{errno, std::system_category(), "Could not run pager: pipe() call failed"};
     }