Overlapping edge check bug fix. (#268)

* OverlappingEdgeCheck, marking overlapping edges on atlas identifier instead of osm identifier.

* OverlappingEdgeCheck, replacing getIdentifier with getOsmIdentifier for localized instruction.

* OverlappingEdgeCheck, replacing way Ids list to contain atlas identifiers.

Co-authored-by: sugandhi <[email protected]>

Author: smaheshwaram

src/main/java/org/openstreetmap/atlas/checks/validation/linear/edges/OverlappingEdgeCheck.java

@@ -78,7 +78,7 @@ public boolean validCheckForObject(final AtlasObject object)
     @Override
     protected Optional<CheckFlag> flag(final AtlasObject object)
     {
-        if (!this.isFlagged(object.getOsmIdentifier()))
+        if (!this.isFlagged(object.getIdentifier()))
         {
             final Atlas atlas = object.getAtlas();
             final Set<AtlasObject> overlappingItems = new HashSet<>();
@@ -103,10 +103,10 @@ protected Optional<CheckFlag> flag(final AtlasObject object)
             }
             if (!overlappingItems.isEmpty())
             {
-                this.markAsFlagged(object.getOsmIdentifier());
+                this.markAsFlagged(object.getIdentifier());
                 // Mark overlapping objects as flagged
                 overlappingItems
-                        .forEach(overlapEdge -> this.markAsFlagged(overlapEdge.getOsmIdentifier()));
+                        .forEach(overlapEdge -> this.markAsFlagged(overlapEdge.getIdentifier()));
                 final CheckFlag flag = this.createFlag(overlappingItems,
                         this.getLocalizedInstruction(0, object.getOsmIdentifier(),
                                 new StringList(osmIdentifiers(overlappingItems)).join(", ")));
@@ -198,7 +198,7 @@ private boolean isPartOfClosedWay(final Edge object)
 
     private Predicate<Edge> notIn(final AtlasObject object)
     {
-        return edge -> !this.isFlagged(object.getOsmIdentifier());
+        return edge -> !this.isFlagged(object.getIdentifier());
     }
 
     /**