Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Not working with Cookiebot? #7

Open
Discostu36 opened this issue May 31, 2021 · 5 comments
Open

Not working with Cookiebot? #7

Discostu36 opened this issue May 31, 2021 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@Discostu36
Copy link

Doesn't seem to work with Cookiebot, at least not when slide-up function is used as on https://www.voffice.pro

@Discostu36
Copy link
Author

The banner always has id="CybotCookiebotDialog", should be an easy fix.

@otsmr
Copy link
Owner

otsmr commented May 31, 2021

That's right, you could simply remove it via a block list. But this is not the goal of the project.

The banner is actually even recognized by the function "removeCookieBanner". The problem is that the element itself has other childelements, which are also position fixed, so the banner will not removed:

https://github.com/otsmr/cookie-banner-blocker/blob/main/content/detect.js#L100

        let childrenWithFixed = findElementByCssRule("position", null, e => e === "fixed" || e === "absolute", fixedElement)
        if (childrenWithFixed.length > 0) return;

This if-condition was made because, as in #2, whole pages were often removed because position fixed was used in the main-div.

@otsmr otsmr added the bug Something isn't working label May 31, 2021
@otsmr otsmr self-assigned this May 31, 2021
@Discostu36
Copy link
Author

That's right, you could simply remove it via a block list. But this is not the goal of the project.

I understand that you don't want to create and maintain a blocklist for websites, but maybe one for the most common cookie banner plug-ins could be considered?

@otsmr
Copy link
Owner

otsmr commented May 31, 2021

Yes, the thing is that there are already very good addons for this and these also already have "CybotCookiebotDialog" on the list.

I personally use uBlock Origin for this. There are already a lot of such cookie banner lists under "Filterlisten" > "Belästigungen".

The goal of this addon is really only to detect "new" banners, or also banners where you are redirected (like at golem.de).

@Discostu36
Copy link
Author

I understand. I am using uBlock Origin but didn't know it can also be used for cookie banners. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants