Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding conditional monge gap #605

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

DriessenA
Copy link

For now we've only implemented cmonge_gap_from_samples, we will follow with a ConditionalMongeGapEstimator.

@marcocuturi marcocuturi marked this pull request as ready for review January 29, 2025 18:03
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 75 lines in your changes missing coverage. Please review.

Project coverage is 87.06%. Comparing base (e6fff13) to head (b94fef6).

Files with missing lines Patch % Lines
...eural/networks/conditional_perturbation_network.py 0.00% 45 Missing ⚠️
src/ott/neural/methods/conditional_monge_gap.py 0.00% 30 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #605      +/-   ##
==========================================
- Coverage   87.91%   87.06%   -0.86%     
==========================================
  Files          74       76       +2     
  Lines        7657     7731      +74     
  Branches      533      539       +6     
==========================================
- Hits         6732     6731       -1     
- Misses        783      858      +75     
  Partials      142      142              
Files with missing lines Coverage Δ
src/ott/neural/methods/conditional_monge_gap.py 0.00% <0.00%> (ø)
...eural/networks/conditional_perturbation_network.py 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant