Skip to content

Commit f9c1a85

Browse files
committed
replace QComboBox with ListWidget because the ComboBox crashed when adding items after a clear
1 parent 907b22c commit f9c1a85

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

app/gui/key_rotation_dialog.py

+3-5
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
from PyQt6.QtCore import Qt
44
from PyQt6.QtWidgets import QDialog, QLabel, QApplication, QHBoxLayout, QVBoxLayout, \
5-
QPushButton, QComboBox
5+
QPushButton, QListWidget
66

77
if TYPE_CHECKING:
88
from gui.gui import Gui
@@ -19,7 +19,7 @@ def __init__(self, parent=None):
1919

2020
self.resize(self.width, self.height)
2121

22-
self.access_key_selection = QComboBox()
22+
self.access_key_selection = QListWidget()
2323

2424
self.text = QLabel("This will create a new key and delete the old one!", self)
2525
self.text.setStyleSheet('color: rgb(255, 0, 0);')
@@ -43,7 +43,7 @@ def __init__(self, parent=None):
4343
self.installEventFilter(self)
4444

4545
def ok(self):
46-
selected_key = self.access_key_selection.currentText()
46+
selected_key = self.access_key_selection.currentItem().text()
4747
self.gui.rotate_access_key(key_name=selected_key)
4848
self.hide()
4949

@@ -63,9 +63,7 @@ def keyPressEvent(self, event):
6363
self.cancel()
6464

6565
def show_dialog(self, access_key_list: List[str]):
66-
self.access_key_selection.blockSignals(True)
6766
self.access_key_selection.clear()
68-
self.access_key_selection.blockSignals(False)
6967
for access_key in access_key_list:
7068
self.access_key_selection.addItem(access_key)
7169
self.show()

0 commit comments

Comments
 (0)