Skip to content

Commit 648cad3

Browse files
committed
Address some cppcheck complaints
1 parent b0b459d commit 648cad3

File tree

4 files changed

+1
-6
lines changed

4 files changed

+1
-6
lines changed

examples/multiprocess_c/multi.c

-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ int main (int argc, char **argv)
9797
{
9898
int ret;
9999
const char *error = NULL;
100-
int i = 0;
101100
pid_t pid;
102101
int f;
103102

src/engine/lua.cc

-1
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,6 @@ int Lua::setvar(lua_State *L) {
329329
std::string collection;
330330
std::string variableName;
331331
int nargs = lua_gettop(L);
332-
char *chr = NULL;
333332
size_t pos;
334333
void *z(NULL);
335334

test/cppcheck_suppressions.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ passedByValue:src/variables/global.h:110
6464
passedByValue:src/parser/driver.cc:45
6565
passedByValue:test/common/modsecurity_test.cc:49
6666
passedByValue:test/common/modsecurity_test.cc:98
67+
unreadVariable:src/rule_with_operator.cc:219
6768

6869
uninitvar:src/operators/verify_cpf.cc:77
6970
uninitvar:src/operators/verify_svnr.cc:67
@@ -91,7 +92,6 @@ cstyleCast
9192
functionStatic
9293
variableScope
9394
shadowFunction
94-
unreadVariable
9595

9696

9797
// Examples

test/optimization/optimization.cc

-3
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ int main(int argc, char **argv) {
8383

8484
for (int i = 0; i < rules->size(); i++) {
8585
auto z = rules->at(i);
86-
std::string key;
8786
if (z == NULL) {
8887
continue;
8988
}
@@ -95,7 +94,6 @@ int main(int argc, char **argv) {
9594
} else {
9695
operators[op] = 1;
9796
}
98-
key = op;
9997
}
10098

10199
if (dynamic_cast<modsecurity::RuleWithOperator *>(z.get()) != nullptr) {
@@ -107,7 +105,6 @@ int main(int argc, char **argv) {
107105
} else {
108106
operators[op] = 1;
109107
}
110-
key = op;
111108
}
112109

113110
}

0 commit comments

Comments
 (0)