Skip to content

Commit 9d890f5

Browse files
phil-davisphil-davis
authored
Merge pull request #33128 from owncloud/stable10-acceptance-test-tag-public_link_share
[stable10] Acceptance test tag public link share
2 parents ce7d1d1 + f3682e8 commit 9d890f5

File tree

14 files changed

+63
-55
lines changed

14 files changed

+63
-55
lines changed

‎tests/acceptance/features/apiCapabilities/capabilities.feature

Lines changed: 10 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,17 @@ Feature: capabilities
4949
| files_sharing | user_enumeration@@@enabled | 1 |
5050
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
5151
| files | bigfilechunking | 1 |
52+
53+
@files_trashbin-app-required
54+
Scenario: getting trashbin app capability with admin user
55+
When the administrator retrieves the capabilities using the capabilities API
56+
Then the capabilities should contain
5257
| files | undelete | 1 |
58+
59+
@files_versions-app-required
60+
Scenario: getting versions app capability with admin user
61+
When the administrator retrieves the capabilities using the capabilities API
62+
Then the capabilities should contain
5363
| files | versioning | 1 |
5464

5565
#feature added in #31824 will be released in 10.0.10
@@ -123,8 +133,6 @@ Feature: capabilities
123133
| files_sharing | user_enumeration@@@enabled | 1 |
124134
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
125135
| files | bigfilechunking | 1 |
126-
| files | undelete | 1 |
127-
| files | versioning | 1 |
128136

129137
Scenario: Disabling share api
130138
Given parameter "shareapi_enabled" of app "core" has been set to "no"
@@ -141,8 +149,6 @@ Feature: capabilities
141149
| files_sharing | federation@@@outgoing | 1 |
142150
| files_sharing | federation@@@incoming | 1 |
143151
| files | bigfilechunking | 1 |
144-
| files | undelete | 1 |
145-
| files | versioning | 1 |
146152

147153
Scenario: Disabling public links
148154
Given parameter "shareapi_allow_links" of app "core" has been set to "no"
@@ -163,8 +169,6 @@ Feature: capabilities
163169
| files_sharing | user_enumeration@@@enabled | 1 |
164170
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
165171
| files | bigfilechunking | 1 |
166-
| files | undelete | 1 |
167-
| files | versioning | 1 |
168172

169173
Scenario: Changing resharing
170174
Given parameter "shareapi_allow_resharing" of app "core" has been set to "no"
@@ -187,8 +191,6 @@ Feature: capabilities
187191
| files_sharing | user_enumeration@@@enabled | 1 |
188192
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
189193
| files | bigfilechunking | 1 |
190-
| files | undelete | 1 |
191-
| files | versioning | 1 |
192194

193195
Scenario: Changing federation outgoing
194196
Given parameter "outgoing_server2server_share_enabled" of app "files_sharing" has been set to "no"
@@ -211,8 +213,6 @@ Feature: capabilities
211213
| files_sharing | user_enumeration@@@enabled | 1 |
212214
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
213215
| files | bigfilechunking | 1 |
214-
| files | undelete | 1 |
215-
| files | versioning | 1 |
216216

217217
Scenario: Changing federation incoming
218218
Given parameter "incoming_server2server_share_enabled" of app "files_sharing" has been set to "no"
@@ -235,8 +235,6 @@ Feature: capabilities
235235
| files_sharing | user_enumeration@@@enabled | 1 |
236236
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
237237
| files | bigfilechunking | 1 |
238-
| files | undelete | 1 |
239-
| files | versioning | 1 |
240238

241239
Scenario: Changing "password enforced for read-only public link shares"
242240
Given parameter "shareapi_enforce_links_password_read_only" of app "core" has been set to "yes"
@@ -262,8 +260,6 @@ Feature: capabilities
262260
| files_sharing | user_enumeration@@@enabled | 1 |
263261
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
264262
| files | bigfilechunking | 1 |
265-
| files | undelete | 1 |
266-
| files | versioning | 1 |
267263

268264
Scenario: Changing "password enforced for read-write public link shares"
269265
Given parameter "shareapi_enforce_links_password_read_write" of app "core" has been set to "yes"
@@ -289,8 +285,6 @@ Feature: capabilities
289285
| files_sharing | user_enumeration@@@enabled | 1 |
290286
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
291287
| files | bigfilechunking | 1 |
292-
| files | undelete | 1 |
293-
| files | versioning | 1 |
294288

295289
Scenario: Changing "password enforced for write-only public link shares"
296290
Given parameter "shareapi_enforce_links_password_write_only" of app "core" has been set to "yes"
@@ -316,8 +310,6 @@ Feature: capabilities
316310
| files_sharing | user_enumeration@@@enabled | 1 |
317311
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
318312
| files | bigfilechunking | 1 |
319-
| files | undelete | 1 |
320-
| files | versioning | 1 |
321313

322314
Scenario: Changing public notifications
323315
Given parameter "shareapi_allow_public_notification" of app "core" has been set to "yes"
@@ -340,8 +332,6 @@ Feature: capabilities
340332
| files_sharing | user_enumeration@@@enabled | 1 |
341333
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
342334
| files | bigfilechunking | 1 |
343-
| files | undelete | 1 |
344-
| files | versioning | 1 |
345335

346336
Scenario: Changing public social share
347337
Given parameter "shareapi_allow_social_share" of app "core" has been set to "no"
@@ -364,8 +354,6 @@ Feature: capabilities
364354
| files_sharing | user_enumeration@@@enabled | 1 |
365355
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
366356
| files | bigfilechunking | 1 |
367-
| files | undelete | 1 |
368-
| files | versioning | 1 |
369357

370358
Scenario: Changing expire date
371359
Given parameter "shareapi_default_expire_date" of app "core" has been set to "yes"
@@ -389,8 +377,6 @@ Feature: capabilities
389377
| files_sharing | user_enumeration@@@enabled | 1 |
390378
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
391379
| files | bigfilechunking | 1 |
392-
| files | undelete | 1 |
393-
| files | versioning | 1 |
394380

395381
Scenario: Changing expire date enforcing
396382
Given parameter "shareapi_default_expire_date" of app "core" has been set to "yes"
@@ -416,8 +402,6 @@ Feature: capabilities
416402
| files_sharing | user_enumeration@@@enabled | 1 |
417403
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
418404
| files | bigfilechunking | 1 |
419-
| files | undelete | 1 |
420-
| files | versioning | 1 |
421405

422406
Scenario: Changing group sharing allowed
423407
Given parameter "shareapi_allow_group_sharing" of app "core" has been set to "no"
@@ -440,8 +424,6 @@ Feature: capabilities
440424
| files_sharing | user_enumeration@@@enabled | 1 |
441425
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
442426
| files | bigfilechunking | 1 |
443-
| files | undelete | 1 |
444-
| files | versioning | 1 |
445427

446428
Scenario: Changing only share with group member
447429
Given parameter "shareapi_only_share_with_group_members" of app "core" has been set to "yes"
@@ -464,8 +446,6 @@ Feature: capabilities
464446
| files_sharing | user_enumeration@@@enabled | 1 |
465447
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
466448
| files | bigfilechunking | 1 |
467-
| files | undelete | 1 |
468-
| files | versioning | 1 |
469449

470450
Scenario: Changing allow share dialog user enumeration
471451
Given parameter "shareapi_allow_share_dialog_user_enumeration" of app "core" has been set to "no"
@@ -487,8 +467,6 @@ Feature: capabilities
487467
| files_sharing | share_with_group_members_only | EMPTY |
488468
| files_sharing | user_enumeration@@@enabled | EMPTY |
489469
| files | bigfilechunking | 1 |
490-
| files | undelete | 1 |
491-
| files | versioning | 1 |
492470

493471
Scenario: Changing allow share dialog user enumeration for group members only
494472
Given parameter "shareapi_share_dialog_user_enumeration_group_members" of app "core" has been set to "yes"
@@ -511,8 +489,6 @@ Feature: capabilities
511489
| files_sharing | user_enumeration@@@enabled | 1 |
512490
| files_sharing | user_enumeration@@@group_members_only | 1 |
513491
| files | bigfilechunking | 1 |
514-
| files | undelete | 1 |
515-
| files | versioning | 1 |
516492

517493
Scenario: Changing exclude groups from sharing
518494
Given parameter "shareapi_exclude_groups" of app "core" has been set to "yes"
@@ -539,8 +515,6 @@ Feature: capabilities
539515
| files_sharing | user_enumeration@@@enabled | 1 |
540516
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
541517
| files | bigfilechunking | 1 |
542-
| files | undelete | 1 |
543-
| files | versioning | 1 |
544518

545519
Scenario: When in a group that is excluded from sharing, can_share is off
546520
Given parameter "shareapi_exclude_groups" of app "core" has been set to "yes"
@@ -570,8 +544,6 @@ Feature: capabilities
570544
| files_sharing | user_enumeration@@@enabled | 1 |
571545
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
572546
| files | bigfilechunking | 1 |
573-
| files | undelete | 1 |
574-
| files | versioning | 1 |
575547

576548
Scenario: When not in any group that is excluded from sharing, can_share is on
577549
Given parameter "shareapi_exclude_groups" of app "core" has been set to "yes"
@@ -601,8 +573,6 @@ Feature: capabilities
601573
| files_sharing | user_enumeration@@@enabled | 1 |
602574
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
603575
| files | bigfilechunking | 1 |
604-
| files | undelete | 1 |
605-
| files | versioning | 1 |
606576

607577
Scenario: When in a group that is excluded from sharing and in another group, can_share is off
608578
Given parameter "shareapi_exclude_groups" of app "core" has been set to "yes"
@@ -633,5 +603,3 @@ Feature: capabilities
633603
| files_sharing | user_enumeration@@@enabled | 1 |
634604
| files_sharing | user_enumeration@@@group_members_only | EMPTY |
635605
| files | bigfilechunking | 1 |
636-
| files | undelete | 1 |
637-
| files | versioning | 1 |

‎tests/acceptance/features/apiMain/external-storage.feature

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ Feature: external-storage
55
Given using OCS API version "1"
66
And using old DAV path
77

8-
Scenario: Share by link a file inside a local external storage
8+
@public_link_share-feature-required
9+
Scenario: Share by public link a file inside a local external storage
910
Given user "user0" has been created
1011
And user "user1" has been created
1112
And user "user0" has created a folder "/local_storage/foo"

‎tests/acceptance/features/apiMain/transfer-ownership.feature

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ Feature: transfer-ownership
178178
Then the command should have been successful
179179
And the downloaded content when downloading file "/somefile.txt" for user "user2" with range "bytes=0-6" should be "This is"
180180

181-
@skipOnEncryptionType:user-keys
181+
@skipOnEncryptionType:user-keys @public_link_share-feature-required
182182
Scenario: transferring ownership of folder shares which has public link
183183
Given user "user0" has been created
184184
And user "user1" has been created
@@ -245,7 +245,7 @@ Feature: transfer-ownership
245245
And using received transfer folder of "user1" as dav path
246246
And as "user1" the folder "/sub/test" should not exist
247247

248-
@skipOnEncryptionType:user-keys
248+
@skipOnEncryptionType:user-keys @public_link_share-feature-required
249249
Scenario: transferring ownership of folder shared with transfer recipient and public link created of received share works
250250
Given user "user0" has been created
251251
And user "user1" has been created

‎tests/acceptance/features/apiShareManagement/createShare.feature

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ Feature: sharing
6767
| 1 | 100 |
6868
| 2 | 200 |
6969

70+
@public_link_share-feature-required
7071
Scenario Outline: Creating a new public link share of a file
7172
Given using OCS API version "<ocs_api_version>"
7273
When user "user0" creates a public link share using the sharing API with settings
@@ -79,7 +80,7 @@ Feature: sharing
7980
| 1 | 100 |
8081
| 2 | 200 |
8182

82-
@smokeTest
83+
@smokeTest @public_link_share-feature-required
8384
Scenario Outline: Creating a new public link share of a file with password
8485
Given using OCS API version "<ocs_api_version>"
8586
When user "user0" creates a public link share using the sharing API with settings
@@ -93,6 +94,7 @@ Feature: sharing
9394
| 1 | 100 |
9495
| 2 | 200 |
9596

97+
@public_link_share-feature-required
9698
Scenario Outline: Trying to create a new public link share of a file with edit permissions results in a read-only share
9799
Given using OCS API version "<ocs_api_version>"
98100
When user "user0" creates a public link share using the sharing API with settings
@@ -113,6 +115,7 @@ Feature: sharing
113115
| 1 | 100 |
114116
| 2 | 200 |
115117

118+
@public_link_share-feature-required
116119
Scenario Outline: Creating a new public link share of a folder
117120
Given using OCS API version "<ocs_api_version>"
118121
When user "user0" creates a public link share using the sharing API with settings
@@ -152,6 +155,7 @@ Feature: sharing
152155
Then the OCS status code should be "401"
153156
And the HTTP status code should be "401"
154157

158+
@public_link_share-feature-required
155159
Scenario Outline: Creating a link share with no specified permissions defaults to read permissions
156160
Given using OCS API version "<ocs_api_version>"
157161
And user "user0" has created a folder "/afolder"
@@ -168,6 +172,7 @@ Feature: sharing
168172
| 1 | 100 |
169173
| 2 | 200 |
170174

175+
@public_link_share-feature-required
171176
Scenario Outline: Creating a link share with no specified permissions defaults to read permissions when public upload disabled globally
172177
Given using OCS API version "<ocs_api_version>"
173178
And parameter "shareapi_allow_public_upload" of app "core" has been set to "no"
@@ -185,6 +190,7 @@ Feature: sharing
185190
| 1 | 100 |
186191
| 2 | 200 |
187192

193+
@public_link_share-feature-required
188194
Scenario Outline: Creating a link share with edit permissions keeps it
189195
Given using OCS API version "<ocs_api_version>"
190196
And user "user0" has created a folder "/afolder"
@@ -254,6 +260,7 @@ Feature: sharing
254260
| 1 | 100 |
255261
| 2 | 200 |
256262

263+
@public_link_share-feature-required
257264
Scenario Outline: Do not allow public sharing of the root
258265
Given using OCS API version "<ocs_api_version>"
259266
When user "user0" creates a public link share using the sharing API with settings
@@ -264,6 +271,7 @@ Feature: sharing
264271
| 1 | 403 |
265272
| 2 | 403 |
266273

274+
@public_link_share-feature-required
267275
Scenario: Only allow 1 link share per file/folder
268276
Given using OCS API version "1"
269277
And as user "user0"
@@ -444,7 +452,8 @@ Feature: sharing
444452
| 1 | 100 |
445453
| 2 | 200 |
446454

447-
Scenario Outline: user creates a public link share of a file with file name longer than 64 chars
455+
@public_link_share-feature-required
456+
Scenario Outline: user creates a public link share of a file with file name longer than 64 chars
448457
Given using OCS API version "<ocs_api_version>"
449458
And user "user0" has moved file "welcome.txt" to "aquickbrownfoxjumpsoveraverylazydogaquickbrownfoxjumpsoveralazydog.txt"
450459
When user "user0" creates a public link share using the sharing API with settings
@@ -457,7 +466,8 @@ Scenario Outline: user creates a public link share of a file with file name long
457466
| 1 | 100 |
458467
| 2 | 200 |
459468

460-
Scenario Outline: user creates a public link share of a folder with folder name longer than 64 chars
469+
@public_link_share-feature-required
470+
Scenario Outline: user creates a public link share of a folder with folder name longer than 64 chars
461471
Given using OCS API version "<ocs_api_version>"
462472
And user "user0" has created a folder "/aquickbrownfoxjumpsoveraverylazydogaquickbrownfoxjumpsoveralazydog"
463473
And user "user0" has moved file "welcome.txt" to "aquickbrownfoxjumpsoveraverylazydogaquickbrownfoxjumpsoveralazydog/welcome.txt"

‎tests/acceptance/features/apiShareManagement/multilinksharing.feature

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
@api @TestAlsoOnExternalUserBackend
1+
@api @TestAlsoOnExternalUserBackend @public_link_share-feature-required
22
Feature: multilinksharing
33

44
Background:

0 commit comments

Comments
 (0)